From 40f9cfd519a3244929190146a3215ae12b98270b Mon Sep 17 00:00:00 2001 From: Kai Uwe Broulik Date: Thu, 29 Mar 2018 09:21:17 +0200 Subject: [KItemListView] Check if KItemListStyleOption actually changed before emitting a change This avoids work being done when it doesn't need to be. For instance, the preview generator waits for everything to have settled using a 200ms timer before generating a preview. This timer fired also in response to onStyleOptionChanged and needlessly delayed preview generation when navigating between folders despite the style option (e.g. icon size, view mode) not having changed. Differential Revision: https://phabricator.kde.org/D11481 --- src/kitemviews/kitemlistgroupheader.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/kitemviews/kitemlistgroupheader.cpp') diff --git a/src/kitemviews/kitemlistgroupheader.cpp b/src/kitemviews/kitemlistgroupheader.cpp index fb9298989..06a32484a 100644 --- a/src/kitemviews/kitemlistgroupheader.cpp +++ b/src/kitemviews/kitemlistgroupheader.cpp @@ -78,6 +78,10 @@ QVariant KItemListGroupHeader::data() const void KItemListGroupHeader::setStyleOption(const KItemListStyleOption& option) { + if (m_styleOption == option) { + return; + } + const KItemListStyleOption previous = m_styleOption; m_styleOption = option; m_dirtyCache = true; -- cgit v1.3