From 174bc684603326de15e933b3bb24ffb739f3291e Mon Sep 17 00:00:00 2001 From: Méven Car Date: Thu, 22 Jan 2026 16:04:09 +0100 Subject: clang-tidy: use default for trivial constructor --- .../accessibility/kitemlistcontaineraccessible.cpp | 4 +-- src/kitemviews/kfileitemlistview.cpp | 4 +-- src/kitemviews/kfileitemlistwidget.cpp | 8 ++--- src/kitemviews/kitemlistgroupheader.cpp | 4 +-- src/kitemviews/kitemlistheader.cpp | 4 +-- src/kitemviews/kitemlistselectionmanager.cpp | 4 +-- src/kitemviews/kitemliststyleoption.cpp | 4 +-- src/kitemviews/kitemlistview.cpp | 8 ++--- src/kitemviews/kitemlistview.h | 4 +-- src/kitemviews/kitemlistwidget.cpp | 8 ++--- src/kitemviews/kitemmodelbase.cpp | 4 +-- src/kitemviews/kitemset.h | 37 ++++------------------ src/kitemviews/kstandarditemlistgroupheader.cpp | 4 +-- src/kitemviews/kstandarditemlistview.cpp | 4 +-- src/kitemviews/kstandarditemlistwidget.cpp | 4 +-- src/kitemviews/private/kfileitemclipboard.cpp | 4 +-- src/kitemviews/private/kitemlistheaderwidget.cpp | 4 +-- .../private/kitemlistkeyboardsearchmanager.cpp | 4 +-- src/kitemviews/private/kitemlistroleeditor.cpp | 4 +-- src/kitemviews/private/kitemlistrubberband.cpp | 4 +-- .../private/kitemlistselectiontoggle.cpp | 4 +-- .../private/kitemlistsizehintresolver.cpp | 4 +-- src/kitemviews/private/kitemlistsmoothscroller.cpp | 4 +-- src/kitemviews/private/kitemlistviewlayouter.cpp | 4 +-- 24 files changed, 32 insertions(+), 109 deletions(-) (limited to 'src/kitemviews') diff --git a/src/kitemviews/accessibility/kitemlistcontaineraccessible.cpp b/src/kitemviews/accessibility/kitemlistcontaineraccessible.cpp index 6facae06c..fa05f46b9 100644 --- a/src/kitemviews/accessibility/kitemlistcontaineraccessible.cpp +++ b/src/kitemviews/accessibility/kitemlistcontaineraccessible.cpp @@ -21,9 +21,7 @@ KItemListContainerAccessible::KItemListContainerAccessible(KItemListContainer *c { } -KItemListContainerAccessible::~KItemListContainerAccessible() -{ -} +KItemListContainerAccessible::~KItemListContainerAccessible() = default; QString KItemListContainerAccessible::text(QAccessible::Text t) const { diff --git a/src/kitemviews/kfileitemlistview.cpp b/src/kitemviews/kfileitemlistview.cpp index d763fe287..2e3744cea 100644 --- a/src/kitemviews/kfileitemlistview.cpp +++ b/src/kitemviews/kfileitemlistview.cpp @@ -60,9 +60,7 @@ KFileItemListView::KFileItemListView(QGraphicsWidget *parent) setVisibleRoles({"text"}); } -KFileItemListView::~KFileItemListView() -{ -} +KFileItemListView::~KFileItemListView() = default; void KFileItemListView::setPreviewsShown(bool show) { diff --git a/src/kitemviews/kfileitemlistwidget.cpp b/src/kitemviews/kfileitemlistwidget.cpp index 37b115cc3..ccb1819af 100644 --- a/src/kitemviews/kfileitemlistwidget.cpp +++ b/src/kitemviews/kfileitemlistwidget.cpp @@ -23,9 +23,7 @@ KFileItemListWidgetInformant::KFileItemListWidgetInformant() { } -KFileItemListWidgetInformant::~KFileItemListWidgetInformant() -{ -} +KFileItemListWidgetInformant::~KFileItemListWidgetInformant() = default; QString KFileItemListWidgetInformant::itemText(int index, const KItemListView *view) const { @@ -135,9 +133,7 @@ KFileItemListWidget::KFileItemListWidget(KItemListWidgetInformant *informant, QG { } -KFileItemListWidget::~KFileItemListWidget() -{ -} +KFileItemListWidget::~KFileItemListWidget() = default; KItemListWidgetInformant *KFileItemListWidget::createInformant() { diff --git a/src/kitemviews/kitemlistgroupheader.cpp b/src/kitemviews/kitemlistgroupheader.cpp index 20cbc681f..f64ff2884 100644 --- a/src/kitemviews/kitemlistgroupheader.cpp +++ b/src/kitemviews/kitemlistgroupheader.cpp @@ -28,9 +28,7 @@ KItemListGroupHeader::KItemListGroupHeader(QGraphicsWidget *parent) { } -KItemListGroupHeader::~KItemListGroupHeader() -{ -} +KItemListGroupHeader::~KItemListGroupHeader() = default; void KItemListGroupHeader::setRole(const QByteArray &role) { diff --git a/src/kitemviews/kitemlistheader.cpp b/src/kitemviews/kitemlistheader.cpp index 97d0cdfbf..f36be97cd 100644 --- a/src/kitemviews/kitemlistheader.cpp +++ b/src/kitemviews/kitemlistheader.cpp @@ -8,9 +8,7 @@ #include "kitemlistview.h" #include "private/kitemlistheaderwidget.h" -KItemListHeader::~KItemListHeader() -{ -} +KItemListHeader::~KItemListHeader() = default; void KItemListHeader::setAutomaticColumnResizing(bool automatic) { diff --git a/src/kitemviews/kitemlistselectionmanager.cpp b/src/kitemviews/kitemlistselectionmanager.cpp index 6f7f0e077..3cc2fe18c 100644 --- a/src/kitemviews/kitemlistselectionmanager.cpp +++ b/src/kitemviews/kitemlistselectionmanager.cpp @@ -19,9 +19,7 @@ KItemListSelectionManager::KItemListSelectionManager(QObject *parent) { } -KItemListSelectionManager::~KItemListSelectionManager() -{ -} +KItemListSelectionManager::~KItemListSelectionManager() = default; void KItemListSelectionManager::setCurrentItem(int current) { diff --git a/src/kitemviews/kitemliststyleoption.cpp b/src/kitemviews/kitemliststyleoption.cpp index 7ca6bd1d5..b15d517a2 100644 --- a/src/kitemviews/kitemliststyleoption.cpp +++ b/src/kitemviews/kitemliststyleoption.cpp @@ -21,9 +21,7 @@ KItemListStyleOption::KItemListStyleOption() { } -KItemListStyleOption::~KItemListStyleOption() -{ -} +KItemListStyleOption::~KItemListStyleOption() = default; bool KItemListStyleOption::operator==(const KItemListStyleOption &other) const { diff --git a/src/kitemviews/kitemlistview.cpp b/src/kitemviews/kitemlistview.cpp index ac3e6720f..f4ff123ef 100644 --- a/src/kitemviews/kitemlistview.cpp +++ b/src/kitemviews/kitemlistview.cpp @@ -2881,9 +2881,7 @@ QGraphicsWidget *KItemListCreatorBase::popRecycleableWidget() return widget; } -KItemListWidgetCreatorBase::~KItemListWidgetCreatorBase() -{ -} +KItemListWidgetCreatorBase::~KItemListWidgetCreatorBase() = default; void KItemListWidgetCreatorBase::recycle(KItemListWidget *widget) { @@ -2892,9 +2890,7 @@ void KItemListWidgetCreatorBase::recycle(KItemListWidget *widget) pushRecycleableWidget(widget); } -KItemListGroupHeaderCreatorBase::~KItemListGroupHeaderCreatorBase() -{ -} +KItemListGroupHeaderCreatorBase::~KItemListGroupHeaderCreatorBase() = default; void KItemListGroupHeaderCreatorBase::recycle(KItemListGroupHeader *header) { diff --git a/src/kitemviews/kitemlistview.h b/src/kitemviews/kitemlistview.h index 1a4ff0df1..541ee4e9e 100644 --- a/src/kitemviews/kitemlistview.h +++ b/src/kitemviews/kitemlistview.h @@ -938,9 +938,7 @@ public: }; template -KItemListGroupHeaderCreator::~KItemListGroupHeaderCreator() -{ -} +KItemListGroupHeaderCreator::~KItemListGroupHeaderCreator() = default; template KItemListGroupHeader *KItemListGroupHeaderCreator::create(KItemListView *view) diff --git a/src/kitemviews/kitemlistwidget.cpp b/src/kitemviews/kitemlistwidget.cpp index 154196a3c..089211716 100644 --- a/src/kitemviews/kitemlistwidget.cpp +++ b/src/kitemviews/kitemlistwidget.cpp @@ -19,13 +19,9 @@ #include #include -KItemListWidgetInformant::KItemListWidgetInformant() -{ -} +KItemListWidgetInformant::KItemListWidgetInformant() = default; -KItemListWidgetInformant::~KItemListWidgetInformant() -{ -} +KItemListWidgetInformant::~KItemListWidgetInformant() = default; KItemListWidget::KItemListWidget(KItemListWidgetInformant *informant, QGraphicsItem *parent) : QGraphicsWidget(parent) diff --git a/src/kitemviews/kitemmodelbase.cpp b/src/kitemviews/kitemmodelbase.cpp index 9fdecafb8..82e491220 100644 --- a/src/kitemviews/kitemmodelbase.cpp +++ b/src/kitemviews/kitemmodelbase.cpp @@ -24,9 +24,7 @@ KItemModelBase::KItemModelBase(const QByteArray &sortRole, QObject *parent) { } -KItemModelBase::~KItemModelBase() -{ -} +KItemModelBase::~KItemModelBase() = default; bool KItemModelBase::setData(int index, const QHash &values) { diff --git a/src/kitemviews/kitemset.h b/src/kitemviews/kitemset.h index d3562aca4..8dd134ec6 100644 --- a/src/kitemviews/kitemset.h +++ b/src/kitemviews/kitemset.h @@ -57,18 +57,9 @@ public: } public: - iterator(const iterator &other) - : m_rangeIt(other.m_rangeIt) - , m_offset(other.m_offset) - { - } + iterator(const iterator &other) = default; - iterator &operator=(const iterator &other) - { - m_rangeIt = other.m_rangeIt; - m_offset = other.m_offset; - return *this; - } + iterator &operator=(const iterator &other) = default; ~iterator() = default; @@ -142,11 +133,7 @@ public: } public: - const_iterator(const const_iterator &other) - : m_rangeIt(other.m_rangeIt) - , m_offset(other.m_offset) - { - } + const_iterator(const const_iterator &other) = default; explicit const_iterator(const iterator &other) : m_rangeIt(other.m_rangeIt) @@ -154,12 +141,7 @@ public: { } - const_iterator &operator=(const const_iterator &other) - { - m_rangeIt = other.m_rangeIt; - m_offset = other.m_offset; - return *this; - } + const_iterator &operator=(const const_iterator &other) = default; ~const_iterator() = default; @@ -352,18 +334,11 @@ inline KItemSet::KItemSet() { } -inline KItemSet::KItemSet(const KItemSet &other) - : m_itemRanges(other.m_itemRanges) -{ -} +inline KItemSet::KItemSet(const KItemSet &other) = default; inline KItemSet::~KItemSet() = default; -inline KItemSet &KItemSet::operator=(const KItemSet &other) -{ - m_itemRanges = other.m_itemRanges; - return *this; -} +inline KItemSet &KItemSet::operator=(const KItemSet &other) = default; inline int KItemSet::count() const { diff --git a/src/kitemviews/kstandarditemlistgroupheader.cpp b/src/kitemviews/kstandarditemlistgroupheader.cpp index 0960084a3..5b93091d2 100644 --- a/src/kitemviews/kstandarditemlistgroupheader.cpp +++ b/src/kitemviews/kstandarditemlistgroupheader.cpp @@ -19,9 +19,7 @@ KStandardItemListGroupHeader::KStandardItemListGroupHeader(QGraphicsWidget *pare { } -KStandardItemListGroupHeader::~KStandardItemListGroupHeader() -{ -} +KStandardItemListGroupHeader::~KStandardItemListGroupHeader() = default; void KStandardItemListGroupHeader::paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget) { diff --git a/src/kitemviews/kstandarditemlistview.cpp b/src/kitemviews/kstandarditemlistview.cpp index 0d57388f3..53d9dd377 100644 --- a/src/kitemviews/kstandarditemlistview.cpp +++ b/src/kitemviews/kstandarditemlistview.cpp @@ -22,9 +22,7 @@ KStandardItemListView::KStandardItemListView(QGraphicsWidget *parent) setAlternateBackgrounds(true); } -KStandardItemListView::~KStandardItemListView() -{ -} +KStandardItemListView::~KStandardItemListView() = default; void KStandardItemListView::setItemLayout(ItemLayout layout) { diff --git a/src/kitemviews/kstandarditemlistwidget.cpp b/src/kitemviews/kstandarditemlistwidget.cpp index f197644c6..494473c62 100644 --- a/src/kitemviews/kstandarditemlistwidget.cpp +++ b/src/kitemviews/kstandarditemlistwidget.cpp @@ -36,9 +36,7 @@ KStandardItemListWidgetInformant::KStandardItemListWidgetInformant() { } -KStandardItemListWidgetInformant::~KStandardItemListWidgetInformant() -{ -} +KStandardItemListWidgetInformant::~KStandardItemListWidgetInformant() = default; void KStandardItemListWidgetInformant::calculateItemSizeHints(QVector> &logicalHeightHints, qreal &logicalWidthHint, diff --git a/src/kitemviews/private/kfileitemclipboard.cpp b/src/kitemviews/private/kfileitemclipboard.cpp index 47718fa02..b48d4732e 100644 --- a/src/kitemviews/private/kfileitemclipboard.cpp +++ b/src/kitemviews/private/kfileitemclipboard.cpp @@ -34,9 +34,7 @@ QList KFileItemClipboard::cutItems() const return m_cutItems.values(); } -KFileItemClipboard::~KFileItemClipboard() -{ -} +KFileItemClipboard::~KFileItemClipboard() = default; void KFileItemClipboard::updateCutItems() { diff --git a/src/kitemviews/private/kitemlistheaderwidget.cpp b/src/kitemviews/private/kitemlistheaderwidget.cpp index c598e5fb2..b147ecce2 100644 --- a/src/kitemviews/private/kitemlistheaderwidget.cpp +++ b/src/kitemviews/private/kitemlistheaderwidget.cpp @@ -63,9 +63,7 @@ KItemListHeaderWidget::KItemListHeaderWidget(QGraphicsWidget *parent) setFont(QApplication::font("QHeaderView")); } -KItemListHeaderWidget::~KItemListHeaderWidget() -{ -} +KItemListHeaderWidget::~KItemListHeaderWidget() = default; void KItemListHeaderWidget::setModel(KItemModelBase *model) { diff --git a/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp b/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp index f2f834c4c..19ce0cf21 100644 --- a/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp +++ b/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp @@ -15,9 +15,7 @@ KItemListKeyboardSearchManager::KItemListKeyboardSearchManager(QObject *parent) m_keyboardInputTime.invalidate(); } -KItemListKeyboardSearchManager::~KItemListKeyboardSearchManager() -{ -} +KItemListKeyboardSearchManager::~KItemListKeyboardSearchManager() = default; bool KItemListKeyboardSearchManager::shouldClearSearchIfInputTimeReached() { diff --git a/src/kitemviews/private/kitemlistroleeditor.cpp b/src/kitemviews/private/kitemlistroleeditor.cpp index 895a97aea..6105d604f 100644 --- a/src/kitemviews/private/kitemlistroleeditor.cpp +++ b/src/kitemviews/private/kitemlistroleeditor.cpp @@ -27,9 +27,7 @@ KItemListRoleEditor::KItemListRoleEditor(QWidget *parent) connect(this, &KItemListRoleEditor::textChanged, this, &KItemListRoleEditor::autoAdjustSize); } -KItemListRoleEditor::~KItemListRoleEditor() -{ -} +KItemListRoleEditor::~KItemListRoleEditor() = default; void KItemListRoleEditor::setRole(const QByteArray &role) { diff --git a/src/kitemviews/private/kitemlistrubberband.cpp b/src/kitemviews/private/kitemlistrubberband.cpp index 96f87b431..0bc8f11f1 100644 --- a/src/kitemviews/private/kitemlistrubberband.cpp +++ b/src/kitemviews/private/kitemlistrubberband.cpp @@ -14,9 +14,7 @@ KItemListRubberBand::KItemListRubberBand(QObject *parent) { } -KItemListRubberBand::~KItemListRubberBand() -{ -} +KItemListRubberBand::~KItemListRubberBand() = default; void KItemListRubberBand::setStartPosition(const QPointF &pos) { diff --git a/src/kitemviews/private/kitemlistselectiontoggle.cpp b/src/kitemviews/private/kitemlistselectiontoggle.cpp index df61b3073..f1a6583a4 100644 --- a/src/kitemviews/private/kitemlistselectiontoggle.cpp +++ b/src/kitemviews/private/kitemlistselectiontoggle.cpp @@ -18,9 +18,7 @@ KItemListSelectionToggle::KItemListSelectionToggle(QGraphicsItem *parent) { } -KItemListSelectionToggle::~KItemListSelectionToggle() -{ -} +KItemListSelectionToggle::~KItemListSelectionToggle() = default; void KItemListSelectionToggle::setChecked(bool checked) { diff --git a/src/kitemviews/private/kitemlistsizehintresolver.cpp b/src/kitemviews/private/kitemlistsizehintresolver.cpp index b7165e8c3..b7d11f54e 100644 --- a/src/kitemviews/private/kitemlistsizehintresolver.cpp +++ b/src/kitemviews/private/kitemlistsizehintresolver.cpp @@ -16,9 +16,7 @@ KItemListSizeHintResolver::KItemListSizeHintResolver(const KItemListView *itemLi { } -KItemListSizeHintResolver::~KItemListSizeHintResolver() -{ -} +KItemListSizeHintResolver::~KItemListSizeHintResolver() = default; QSizeF KItemListSizeHintResolver::minSizeHint() { diff --git a/src/kitemviews/private/kitemlistsmoothscroller.cpp b/src/kitemviews/private/kitemlistsmoothscroller.cpp index 14a280e33..b7d0a8cd4 100644 --- a/src/kitemviews/private/kitemlistsmoothscroller.cpp +++ b/src/kitemviews/private/kitemlistsmoothscroller.cpp @@ -40,9 +40,7 @@ KItemListSmoothScroller::KItemListSmoothScroller(QScrollBar *scrollBar, QObject m_scrollBar->installEventFilter(this); } -KItemListSmoothScroller::~KItemListSmoothScroller() -{ -} +KItemListSmoothScroller::~KItemListSmoothScroller() = default; void KItemListSmoothScroller::setScrollBar(QScrollBar *scrollBar) { diff --git a/src/kitemviews/private/kitemlistviewlayouter.cpp b/src/kitemviews/private/kitemlistviewlayouter.cpp index 3ed2343a8..fdf59812f 100644 --- a/src/kitemviews/private/kitemlistviewlayouter.cpp +++ b/src/kitemviews/private/kitemlistviewlayouter.cpp @@ -45,9 +45,7 @@ KItemListViewLayouter::KItemListViewLayouter(KItemListSizeHintResolver *sizeHint Q_ASSERT(m_sizeHintResolver); } -KItemListViewLayouter::~KItemListViewLayouter() -{ -} +KItemListViewLayouter::~KItemListViewLayouter() = default; void KItemListViewLayouter::setScrollOrientation(Qt::Orientation orientation) { -- cgit v1.3