From e60e3f07cf00823efdde3855cda0dfce36e74c52 Mon Sep 17 00:00:00 2001 From: Nathaniel Graham Date: Thu, 16 Nov 2017 07:23:46 -0700 Subject: Use KConfig::readEntry()'s default argument properly Summary: Follow-on patch to D7440 to use KConfig::readEntry()'s default argument properly to reduce some unnecessary code Test Plan: Tested in KDE Neon. no regressions; by default, all plugins are enabled if the key is not set, and if it is set, user changes to the list are remembered Reviewers: #dolphin, elvisangelaccio, dfaure, apol Reviewed By: #dolphin, elvisangelaccio, apol Differential Revision: https://phabricator.kde.org/D8846 --- src/kitemviews/kfileitemmodelrolesupdater.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'src/kitemviews') diff --git a/src/kitemviews/kfileitemmodelrolesupdater.cpp b/src/kitemviews/kfileitemmodelrolesupdater.cpp index 8ea106a5e..11d01b2cf 100644 --- a/src/kitemviews/kfileitemmodelrolesupdater.cpp +++ b/src/kitemviews/kfileitemmodelrolesupdater.cpp @@ -99,10 +99,7 @@ KFileItemModelRolesUpdater::KFileItemModelRolesUpdater(KFileItemModel* model, QO Q_ASSERT(model); const KConfigGroup globalConfig(KSharedConfig::openConfig(), "PreviewSettings"); - m_enabledPlugins = globalConfig.readEntry("Plugins", QStringList()); - if (m_enabledPlugins.isEmpty()) { - m_enabledPlugins = KIO::PreviewJob::defaultPlugins(); - } + m_enabledPlugins = globalConfig.readEntry("Plugins", KIO::PreviewJob::defaultPlugins()); connect(m_model, &KFileItemModel::itemsInserted, this, &KFileItemModelRolesUpdater::slotItemsInserted); -- cgit v1.3