From 405aa4878f755b06123711f4cdbc8507cc15c18e Mon Sep 17 00:00:00 2001 From: Méven Car Date: Sun, 24 Mar 2019 18:32:25 +0100 Subject: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled Summary: Bug symptom : {F6698879} Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled. Test Plan: # In dolphin with an information panel with preview on # launch the video preview # Disable the preview ->bug 1: the video player control is still visible (this bug fix this) # re-enable preview -> bug 2: the video stays visible and the preview is displayed above (this bug fix this) Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19844 --- src/panels/information/informationpanel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/panels/information/informationpanel.cpp') diff --git a/src/panels/information/informationpanel.cpp b/src/panels/information/informationpanel.cpp index 2b6fff158..e5257bc72 100644 --- a/src/panels/information/informationpanel.cpp +++ b/src/panels/information/informationpanel.cpp @@ -199,8 +199,8 @@ void InformationPanel::showContextMenu(const QPoint &pos) { const bool isChecked = action->isChecked(); if (action == previewAction) { - m_content->setPreviewVisible(isChecked); InformationPanelSettings::setPreviewsShown(isChecked); + m_content->refreshPreview(); } else if (action == configureAction) { FileMetaDataConfigurationDialog* dialog = new FileMetaDataConfigurationDialog(this); dialog->setDescription(i18nc("@label::textbox", -- cgit v1.3