From 405aa4878f755b06123711f4cdbc8507cc15c18e Mon Sep 17 00:00:00 2001 From: Méven Car Date: Sun, 24 Mar 2019 18:32:25 +0100 Subject: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled Summary: Bug symptom : {F6698879} Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled. Test Plan: # In dolphin with an information panel with preview on # launch the video preview # Disable the preview ->bug 1: the video player control is still visible (this bug fix this) # re-enable preview -> bug 2: the video stays visible and the preview is displayed above (this bug fix this) Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19844 --- src/panels/information/informationpanelcontent.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'src/panels/information/informationpanelcontent.h') diff --git a/src/panels/information/informationpanelcontent.h b/src/panels/information/informationpanelcontent.h index a80775aaa..83fb3d80b 100644 --- a/src/panels/information/informationpanelcontent.h +++ b/src/panels/information/informationpanelcontent.h @@ -68,21 +68,24 @@ public: void showItem(const KFileItem& item); /** - * Shows the meta information for the items \p items. + * Shows the meta information for the items \p items and its preview */ void showItems(const KFileItemList& items); - void setPreviewVisible(bool visible); - KFileItemList items(); + /** + * Refreshes the preview display, hiding it if needed + */ + void refreshPreview(); + signals: void urlActivated( const QUrl& url ); public slots: /** * Is invoked after the file meta data configuration dialog has been - * closed and refreshes the visibility of the meta data. + * closed and refreshes the displayed meta data by the panel. */ void refreshMetaData(); -- cgit v1.3