From 993c47f30923e39b33dbd47a2a62e3dde5ccdbe4 Mon Sep 17 00:00:00 2001 From: Nathaniel Graham Date: Mon, 2 Apr 2018 16:52:08 -0600 Subject: Show folder previews for items that have a Places Panel entry Summary: informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug. BUG: 392621 FIXED-IN: 18.08.0 Test Plan: Before: {F5782793} After: {F5782794} Detailed test procedure: - Open the Information Panel - Turn on previews - Put some pictures in ~/Pictures - Hover over it and see that the Information Panel shows a preview of its contents - Add ~/Pictures to the Places panel - Hover over it again and see that previews are no longer displayed - Apply the patch and restart Dolphin - Hover over it once more and see that there are now previews, yay! Reviewers: #dolphin, markg, elvisangelaccio Reviewed By: markg, elvisangelaccio Subscribers: markg, broulik Differential Revision: https://phabricator.kde.org/D11894 --- src/panels/information/informationpanelcontent.h | 8 -------- 1 file changed, 8 deletions(-) (limited to 'src/panels/information/informationpanelcontent.h') diff --git a/src/panels/information/informationpanelcontent.h b/src/panels/information/informationpanelcontent.h index 80f3c8e22..9223fcc5a 100644 --- a/src/panels/information/informationpanelcontent.h +++ b/src/panels/information/informationpanelcontent.h @@ -115,14 +115,6 @@ private slots: void refreshMetaData(); private: - /** - * Checks whether the an URL is repesented by a place. If yes, - * then the place icon and name are shown instead of a preview. - * @return True, if the URL represents exactly a place. - * @param url The url to check. - */ - bool applyPlace(const QUrl& url); - /** * Sets the text for the label \a m_nameLabel and assures that the * text is split in a way that it can be wrapped within the -- cgit v1.3