From 580c31cccee1646db85bbf3a033911858bf79d7a Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Mardelle Date: Fri, 19 Sep 2025 13:31:03 +0200 Subject: informationpanel: prevent a crash when creating video preview panel and a media file is selected To reproduce the crash: - Open Dolphin, disable information panel and close Dolphin - Re-open Dolphin - Select a video file - Enable information panel - Crash Problem is that some elements of the MediaWidget panel are created when the widget is shown, in `showEvent` (`m_seekSlider` and `m_topLayout`), and these elements are called before being created. This MR fixes 2 different crashes: - Crash creating panel when a video file is selected (call to `m_seekSlider` before its creation) - Crash creating panel when a video file is selected and autoplay enabled (call to `m_topLayout` before its creation) --- src/panels/information/mediawidget.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/panels/information/mediawidget.h') diff --git a/src/panels/information/mediawidget.h b/src/panels/information/mediawidget.h index bd04266e6..f5b970d5e 100644 --- a/src/panels/information/mediawidget.h +++ b/src/panels/information/mediawidget.h @@ -70,6 +70,7 @@ private: void applyVideoSize(); void togglePlayback(); void initPlayer(); + void initLayout(); QUrl m_url; QSize m_videoSize; -- cgit v1.3.1