From 277700425e7d77345de74ff0c6dc58fb0aca193c Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Sat, 13 Oct 2018 18:49:35 +0200 Subject: [PlacesItemModelTest] Revert last two commits Commit c527dc2172 proves that on the CI sometimes the `QAbstractItemModel::dataChanged` signal is not being emitted at all (build #208 failed because the test timed out). KFilePlacesModel emits `dataChanged()` in the `_k_reloadBookmarks()` slot only when it's called after the KBookmarkManager emits the `changed()` signal. And the `changed()` signal is emitted after KDirWatch emits the `created` signal. On the CI server kdirwatch is probably not reliable, which would explain why the test randomly fails. --- src/panels/places/placesitemmodel.h | 1 - 1 file changed, 1 deletion(-) (limited to 'src/panels/places/placesitemmodel.h') diff --git a/src/panels/places/placesitemmodel.h b/src/panels/places/placesitemmodel.h index 33760f217..c4ff7e2dd 100644 --- a/src/panels/places/placesitemmodel.h +++ b/src/panels/places/placesitemmodel.h @@ -145,7 +145,6 @@ signals: void storageSetupDone(int index, bool success); void storageTearDownRequested(const QString& mountPath); void storageTearDownExternallyRequested(const QString& mountPath); - void sourceModelDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector &roles = QVector()); protected: void onItemInserted(int index) override; -- cgit v1.3