From c900f7d255aa8fb326cf20f598a5de1a1edbcfe9 Mon Sep 17 00:00:00 2001 From: Chris Rizzitello Date: Sun, 11 Nov 2018 16:02:08 -0500 Subject: Improve Ux for the places panel's hidden items Summary: BUG: 400860 FIXED-IN: 18.12.0 Clean up the context menu for the places panel. - Change Text "Show All Entries" -> "Show Hidden Places" - Use State dependent icon (like hidden files) - Disable instead of hide if not places are hidden. - Toggle to unchecked if last item of group is unhidden. Create a copy of this "Show Hidden Places" entry in the main dolphin menu View->Places. Test Plan: With Hidden Places {F6398756} {F6398759} Context Menu: {F6398762} {F6398761} Without Hidden Places. {F6414694} {F6414696} Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham Reviewed By: #dolphin, #vdg, elvisangelaccio, ngraham Subscribers: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel Tags: #dolphin Maniphest Tasks: T8349 Differential Revision: https://phabricator.kde.org/D16767 --- src/panels/places/placespanel.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/panels/places/placespanel.h') diff --git a/src/panels/places/placespanel.h b/src/panels/places/placespanel.h index c6f959d23..9d9624ff8 100644 --- a/src/panels/places/placespanel.h +++ b/src/panels/places/placespanel.h @@ -49,6 +49,7 @@ signals: void errorMessage(const QString& error); void storageTearDownRequested(const QString& mountPath); void storageTearDownExternallyRequested(const QString& mountPath); + void showHiddenEntriesChanged(bool shown); protected: bool urlChanged() override; @@ -56,6 +57,8 @@ protected: public slots: void readSettings() override; + void showHiddenEntries(bool shown); + int hiddenListCount(); private slots: void slotItemActivated(int index); -- cgit v1.3.1