From 0d6302ef9be3387d3a62093ae18c92ec84e5a2e1 Mon Sep 17 00:00:00 2001 From: Sebastian Englbrecht Date: Sat, 23 May 2026 15:31:27 +0200 Subject: terminalpanel: delete konsolePart in destructor, use unique_ptr for KXMLGUIBuilder Deleting konsolePart before QObject child cleanup ensures m_konsolePartClientBuilder is still alive when the lambda connected to m_terminalWidget::destroyed fires and calls factory->removeClient(). --- src/panels/terminal/terminalpanel.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/panels/terminal/terminalpanel.h') diff --git a/src/panels/terminal/terminalpanel.h b/src/panels/terminal/terminalpanel.h index 7f4e9e36c..d6ed4b981 100644 --- a/src/panels/terminal/terminalpanel.h +++ b/src/panels/terminal/terminalpanel.h @@ -12,6 +12,9 @@ #include +#include + +class KXMLGUIBuilder; class TerminalInterface; class KActionCollection; class KMessageWidget; @@ -94,6 +97,7 @@ private: QWidget *m_terminalWidget; KMessageWidget *m_konsolePartMissingMessage; KParts::ReadOnlyPart *m_konsolePart; + std::unique_ptr m_konsolePartClientBuilder; QString m_konsolePartCurrentDirectory; QQueue m_sendCdToTerminalHistory; org::kde::KIOFuse::VFS m_kiofuseInterface; -- cgit v1.3.1