From 94b2b2a2dbd3b861f74277b273ab268f28e8678a Mon Sep 17 00:00:00 2001 From: Renato Araujo Oliveira Filho Date: Wed, 20 Dec 2017 15:26:35 -0300 Subject: Fix PlacesItemModel loading with hidden devices Summary: Make sure that hidden devices loaded after module initialization does not appear in the view. Check for item visibility before add it on the model. Test Plan: Unit test created Reviewers: franckarrecot Reviewed By: franckarrecot Subscribers: cfeck, ervin, #dolphin Differential Revision: https://phabricator.kde.org/D9441 --- src/panels/places/placesitemmodel.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/panels') diff --git a/src/panels/places/placesitemmodel.cpp b/src/panels/places/placesitemmodel.cpp index 577596c74..b23877629 100644 --- a/src/panels/places/placesitemmodel.cpp +++ b/src/panels/places/placesitemmodel.cpp @@ -392,6 +392,10 @@ void PlacesItemModel::dropMimeDataBefore(int index, const QMimeData* mimeData) void PlacesItemModel::addItemFromSourceModel(const QModelIndex &index) { + if (!m_hiddenItemsShown && m_sourceModel->isHidden(index)) { + return; + } + const KBookmark bookmark = m_sourceModel->bookmarkForIndex(index); Q_ASSERT(!bookmark.isNull()); PlacesItem *item = new PlacesItem(bookmark); -- cgit v1.3