From 983273924d2887cdccdd7c3618d332b52dc0dad6 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Thu, 26 Sep 2019 12:31:05 -0600 Subject: Expose full set of script execution options in settings window Summary: Right now the script execution setting is a checkbox, capable only of handling boolean input. This is not appropriate because there are actually three options available. Accordingly, this patch replaces the checkbox with a combobox (to save space compared to radio buttons) that clearly exposes all three options. BUG: 371837 FIXED-IN: 19.12.0 Test Plan: {F7440559} - All three options do what they say they'll do - All options get saved properly - The combobox displays the correct option when the window is loaded - The {nav Defaults} button resets it to "always ask" as expected Reviewers: elvisangelaccio, #dolphin, #vdg Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T9932 Differential Revision: https://phabricator.kde.org/D24247 --- src/settings/general/confirmationssettingspage.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/settings/general/confirmationssettingspage.h') diff --git a/src/settings/general/confirmationssettingspage.h b/src/settings/general/confirmationssettingspage.h index 52b101b2a..c15afdc38 100644 --- a/src/settings/general/confirmationssettingspage.h +++ b/src/settings/general/confirmationssettingspage.h @@ -23,6 +23,7 @@ #include "settings/settingspagebase.h" class QCheckBox; +class QComboBox; /** * @brief Page for the enabling or disabling confirmation dialogs. @@ -54,7 +55,7 @@ private: #endif QCheckBox* m_confirmClosingMultipleTabs; - QCheckBox* m_confirmScriptExecution; + QComboBox* m_confirmScriptExecution; }; #endif -- cgit v1.3.1