From 5f252da8b58e03b623e56f788ff6d1056269c005 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Tue, 4 Sep 2018 14:20:33 +0200 Subject: Correctly save behaviourOnLaunch Summary: We only wrote out a checkbox value if the checkbox was checked. Unchecking it would not do anything. BUG: 398022 Test Plan: Read KRun's exepcted values Unchecked config option Reloaded dolphin Checkbox remained off Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15147 --- src/settings/general/confirmationssettingspage.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/settings') diff --git a/src/settings/general/confirmationssettingspage.cpp b/src/settings/general/confirmationssettingspage.cpp index d96dfe0b2..b881b7a52 100644 --- a/src/settings/general/confirmationssettingspage.cpp +++ b/src/settings/general/confirmationssettingspage.cpp @@ -92,13 +92,14 @@ void ConfirmationsSettingsPage::applySettings() confirmationGroup.writeEntry("ConfirmTrash", m_confirmMoveToTrash->isChecked()); confirmationGroup.writeEntry("ConfirmEmptyTrash", m_confirmEmptyTrash->isChecked()); confirmationGroup.writeEntry("ConfirmDelete", m_confirmDelete->isChecked()); - confirmationGroup.sync(); + KConfigGroup scriptExecutionGroup(kioConfig, "Executable scripts"); if (m_confirmScriptExecution->isChecked()) { - KConfigGroup scriptExecutionGroup(kioConfig, "Executable scripts"); scriptExecutionGroup.writeEntry("behaviourOnLaunch", "alwaysAsk"); - scriptExecutionGroup.sync(); + } else { + scriptExecutionGroup.writeEntry("behaviourOnLaunch", "dontAsk"); } + kioConfig->sync(); GeneralSettings* settings = GeneralSettings::self(); settings->setConfirmClosingMultipleTabs(m_confirmClosingMultipleTabs->isChecked()); -- cgit v1.3