From d3637f380ccca26a281331a02ce76ed60e84cfe3 Mon Sep 17 00:00:00 2001 From: Felix Ernst Date: Sat, 18 Nov 2023 12:31:00 +0100 Subject: Turn free space label into a flat button The usage of a label to show this space information is problematic because there are features/actions hidden behind clicking the label. A button makes this clear. It also fixes the accessibility of this control because previously this info would never be read out by screen readers as it couldn't get keyboard focus. A side-effect of this change is that the free disk space bar looks more normal with non-Breeze styles. This had been a long-standing issue. --- src/statusbar/statusbarspaceinfo.cpp | 109 ++++++++++++++++++++--------------- 1 file changed, 61 insertions(+), 48 deletions(-) (limited to 'src/statusbar/statusbarspaceinfo.cpp') diff --git a/src/statusbar/statusbarspaceinfo.cpp b/src/statusbar/statusbarspaceinfo.cpp index 546c217a7..b9dafe997 100644 --- a/src/statusbar/statusbarspaceinfo.cpp +++ b/src/statusbar/statusbarspaceinfo.cpp @@ -8,20 +8,35 @@ #include "spaceinfoobserver.h" +#include #include #include #include #include +#include #include #include #include +#include StatusBarSpaceInfo::StatusBarSpaceInfo(QWidget *parent) - : KCapacityBar(KCapacityBar::DrawTextInline, parent) + : QWidget(parent) , m_observer(nullptr) { - setCursor(Qt::PointingHandCursor); + m_capacityBar = new KCapacityBar(KCapacityBar::DrawTextInline, this); + m_textInfoButton = new QToolButton(this); + m_textInfoButton->setAutoRaise(true); + m_textInfoButton->setPopupMode(QToolButton::InstantPopup); + m_buttonMenu = new QMenu(this); + m_textInfoButton->setMenu(m_buttonMenu); + connect(m_buttonMenu, &QMenu::aboutToShow, this, &StatusBarSpaceInfo::updateMenu); + + auto layout = new QHBoxLayout(this); + // We reduce the outside margin of the flat button so it visually has the same margin as the status bar text label on the other end of the bar. + layout->setContentsMargins(2, -1, 0, -1); // "-1" makes it so the fixed height won't be ignored. + layout->addWidget(m_capacityBar); + layout->addWidget(m_textInfoButton); } StatusBarSpaceInfo::~StatusBarSpaceInfo() @@ -65,7 +80,7 @@ void StatusBarSpaceInfo::showEvent(QShowEvent *event) { if (m_shown) { if (m_ready) { - KCapacityBar::showEvent(event); + QWidget::showEvent(event); } if (m_observer.isNull()) { @@ -81,71 +96,68 @@ void StatusBarSpaceInfo::hideEvent(QHideEvent *event) m_observer.reset(); m_ready = false; } - KCapacityBar::hideEvent(event); + QWidget::hideEvent(event); } -void StatusBarSpaceInfo::mousePressEvent(QMouseEvent *event) +void StatusBarSpaceInfo::updateMenu() { - if (event->button() == Qt::LeftButton) { - // Creates a menu with tools that help to find out more about free - // disk space for the given url. + m_buttonMenu->clear(); - const KService::Ptr filelight = KService::serviceByDesktopName(QStringLiteral("org.kde.filelight")); - const KService::Ptr kdiskfree = KService::serviceByDesktopName(QStringLiteral("org.kde.kdf")); + // Creates a menu with tools that help to find out more about free + // disk space for the given url. - if (!filelight && !kdiskfree) { - // nothing to show - return; - } - - QMenu *menu = new QMenu(this); - - if (filelight) { - QAction *filelightFolderAction = menu->addAction(QIcon::fromTheme(QStringLiteral("filelight")), i18n("Disk Usage Statistics - current folder")); + const KService::Ptr filelight = KService::serviceByDesktopName(QStringLiteral("org.kde.filelight")); + const KService::Ptr kdiskfree = KService::serviceByDesktopName(QStringLiteral("org.kde.kdf")); - menu->connect(filelightFolderAction, &QAction::triggered, menu, [this, filelight](bool) { - auto *job = new KIO::ApplicationLauncherJob(filelight); - job->setUrls({m_url}); - job->start(); - }); + if (!filelight && !kdiskfree) { + // nothing to show + return; + } - // For remote URLs like FTP analyzing the device makes no sense - if (m_url.isLocalFile()) { - QAction *filelightDiskAction = menu->addAction(QIcon::fromTheme(QStringLiteral("filelight")), i18n("Disk Usage Statistics - current device")); + if (filelight) { + QAction *filelightFolderAction = m_buttonMenu->addAction(QIcon::fromTheme(QStringLiteral("filelight")), i18n("Disk Usage Statistics - current folder")); - menu->connect(filelightDiskAction, &QAction::triggered, menu, [this, filelight](bool) { - const QStorageInfo info(m_url.toLocalFile()); + m_buttonMenu->connect(filelightFolderAction, &QAction::triggered, m_buttonMenu, [this, filelight](bool) { + auto *job = new KIO::ApplicationLauncherJob(filelight); + job->setUrls({m_url}); + job->start(); + }); - if (info.isValid() && info.isReady()) { - auto *job = new KIO::ApplicationLauncherJob(filelight); - job->setUrls({QUrl::fromLocalFile(info.rootPath())}); - job->start(); - } - }); - } + // For remote URLs like FTP analyzing the device makes no sense + if (m_url.isLocalFile()) { + QAction *filelightDiskAction = + m_buttonMenu->addAction(QIcon::fromTheme(QStringLiteral("filelight")), i18n("Disk Usage Statistics - current device")); - QAction *filelightAllAction = menu->addAction(QIcon::fromTheme(QStringLiteral("filelight")), i18n("Disk Usage Statistics - all devices")); - - menu->connect(filelightAllAction, &QAction::triggered, menu, [this, filelight](bool) { + m_buttonMenu->connect(filelightDiskAction, &QAction::triggered, m_buttonMenu, [this, filelight](bool) { const QStorageInfo info(m_url.toLocalFile()); if (info.isValid() && info.isReady()) { auto *job = new KIO::ApplicationLauncherJob(filelight); + job->setUrls({QUrl::fromLocalFile(info.rootPath())}); job->start(); } }); } - if (kdiskfree) { - QAction *kdiskfreeAction = menu->addAction(QIcon::fromTheme(QStringLiteral("kdf")), i18n("KDiskFree")); + QAction *filelightAllAction = m_buttonMenu->addAction(QIcon::fromTheme(QStringLiteral("filelight")), i18n("Disk Usage Statistics - all devices")); + + m_buttonMenu->connect(filelightAllAction, &QAction::triggered, m_buttonMenu, [this, filelight](bool) { + const QStorageInfo info(m_url.toLocalFile()); - connect(kdiskfreeAction, &QAction::triggered, this, [kdiskfree] { - auto *job = new KIO::ApplicationLauncherJob(kdiskfree); + if (info.isValid() && info.isReady()) { + auto *job = new KIO::ApplicationLauncherJob(filelight); job->start(); - }); - } + } + }); + } + + if (kdiskfree) { + QAction *kdiskfreeAction = m_buttonMenu->addAction(QIcon::fromTheme(QStringLiteral("kdf")), i18n("KDiskFree")); - menu->exec(QCursor::pos()); + connect(kdiskfreeAction, &QAction::triggered, this, [kdiskfree] { + auto *job = new KIO::ApplicationLauncherJob(kdiskfree); + job->start(); + }); } } @@ -165,10 +177,11 @@ void StatusBarSpaceInfo::slotValuesChanged() const quint64 used = size - available; const int percentUsed = qRound(100.0 * qreal(used) / qreal(size)); - setText(i18nc("@info:status Free disk space", "%1 free", KIO::convertSize(available))); + m_textInfoButton->setText(i18nc("@info:status Free disk space", "%1 free", KIO::convertSize(available))); setToolTip(i18nc("tooltip:status Free disk space", "%1 free out of %2 (%3% used)", KIO::convertSize(available), KIO::convertSize(size), percentUsed)); + m_textInfoButton->setToolTip(toolTip()); setUpdatesEnabled(false); - setValue(percentUsed); + m_capacityBar->setValue(percentUsed); setUpdatesEnabled(true); if (!isVisible()) { -- cgit v1.3