From 5ccdce11680528d1e993bffe2cae8417b5aba8c8 Mon Sep 17 00:00:00 2001 From: Méven Car Date: Sat, 13 Jun 2026 15:24:49 +0000 Subject: smoothscroller: always emit scrollingStopped from scrollTo When scrollTo() is asked to move to the position the scrollbar already holds (clamped, e.g. an item at the bottom, or a sub-pixel offset), no animation runs and scrollingStopped() was never emitted. Callers waiting for it stayed blocked: KItemListView::scrollToItem() delegates to scrollTo for any non-zero offset, and DolphinView::renameSelectedItems() only opens the inline rename editor once scrollingStopped() arrives. So inline rename silently did nothing for the affected items. Emit scrollingStopped() in the no-op case too, and add a regression test. --- src/tests/CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/tests/CMakeLists.txt') diff --git a/src/tests/CMakeLists.txt b/src/tests/CMakeLists.txt index cac38deae..3ac657215 100644 --- a/src/tests/CMakeLists.txt +++ b/src/tests/CMakeLists.txt @@ -15,6 +15,9 @@ ecm_add_test(kitemsettest.cpp LINK_LIBRARIES dolphinprivate Qt6::Test) # KItemRangeTest ecm_add_test(kitemrangetest.cpp LINK_LIBRARIES dolphinprivate Qt6::Test) +# KItemListSmoothScrollerTest +ecm_add_test(kitemlistsmoothscrollertest.cpp LINK_LIBRARIES dolphinprivate Qt6::Test) + # KItemListSelectionManagerTest ecm_add_test(kitemlistselectionmanagertest.cpp LINK_LIBRARIES dolphinprivate Qt6::Test) -- cgit v1.3.1