From a48679b36b876815fccab3ab8559734f29372907 Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Sun, 9 Jan 2011 15:03:30 +0000 Subject: Fix implementation of DolphinView::invertSelection() which assures that DolphinView::hasSelection() provides a valid return-value. This looks like an issue in Qt, but I did not have the time yet to provide a Qt-only example for a bug-report :-( svn path=/trunk/KDE/kdebase/apps/; revision=1213199 --- src/tests/dolphinviewtest_allviewmodes.cpp | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) (limited to 'src/tests/dolphinviewtest_allviewmodes.cpp') diff --git a/src/tests/dolphinviewtest_allviewmodes.cpp b/src/tests/dolphinviewtest_allviewmodes.cpp index 9d13c6a5c..d1557be05 100644 --- a/src/tests/dolphinviewtest_allviewmodes.cpp +++ b/src/tests/dolphinviewtest_allviewmodes.cpp @@ -83,13 +83,11 @@ void DolphinViewTest_AllViewModes::testSelection() { m_view->selectAll(); verifySelectedItemsCount(totalItems); - // TODO: DolphinView::invertSelection() does not work in combination with DolphinView::hasSelection(). Might - // be a Qt-issue - further investigations are needed. - //m_view->invertSelection(); - //verifySelectedItemsCount(0); - // - //m_view->invertSelection(); - //verifySelectedItemsCount(totalItems); + m_view->invertSelection(); + verifySelectedItemsCount(0); + + m_view->invertSelection(); + verifySelectedItemsCount(totalItems); m_view->clearSelection(); verifySelectedItemsCount(0); @@ -149,14 +147,6 @@ void DolphinViewTest_AllViewModes::verifySelectedItemsCount(int itemsCount) cons QVERIFY(m_view->hasSelection()); } else { - if (mode() == DolphinView::ColumnView && - itemView()->selectionModel()->selectedIndexes().count() == 0 && - itemView()->selectionModel()->hasSelection()) { - QEXPECT_FAIL("", - "The selection model's hasSelection() method returns true, but there are no selected indexes. Needs to be investigated.", - Continue); - } - QVERIFY(!m_view->hasSelection()); } } -- cgit v1.3