From 01ff60edeea76f77a5c4684d1f674efb81418faa Mon Sep 17 00:00:00 2001 From: Frank Reininghaus Date: Thu, 11 Aug 2011 12:23:21 +0200 Subject: Emit KitemListSelectionManager's selectionChanged signal correctly This commit makes sure that the signal is emitted with the correct current and previous selection after a selection change, and that the signal is emitted exactly once in KItemListSelectionManager::itemsInserted and KItemListSelectionManager::itemsRemoved. --- src/tests/kitemlistselectionmanagertest.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/tests') diff --git a/src/tests/kitemlistselectionmanagertest.cpp b/src/tests/kitemlistselectionmanagertest.cpp index 4c45fd1b8..a79b9e6f3 100644 --- a/src/tests/kitemlistselectionmanagertest.cpp +++ b/src/tests/kitemlistselectionmanagertest.cpp @@ -212,6 +212,7 @@ void KItemListSelectionManagerTest::testItemsInserted() // Select items 10 to 12 m_selectionManager->setSelected(10, 3); QSet selectedItems = m_selectionManager->selectedItems(); + QCOMPARE(selectedItems.count(), 3); QVERIFY(selectedItems.contains(10)); QVERIFY(selectedItems.contains(11)); QVERIFY(selectedItems.contains(12)); @@ -219,6 +220,7 @@ void KItemListSelectionManagerTest::testItemsInserted() // Insert items 0 to 4 -> selection must be 15 to 17 m_selectionManager->itemsInserted(KItemRangeList() << KItemRange(0, 5)); selectedItems = m_selectionManager->selectedItems(); + QCOMPARE(selectedItems.count(), 3); QVERIFY(selectedItems.contains(15)); QVERIFY(selectedItems.contains(16)); QVERIFY(selectedItems.contains(17)); @@ -229,6 +231,7 @@ void KItemListSelectionManagerTest::testItemsInserted() KItemRange(16, 1) << KItemRange(17, 1)); selectedItems = m_selectionManager->selectedItems(); + QCOMPARE(selectedItems.count(), 3); QVERIFY(selectedItems.contains(16)); QVERIFY(selectedItems.contains(18)); QVERIFY(selectedItems.contains(20)); @@ -239,6 +242,7 @@ void KItemListSelectionManagerTest::testItemsRemoved() // Select items 10 to 15 m_selectionManager->setSelected(10, 6); QSet selectedItems = m_selectionManager->selectedItems(); + QCOMPARE(selectedItems.count(), 6); for (int i = 10; i <= 15; ++i) { QVERIFY(selectedItems.contains(i)); } @@ -246,6 +250,7 @@ void KItemListSelectionManagerTest::testItemsRemoved() // Remove items 0 to 4 -> selection must be 5 to 10 m_selectionManager->itemsRemoved(KItemRangeList() << KItemRange(0, 5)); selectedItems = m_selectionManager->selectedItems(); + QCOMPARE(selectedItems.count(), 6); for (int i = 5; i <= 10; ++i) { QVERIFY(selectedItems.contains(i)); } -- cgit v1.3