From 8ee2bfee960819d9f92e486d93f9d59ffe230bbb Mon Sep 17 00:00:00 2001
From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Thu, 7 May 2026 14:54:25 +0200
Subject: userfeedback: prevent dangling pointer access in SettingsDataSource

When the main window is closed m_mainWindow becomes dangling

Since data collection happens infrequently we don't need to cache the window, just find it on demand

BUG: 519876

SENTRY: DOLPHIN-VPX
---
 src/userfeedback/settingsdatasource.h | 3 ---
 1 file changed, 3 deletions(-)

(limited to 'src/userfeedback/settingsdatasource.h')

diff --git a/src/userfeedback/settingsdatasource.h b/src/userfeedback/settingsdatasource.h
index 9804c78a7..bd1cec015 100644
--- a/src/userfeedback/settingsdatasource.h
+++ b/src/userfeedback/settingsdatasource.h
@@ -19,9 +19,6 @@ public:
     QString name() const override;
     QString description() const override;
     QVariant data() override;
-
-private:
-    DolphinMainWindow *m_mainWindow = nullptr;
 };
 
 #endif // SETTINGSDATASOURCE_H
-- 
cgit v1.3