From aa229c536b84d120e0b74661db10044f64d5a5b2 Mon Sep 17 00:00:00 2001 From: Rafał Lichwała Date: Fri, 13 Feb 2026 17:10:05 +0100 Subject: dolphinview: indicate drops from Places view This commit corrects previous attempt of bug fix done in https://invent.kde.org/frameworks/kio/-/commit/71b2b38b0c4fc4c7820fd95b031413d854d8f8c6?merge_request_iid=2074 which incorrectly recognized drop action from Places View (based only on missing Qt::MoveAction which had side effects described in BUG 514697) This time DolphinView indicates that the given dropEvent comes from Places View so we must avoid potentially destructive Move-like plugins actions. This is done by setting proper KIO::DropJobFlags additional flag for KIO::drop(). CCBUG: 509231 CCBUG: 514697 --- src/views/draganddrophelper.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/views/draganddrophelper.cpp') diff --git a/src/views/draganddrophelper.cpp b/src/views/draganddrophelper.cpp index a98483a79..125e4e79c 100644 --- a/src/views/draganddrophelper.cpp +++ b/src/views/draganddrophelper.cpp @@ -34,7 +34,7 @@ bool DragAndDropHelper::urlListMatchesUrl(const QList &urls, const QUrl &d return *m_urlListMatchesUrlCache.insert(destUrl, destUrlMatches); } -KIO::DropJob *DragAndDropHelper::dropUrls(const QUrl &destUrl, QDropEvent *event, QWidget *window) +KIO::DropJob *DragAndDropHelper::dropUrls(const QUrl &destUrl, QDropEvent *event, QWidget *window, KIO::DropJobFlags dropjobFlags) { const QMimeData *mimeData = event->mimeData(); if (isArkDndMimeType(mimeData)) { @@ -53,7 +53,7 @@ KIO::DropJob *DragAndDropHelper::dropUrls(const QUrl &destUrl, QDropEvent *event } // Drop into a directory or a desktop-file - KIO::DropJob *job = KIO::drop(event, destUrl); + KIO::DropJob *job = KIO::drop(event, destUrl, dropjobFlags); KJobWidgets::setWindow(job, window); return job; } -- cgit v1.3