From 0eed595268d2b0478eee1d5bf5ed6bbd100cdf4c Mon Sep 17 00:00:00 2001 From: Jin Liu Date: Tue, 20 Feb 2024 20:09:26 +0800 Subject: Fix: can't drop into remote dir KFileItem::isDir() only works when it's created from listDir(), or from a local QUrl. For a remote QUrl, isDir always returns false, so we can't use that in supportsDropping(). As a workaround, now supportsDropping() always returns true in remote dirs -- we don't check if a remote dir is writable when dropping. --- src/views/draganddrophelper.h | 9 --------- 1 file changed, 9 deletions(-) (limited to 'src/views/draganddrophelper.h') diff --git a/src/views/draganddrophelper.h b/src/views/draganddrophelper.h index 0eee34a3d..73043febc 100644 --- a/src/views/draganddrophelper.h +++ b/src/views/draganddrophelper.h @@ -42,15 +42,6 @@ public: */ static KIO::DropJob *dropUrls(const QUrl &destUrl, QDropEvent *event, QWidget *window); - /** - * Checks if the destination supports dropping. - * - * @param destUrl URL of the item destination. - * @return True if the destination is a directory and is writable, or it's a desktop file. - * False otherwise. - */ - static bool supportsDropping(const QUrl &destUrl); - /** * Checks if the destination supports dropping. * -- cgit v1.3