From 9a9fbae988147c5651ce9e2bd2b412d32c1bf01d Mon Sep 17 00:00:00 2001 From: Anthony Fieroni Date: Tue, 29 Jan 2019 20:28:07 +0200 Subject: [versioncontrolobserver] Do not use static plugin objects Differential Revision: https://phabricator.kde.org/D17640 Signed-off-by: Anthony Fieroni --- .../versioncontrol/versioncontrolobserver.cpp | 31 +++++++++------------- 1 file changed, 13 insertions(+), 18 deletions(-) (limited to 'src/views/versioncontrol/versioncontrolobserver.cpp') diff --git a/src/views/versioncontrol/versioncontrolobserver.cpp b/src/views/versioncontrol/versioncontrolobserver.cpp index 7295a245a..d2e1ecd13 100644 --- a/src/views/versioncontrol/versioncontrolobserver.cpp +++ b/src/views/versioncontrol/versioncontrolobserver.cpp @@ -37,6 +37,7 @@ VersionControlObserver::VersionControlObserver(QObject* parent) : m_silentUpdate(false), m_model(nullptr), m_dirVerificationTimer(nullptr), + m_pluginsInitialized(false), m_plugin(nullptr), m_updateItemStatesThread(nullptr) { @@ -256,18 +257,9 @@ int VersionControlObserver::createItemStatesList(QMap plugins; - - if (!pluginsAvailable) { - // A searching for plugins has already been done, but no - // plugins are installed - return nullptr; - } - - if (plugins.isEmpty()) { + if (!m_pluginsInitialized) { // No searching for plugins has been done yet. Query the KServiceTypeTrader for // all fileview version control plugins and remember them in 'plugins'. const QStringList enabledPlugins = VersionControlSettings::enabledPlugins(); @@ -275,16 +267,19 @@ KVersionControlPlugin* VersionControlObserver::searchPlugin(const QUrl& director const KService::List pluginServices = KServiceTypeTrader::self()->query(QStringLiteral("FileViewVersionControlPlugin")); for (KService::List::ConstIterator it = pluginServices.constBegin(); it != pluginServices.constEnd(); ++it) { if (enabledPlugins.contains((*it)->name())) { - KVersionControlPlugin* plugin = (*it)->createInstance(); + KVersionControlPlugin* plugin = (*it)->createInstance(this); if (plugin) { - plugins.append(plugin); + m_plugins.append(plugin); } } } - if (plugins.isEmpty()) { - pluginsAvailable = false; - return nullptr; - } + m_pluginsInitialized = true; + } + + if (m_plugins.empty()) { + // A searching for plugins has already been done, but no + // plugins are installed + return nullptr; } // We use the number of upUrl() calls to find the best matching plugin @@ -294,7 +289,7 @@ KVersionControlPlugin* VersionControlObserver::searchPlugin(const QUrl& director // Verify whether the current directory contains revision information // like .svn, .git, ... - foreach (KVersionControlPlugin* plugin, plugins) { + foreach (KVersionControlPlugin* plugin, m_plugins) { const QString fileName = directory.path() + '/' + plugin->fileName(); if (QFile::exists(fileName)) { // The score of this plugin is 0 (best), so we can just return this plugin, -- cgit v1.3 From ec29cfff2017b40236edadcae50b8c1a1915d04e Mon Sep 17 00:00:00 2001 From: Anthony Fieroni Date: Sat, 2 Feb 2019 19:38:37 +0200 Subject: [versioncontrolobserver] Update working directory on tab activation Differential Revision: https://phabricator.kde.org/D18605 Signed-off-by: Anthony Fieroni --- src/views/dolphinview.cpp | 1 + src/views/versioncontrol/versioncontrolobserver.cpp | 21 +++++++++++++++++++++ src/views/versioncontrol/versioncontrolobserver.h | 5 +++++ 3 files changed, 27 insertions(+) (limited to 'src/views/versioncontrol/versioncontrolobserver.cpp') diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index 617c41ace..d64ae8622 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -182,6 +182,7 @@ DolphinView::DolphinView(const QUrl& url, QWidget* parent) : #endif m_versionControlObserver = new VersionControlObserver(this); + m_versionControlObserver->setView(this); m_versionControlObserver->setModel(m_model); connect(m_versionControlObserver, &VersionControlObserver::infoMessage, this, &DolphinView::infoMessage); connect(m_versionControlObserver, &VersionControlObserver::errorMessage, this, &DolphinView::errorMessage); diff --git a/src/views/versioncontrol/versioncontrolobserver.cpp b/src/views/versioncontrol/versioncontrolobserver.cpp index d2e1ecd13..09344bc14 100644 --- a/src/views/versioncontrol/versioncontrolobserver.cpp +++ b/src/views/versioncontrol/versioncontrolobserver.cpp @@ -21,6 +21,7 @@ #include "dolphin_versioncontrolsettings.h" #include "dolphindebug.h" +#include "views/dolphinview.h" #include "kitemviews/kfileitemmodel.h" #include "updateitemstatesthread.h" @@ -85,6 +86,26 @@ KFileItemModel* VersionControlObserver::model() const return m_model; } +void VersionControlObserver::setView(DolphinView* view) +{ + if (m_view) { + disconnect(m_view, &DolphinView::activated, + this, &VersionControlObserver::delayedDirectoryVerification); + } + + m_view = view; + + if (m_view) { + connect(m_view, &DolphinView::activated, + this, &VersionControlObserver::delayedDirectoryVerification); + } +} + +DolphinView* VersionControlObserver::view() const +{ + return m_view; +} + QList VersionControlObserver::actions(const KFileItemList& items) const { bool hasNullItems = false; diff --git a/src/views/versioncontrol/versioncontrolobserver.h b/src/views/versioncontrol/versioncontrolobserver.h index a42bbea63..08279dc86 100644 --- a/src/views/versioncontrol/versioncontrolobserver.h +++ b/src/views/versioncontrol/versioncontrolobserver.h @@ -37,6 +37,8 @@ class QAction; class QTimer; class UpdateItemStatesThread; +class DolphinView; + /** * @brief Observes all version control plugins. * @@ -55,6 +57,8 @@ public: void setModel(KFileItemModel* model); KFileItemModel* model() const; + void setView(DolphinView* view); + DolphinView* view() const; QList actions(const KFileItemList& items) const; @@ -139,6 +143,7 @@ private: bool m_silentUpdate; // if true, no messages will be send during the update // of version states + DolphinView* m_view; KFileItemModel* m_model; QTimer* m_dirVerificationTimer; -- cgit v1.3 From 83912a6de826d4a159fb7b4505f2869cc10b84bb Mon Sep 17 00:00:00 2001 From: Anthony Fieroni Date: Sat, 2 Feb 2019 19:48:09 +0200 Subject: Fix member initialization Signed-off-by: Anthony Fieroni --- src/views/versioncontrol/versioncontrolobserver.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'src/views/versioncontrol/versioncontrolobserver.cpp') diff --git a/src/views/versioncontrol/versioncontrolobserver.cpp b/src/views/versioncontrol/versioncontrolobserver.cpp index 09344bc14..cfbebc760 100644 --- a/src/views/versioncontrol/versioncontrolobserver.cpp +++ b/src/views/versioncontrol/versioncontrolobserver.cpp @@ -36,6 +36,7 @@ VersionControlObserver::VersionControlObserver(QObject* parent) : m_pendingItemStatesUpdate(false), m_versionedDirectory(false), m_silentUpdate(false), + m_view(nullptr), m_model(nullptr), m_dirVerificationTimer(nullptr), m_pluginsInitialized(false), -- cgit v1.3