From 10e4580b8d6000b80e0e0fb74ee4ea6192220174 Mon Sep 17 00:00:00 2001 From: Sebastian Englbrecht Date: Tue, 26 May 2026 20:46:22 +0200 Subject: MediaWidget, BottomBarContentsContainer: initialize members in constructor m_autoPlay is read in setUrl() before setAutoPlay() is called; m_contents is compared before resetContents() sets it. Both are undefined behavior. Add initializers to the member-initialization lists. Found with cppcheck --- src/panels/information/mediawidget.cpp | 2 ++ src/selectionmode/bottombarcontentscontainer.cpp | 1 + 2 files changed, 3 insertions(+) (limited to 'src') diff --git a/src/panels/information/mediawidget.cpp b/src/panels/information/mediawidget.cpp index 54a6d7fe7..b514ab0d3 100644 --- a/src/panels/information/mediawidget.cpp +++ b/src/panels/information/mediawidget.cpp @@ -153,6 +153,8 @@ MediaWidget::MediaWidget(QWidget *parent) , m_player(nullptr) , m_seekSlider(nullptr) , m_videoWidget(nullptr) + , m_autoPlay(false) + , m_isVideo(false) { } diff --git a/src/selectionmode/bottombarcontentscontainer.cpp b/src/selectionmode/bottombarcontentscontainer.cpp index 14dba3c36..8f8b34a19 100644 --- a/src/selectionmode/bottombarcontentscontainer.cpp +++ b/src/selectionmode/bottombarcontentscontainer.cpp @@ -29,6 +29,7 @@ using namespace SelectionMode; BottomBarContentsContainer::BottomBarContentsContainer(KActionCollection *actionCollection, QWidget *parent) : QWidget{parent} , m_actionCollection{actionCollection} + , m_contents{BottomBar::CopyContents} { // We will mostly interact with m_layout when changing the contents and not care about the other internal hierarchy. m_layout = new QHBoxLayout(this); -- cgit v1.3.1