From a91d1db06293f00382b88150a29594642d5217c8 Mon Sep 17 00:00:00 2001 From: Christoph Feck Date: Fri, 3 Jul 2020 22:53:42 +0200 Subject: GIT_SILENT Update Appstream for new release --- src/org.kde.dolphin.appdata.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/org.kde.dolphin.appdata.xml b/src/org.kde.dolphin.appdata.xml index 9f0651993..752ba825c 100644 --- a/src/org.kde.dolphin.appdata.xml +++ b/src/org.kde.dolphin.appdata.xml @@ -589,9 +589,9 @@ dolphin + - -- cgit v1.3 From 7a6956da997a39a22c1f08138674459c3c3aa32b Mon Sep 17 00:00:00 2001 From: Wolfgang Bauer Date: Tue, 30 Jun 2020 18:01:39 +0000 Subject: Write correct value for "Open in application" script execution setting KIO actually uses "alwaysAsk", "execute", and "open" as possible values. When reading the setting, map unknown values to "open" like KIO does. That also provides compatibility with older dolphin versions. BUG: 421294 FIXED-IN: 20.04.3 --- src/settings/general/confirmationssettingspage.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/settings/general/confirmationssettingspage.cpp b/src/settings/general/confirmationssettingspage.cpp index dd4d60f3b..6a72824d9 100644 --- a/src/settings/general/confirmationssettingspage.cpp +++ b/src/settings/general/confirmationssettingspage.cpp @@ -137,7 +137,7 @@ void ConfirmationsSettingsPage::applySettings() scriptExecutionGroup.writeEntry("behaviourOnLaunch", "alwaysAsk"); break; case ScriptExecution::Open: - scriptExecutionGroup.writeEntry("behaviourOnLaunch", "dontAsk"); + scriptExecutionGroup.writeEntry("behaviourOnLaunch", "open"); break; case ScriptExecution::Execute: scriptExecutionGroup.writeEntry("behaviourOnLaunch", "execute"); @@ -178,12 +178,12 @@ void ConfirmationsSettingsPage::loadSettings() const KConfigGroup scriptExecutionGroup(KSharedConfig::openConfig(QStringLiteral("kiorc")), "Executable scripts"); const QString value = scriptExecutionGroup.readEntry("behaviourOnLaunch", "alwaysAsk"); - if (value == QLatin1String("dontAsk")) { - m_confirmScriptExecution->setCurrentIndex(ScriptExecution::Open); + if (value == QLatin1String("alwaysAsk")) { + m_confirmScriptExecution->setCurrentIndex(ScriptExecution::AlwaysAsk); } else if (value == QLatin1String("execute")) { m_confirmScriptExecution->setCurrentIndex(ScriptExecution::Execute); - } else /* if (value == QLatin1String("alwaysAsk"))*/ { - m_confirmScriptExecution->setCurrentIndex(ScriptExecution::AlwaysAsk); + } else /* if (value == QLatin1String("open"))*/ { + m_confirmScriptExecution->setCurrentIndex(ScriptExecution::Open); } m_confirmClosingMultipleTabs->setChecked(GeneralSettings::confirmClosingMultipleTabs()); -- cgit v1.3