From 3779fbb7c9f1b22ebc9c61bfcdca42678463b164 Mon Sep 17 00:00:00 2001 From: Sebastian Englbrecht Date: Tue, 26 May 2026 21:04:40 +0200 Subject: KItemListController: remove redundant conditions in drag/release handlers newHoveredWidget is already guarded non-null by the enclosing if-block; !isAboveSelectionToggle is always true after the preceding early return. Remove both dead sub-expressions. --- src/kitemviews/kitemlistcontroller.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp index e87ed3c18..3250e570a 100644 --- a/src/kitemviews/kitemlistcontroller.cpp +++ b/src/kitemviews/kitemlistcontroller.cpp @@ -873,7 +873,7 @@ bool KItemListController::dragMoveEvent(QGraphicsSceneDragDropEvent *event, cons } else { m_autoActivationTimer->stop(); - if (newHoveredWidget && newHoveredWidget->isHovered()) { + if (newHoveredWidget->isHovered()) { newHoveredWidget->setHovered(false); Q_EMIT itemUnhovered(index); } @@ -1807,7 +1807,7 @@ bool KItemListController::onRelease(const QPointF &pos, const Qt::KeyboardModifi return true; } - if (!isAboveSelectionToggle && m_selectionTogglePressed) { + if (m_selectionTogglePressed) { m_selectionManager->setSelected(m_pressedIndex.value_or(-1), 1, KItemListSelectionManager::Toggle); m_selectionTogglePressed = false; return true; -- cgit v1.3.1