From 4d9193b85b9dacdc4cc46965596c1fc456fc273e Mon Sep 17 00:00:00 2001 From: Emmanuel Pescosta Date: Fri, 31 Jan 2014 20:56:57 +0100 Subject: Don't store the index of the file item in the VersionControlObserver::ItemState, get the index of the file item on demand instead. Fixes some "old"-index problems, esp. when you copy/move around files while the version control thread is still running. FIXED-IN: 4.13 REVIEW: 115410 --- src/views/versioncontrol/versioncontrolobserver.cpp | 3 +-- src/views/versioncontrol/versioncontrolobserver.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) (limited to 'src') diff --git a/src/views/versioncontrol/versioncontrolobserver.cpp b/src/views/versioncontrol/versioncontrolobserver.cpp index 888d93461..36345d986 100644 --- a/src/views/versioncontrol/versioncontrolobserver.cpp +++ b/src/views/versioncontrol/versioncontrolobserver.cpp @@ -206,7 +206,7 @@ void VersionControlObserver::slotThreadFinished() foreach (const ItemState& item, items) { QHash values; values.insert("version", QVariant(item.version)); - m_model->setData(item.index, values); + m_model->setData(m_model->index(item.item), values); } } @@ -265,7 +265,6 @@ int VersionControlObserver::createItemStatesList(QMapfileItem(index); itemState.version = KVersionControlPlugin2::UnversionedVersion; diff --git a/src/views/versioncontrol/versioncontrolobserver.h b/src/views/versioncontrol/versioncontrolobserver.h index 980374af9..d12d2cfe0 100644 --- a/src/views/versioncontrol/versioncontrolobserver.h +++ b/src/views/versioncontrol/versioncontrolobserver.h @@ -102,7 +102,6 @@ private slots: private: struct ItemState { - int index; KFileItem item; KVersionControlPlugin2::ItemVersion version; }; -- cgit v1.3