From 389c909affddb127b2e7af35422c21e55c0485b9 Mon Sep 17 00:00:00 2001 From: Emmanuel Pescosta Date: Sun, 6 Sep 2015 16:48:55 +0200 Subject: Remove the dummy widget, which assured that the dialog layout was not stretched vertically (vbox align top does the same), to make the uncheckable "Open archives as folder" checkbox checkable again. BUG: 349148 FIXED-IN: 15.08.1 REVIEW: 125077 --- src/settings/navigation/navigationsettingspage.cpp | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src') diff --git a/src/settings/navigation/navigationsettingspage.cpp b/src/settings/navigation/navigationsettingspage.cpp index f9c7a4dfc..e37a35d8e 100644 --- a/src/settings/navigation/navigationsettingspage.cpp +++ b/src/settings/navigation/navigationsettingspage.cpp @@ -43,11 +43,6 @@ NavigationSettingsPage::NavigationSettingsPage(QWidget* parent) : m_autoExpandFolders = new QCheckBox(i18nc("option:check", "Open folders during drag operations"), vBox); vBoxLayout->addWidget(m_autoExpandFolders); - // Add a dummy widget with no restriction regarding - // a vertical resizing. This assures that the dialog layout - // is not stretched vertically. - new QWidget(vBox); - topLayout->addWidget(vBox); loadSettings(); -- cgit v1.3 From 4143a69c05be6da8a91c8ba0db505a47b22ddc75 Mon Sep 17 00:00:00 2001 From: Emmanuel Pescosta Date: Sun, 6 Sep 2015 16:34:41 +0200 Subject: Rename dialog: Set focus to input text box on dialog show event. BUG: 351708 FIXED-IN: 15.08.1 REVIEW: 125078 --- src/views/renamedialog.cpp | 8 +++++++- src/views/renamedialog.h | 3 +++ 2 files changed, 10 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/views/renamedialog.cpp b/src/views/renamedialog.cpp index be9e34c4a..60b7b16c1 100644 --- a/src/views/renamedialog.cpp +++ b/src/views/renamedialog.cpp @@ -108,7 +108,6 @@ RenameDialog::RenameDialog(QWidget *parent, const KFileItemList& items) : m_lineEdit->setText(m_newName); m_lineEdit->setSelection(0, selectionLength); - m_lineEdit->setFocus(); topLayout->addWidget(editLabel); topLayout->addWidget(m_lineEdit); @@ -197,6 +196,13 @@ void RenameDialog::slotTextChanged(const QString& newName) m_okButton->setEnabled(enable); } +void RenameDialog::showEvent(QShowEvent* event) +{ + m_lineEdit->setFocus(); + + QDialog::showEvent(event); +} + void RenameDialog::renameItems() { // Iterate through all items and rename them... diff --git a/src/views/renamedialog.h b/src/views/renamedialog.h index a1953e8b3..3964c0a5c 100644 --- a/src/views/renamedialog.h +++ b/src/views/renamedialog.h @@ -45,6 +45,9 @@ private slots: void slotAccepted(); void slotTextChanged(const QString& newName); +protected: + void showEvent(QShowEvent* event) override; + private: void renameItems(); void renameItem(const KFileItem &item, const QString& newName); -- cgit v1.3 From 51f75371c43b5c740703a80aa584a9bd88af16c8 Mon Sep 17 00:00:00 2001 From: andreas kainz Date: Thu, 10 Sep 2015 20:59:00 +0200 Subject: Change Dolphin Preferences Sidebar Icons --- src/settings/dolphinsettingsdialog.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/settings/dolphinsettingsdialog.cpp b/src/settings/dolphinsettingsdialog.cpp index 820fc0e68..4f9a20de4 100644 --- a/src/settings/dolphinsettingsdialog.cpp +++ b/src/settings/dolphinsettingsdialog.cpp @@ -74,28 +74,28 @@ DolphinSettingsDialog::DolphinSettingsDialog(const QUrl& url, QWidget* parent) : NavigationSettingsPage* navigationSettingsPage = new NavigationSettingsPage(this); KPageWidgetItem* navigationSettingsFrame = addPage(navigationSettingsPage, i18nc("@title:group", "Navigation")); - navigationSettingsFrame->setIcon(QIcon::fromTheme("input-mouse")); + navigationSettingsFrame->setIcon(QIcon::fromTheme("edit-select")); connect(navigationSettingsPage, &NavigationSettingsPage::changed, this, &DolphinSettingsDialog::enableApply); // Services ServicesSettingsPage* servicesSettingsPage = new ServicesSettingsPage(this); KPageWidgetItem* servicesSettingsFrame = addPage(servicesSettingsPage, i18nc("@title:group", "Services")); - servicesSettingsFrame->setIcon(QIcon::fromTheme("services")); + servicesSettingsFrame->setIcon(QIcon::fromTheme("flag")); connect(servicesSettingsPage, &ServicesSettingsPage::changed, this, &DolphinSettingsDialog::enableApply); // Trash TrashSettingsPage* trashSettingsPage = new TrashSettingsPage(this); KPageWidgetItem* trashSettingsFrame = addPage(trashSettingsPage, i18nc("@title:group", "Trash")); - trashSettingsFrame->setIcon(QIcon::fromTheme("user-trash")); + trashSettingsFrame->setIcon(QIcon::fromTheme("trash-empty")); connect(trashSettingsPage, &TrashSettingsPage::changed, this, &DolphinSettingsDialog::enableApply); // General GeneralSettingsPage* generalSettingsPage = new GeneralSettingsPage(url, this); KPageWidgetItem* generalSettingsFrame = addPage(generalSettingsPage, i18nc("@title:group General settings", "General")); - generalSettingsFrame->setIcon(QIcon::fromTheme("system-run")); + generalSettingsFrame->setIcon(QIcon::fromTheme("view-preview")); connect(generalSettingsPage, &GeneralSettingsPage::changed, this, &DolphinSettingsDialog::enableApply); m_pages.append(startupSettingsPage); -- cgit v1.3