From cc806587766d09f916de712b0b5e248ba0c5383c Mon Sep 17 00:00:00 2001 From: Méven Car Date: Sat, 13 Jun 2026 13:50:08 +0000 Subject: setfoldericon: fix leak of the submenu ButtonsWithSubMenuWidgetAction owned the QMenu (no parent, setMenu does not take ownership) but had no destructor, so every folder context menu leaked one QMenu and its overflow actions. Add a destructor that deletes it. --- src/itemactions/setfoldericonitemaction.cpp | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src') diff --git a/src/itemactions/setfoldericonitemaction.cpp b/src/itemactions/setfoldericonitemaction.cpp index feb6adc2b..a90864d86 100644 --- a/src/itemactions/setfoldericonitemaction.cpp +++ b/src/itemactions/setfoldericonitemaction.cpp @@ -78,6 +78,13 @@ public: { } + ~ButtonsWithSubMenuWidgetAction() override + { + // m_subMenu has no parent (QPushButton::setMenu does not take ownership), + // so this action is its sole owner. + delete m_subMenu; + } + void setActions(const QList &actions) { m_actions = actions; -- cgit v1.3.1