diff options
| author | Friedrich W. H. Kossebau <[email protected]> | 2026-01-09 16:16:48 +0100 |
|---|---|---|
| committer | Méven Car <[email protected]> | 2026-01-10 15:14:26 +0000 |
| commit | 5fff1e414a060c0619a97ad8d3f5665e3f5a4878 (patch) | |
| tree | 5ed5b7560ba22bf690f72c399d31490493b87ea3 /src/dolphinnavigatorswidgetaction.cpp | |
| parent | 3cea7599a110479071919e92d6c91959020c33df (diff) | |
Use Q_ASSERT instead of Q_CHECK_PTR for plain checks of pointer value
Q_CHECK_PTR (other than the name suggests) is intended only to check the
success of memory allocations.
Using it for any pointers instead can be misleading due to the
"Out of memory" log printed in case of hits.
Diffstat (limited to 'src/dolphinnavigatorswidgetaction.cpp')
| -rw-r--r-- | src/dolphinnavigatorswidgetaction.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/dolphinnavigatorswidgetaction.cpp b/src/dolphinnavigatorswidgetaction.cpp index 93d6859b1..c44b7e796 100644 --- a/src/dolphinnavigatorswidgetaction.cpp +++ b/src/dolphinnavigatorswidgetaction.cpp @@ -326,8 +326,8 @@ DolphinNavigatorsWidgetAction::ViewGeometriesHelper::ViewGeometriesHelper(QWidge : m_navigatorsWidget{navigatorsWidget} , m_navigatorsWidgetAction{navigatorsWidgetAction} { - Q_CHECK_PTR(navigatorsWidget); - Q_CHECK_PTR(navigatorsWidgetAction); + Q_ASSERT(navigatorsWidget); + Q_ASSERT(navigatorsWidgetAction); } bool DolphinNavigatorsWidgetAction::ViewGeometriesHelper::eventFilter(QObject *watched, QEvent *event) @@ -351,7 +351,7 @@ bool DolphinNavigatorsWidgetAction::ViewGeometriesHelper::eventFilter(QObject *w void DolphinNavigatorsWidgetAction::ViewGeometriesHelper::setViewContainers(QWidget *primaryViewContainer, QWidget *secondaryViewContainer) { - Q_CHECK_PTR(primaryViewContainer); + Q_ASSERT(primaryViewContainer); if (m_primaryViewContainer) { m_primaryViewContainer->removeEventFilter(this); } |
