diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/CMakeLists.txt | 4 | ||||
| -rw-r--r-- | src/dolphinmainwindow.cpp | 2 | ||||
| -rw-r--r-- | src/kitemviews/private/kitemlistsmoothscroller.cpp | 24 | ||||
| -rw-r--r-- | src/panels/places/placesitem.cpp | 2 | ||||
| -rw-r--r-- | src/tests/kitemlistcontrollertest.cpp | 10 | ||||
| -rw-r--r-- | src/tests/kitemlistselectionmanagertest.cpp | 12 | ||||
| -rw-r--r-- | src/tests/kitemrangetest.cpp | 4 | ||||
| -rw-r--r-- | src/views/dolphinview.cpp | 2 | ||||
| -rw-r--r-- | src/views/versioncontrol/kversioncontrolplugin.h | 4 |
9 files changed, 37 insertions, 27 deletions
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 2a5e5a688..e0f91deed 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -29,7 +29,6 @@ generate_export_header(dolphinvcs BASE_NAME dolphin) target_link_libraries( dolphinvcs PUBLIC Qt5::Widgets - KF5::KIOCore ) set_target_properties(dolphinvcs PROPERTIES @@ -143,10 +142,11 @@ target_link_libraries( KF5::KIOWidgets KF5::KIOFileWidgets KF5::Completion - KF5::TextEditor + KF5::TextWidgets KF5::WindowSystem KF5::ConfigCore KF5::NewStuff + KF5::Parts ) if(HAVE_BALOO) diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index f7a761307..5a731512b 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -1335,7 +1335,7 @@ void DolphinMainWindow::createControlButton() Q_ASSERT(!m_controlButton); m_controlButton = new QToolButton(this); - m_controlButton->setIcon(QIcon::fromTheme("applications-system")); + m_controlButton->setIcon(QIcon::fromTheme("application-menu")); m_controlButton->setText(i18nc("@action", "Control")); m_controlButton->setPopupMode(QToolButton::InstantPopup); m_controlButton->setToolButtonStyle(toolBar()->toolButtonStyle()); diff --git a/src/kitemviews/private/kitemlistsmoothscroller.cpp b/src/kitemviews/private/kitemlistsmoothscroller.cpp index e70f47890..2bd467aa5 100644 --- a/src/kitemviews/private/kitemlistsmoothscroller.cpp +++ b/src/kitemviews/private/kitemlistsmoothscroller.cpp @@ -172,7 +172,7 @@ bool KItemListSmoothScroller::eventFilter(QObject* obj, QEvent* event) case QEvent::Wheel: handleWheelEvent(static_cast<QWheelEvent*>(event)); - break; + return true; // eat event so that QScrollBar does not scroll one step more by itself default: break; @@ -192,15 +192,25 @@ void KItemListSmoothScroller::slotAnimationStateChanged(QAbstractAnimation::Stat void KItemListSmoothScroller::handleWheelEvent(QWheelEvent* event) { - const int numDegrees = event->delta() / 8; - const int numSteps = numDegrees / 15; - const bool previous = m_smoothScrolling; m_smoothScrolling = true; - const int value = m_scrollBar->value(); - const int pageStep = m_scrollBar->pageStep(); - m_scrollBar->setValue(value - numSteps * pageStep); + int numPixels; + if (!event->pixelDelta().isNull()) { + numPixels = event->pixelDelta().y(); + } else { + const int numDegrees = event->angleDelta().y() / 8; + const int numSteps = numDegrees / 15; + numPixels = numSteps * m_scrollBar->pageStep() / 4; + } + int value = m_scrollBar->value(); + if (event->modifiers().testFlag(Qt::ShiftModifier)) { + const int scrollingDirection = numPixels > 0 ? 1 : -1; + value -= m_scrollBar->pageStep() * scrollingDirection; + } else { + value -= numPixels; + } + m_scrollBar->setValue(value); m_smoothScrolling = previous; diff --git a/src/panels/places/placesitem.cpp b/src/panels/places/placesitem.cpp index fad8c7fa5..2a9c88e4e 100644 --- a/src/panels/places/placesitem.cpp +++ b/src/panels/places/placesitem.cpp @@ -144,7 +144,7 @@ void PlacesItem::setBookmark(const KBookmark& bookmark) if (icon().isEmpty()) { switch (type) { case RecentlySavedType: setIcon("chronometer"); break; - case SearchForType: setIcon("nepomuk"); break; + case SearchForType: setIcon("system-search"); break; case PlacesType: default: setIcon("folder"); } diff --git a/src/tests/kitemlistcontrollertest.cpp b/src/tests/kitemlistcontrollertest.cpp index e34731fa4..e170e7b5b 100644 --- a/src/tests/kitemlistcontrollertest.cpp +++ b/src/tests/kitemlistcontrollertest.cpp @@ -71,10 +71,10 @@ private: bool m_activateItemOnSingleClick; }; -Q_DECLARE_METATYPE(KFileItemListView::ItemLayout); -Q_DECLARE_METATYPE(Qt::Orientation); -Q_DECLARE_METATYPE(KItemListController::SelectionBehavior); -Q_DECLARE_METATYPE(KItemSet); +Q_DECLARE_METATYPE(KFileItemListView::ItemLayout) +Q_DECLARE_METATYPE(Qt::Orientation) +Q_DECLARE_METATYPE(KItemListController::SelectionBehavior) +Q_DECLARE_METATYPE(KItemSet) class KItemListControllerTest : public QObject { @@ -209,7 +209,7 @@ struct ViewState { // We have to define a typedef for the pair in order to make the test compile. typedef QPair<KeyPress, ViewState> keyPressViewStatePair; -Q_DECLARE_METATYPE(QList<keyPressViewStatePair>); +Q_DECLARE_METATYPE(QList<keyPressViewStatePair>) /** * This function provides the data for the actual test function diff --git a/src/tests/kitemlistselectionmanagertest.cpp b/src/tests/kitemlistselectionmanagertest.cpp index 7cf60df42..b183de302 100644 --- a/src/tests/kitemlistselectionmanagertest.cpp +++ b/src/tests/kitemlistselectionmanagertest.cpp @@ -322,12 +322,12 @@ namespace { }; } -Q_DECLARE_METATYPE(KItemSet); -Q_DECLARE_METATYPE(ChangeType); -Q_DECLARE_METATYPE(KItemRange); -Q_DECLARE_METATYPE(KItemRangeList); -Q_DECLARE_METATYPE(KItemListSelectionManager::SelectionMode); -Q_DECLARE_METATYPE(QList<int>); +Q_DECLARE_METATYPE(KItemSet) +Q_DECLARE_METATYPE(ChangeType) +Q_DECLARE_METATYPE(KItemRange) +Q_DECLARE_METATYPE(KItemRangeList) +Q_DECLARE_METATYPE(KItemListSelectionManager::SelectionMode) +Q_DECLARE_METATYPE(QList<int>) /** * The following function provides a generic way to test the selection functionality. diff --git a/src/tests/kitemrangetest.cpp b/src/tests/kitemrangetest.cpp index ce7b48012..5e4ea653f 100644 --- a/src/tests/kitemrangetest.cpp +++ b/src/tests/kitemrangetest.cpp @@ -22,8 +22,8 @@ #include <QTest> #include <QVector> -Q_DECLARE_METATYPE(QVector<int>); -Q_DECLARE_METATYPE(KItemRangeList); +Q_DECLARE_METATYPE(QVector<int>) +Q_DECLARE_METATYPE(KItemRangeList) class KItemRangeTest : public QObject { diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index 07b40dceb..5023859df 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -77,7 +77,7 @@ namespace { const int MaxModeEnum = DolphinView::CompactView; -}; +} DolphinView::DolphinView(const QUrl& url, QWidget* parent) : QWidget(parent), diff --git a/src/views/versioncontrol/kversioncontrolplugin.h b/src/views/versioncontrol/kversioncontrolplugin.h index e5a267848..85835e062 100644 --- a/src/views/versioncontrol/kversioncontrolplugin.h +++ b/src/views/versioncontrol/kversioncontrolplugin.h @@ -23,9 +23,9 @@ #include <dolphin_export.h> #include <QObject> -#include <KFileItem> #include <QAction> - +class KFileItemList; +class KFileItem; /** * @brief Base class for version control plugins. * |
