| Age | Commit message (Collapse) | Author |
|
QUrl &url, bool delayedMimeTypes = false);
|
|
The URL needs to be constructed from 'QUrl::fromLocalFile()' instead of
a QString so that the scheme is set properly.
REVIEW: 121409
BUG: 341678
|
|
Trailing slashes should be removed before calling QUrl::filename(),
else it will return an empty string.
BUG: 341411
REVIEW: 121293
|
|
|
|
|
|
|
|
Using KDE_VERSION_STRING as the Dolphin version was convenient, but it
does not make sense anymore because it is fixed at 4.14.3 now.
REVIEW: 121195
|
|
|
|
RR 121078 fixed exports, but did not include the necessary
generate_export_header in the CMakeLists.txt.
Please, if you are testing for Windows, ensure you also test your build
in Linux (and with a clean build dir). The fact that kde-baseapps for
KF5 is still unreleased does not mean it should not be buildable.
CCMAIL: [email protected]
|
|
REVIEW: 121078
|
|
see RR 121141 for details
|
|
|
|
7ed7cd97d084364d8ee61b35f5ffa3630c5277a4
CCMAIL: [email protected]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Commit 1938ad54d4ee640f04d24bad3b690095bc9b8668 replaced delete by
deleteLater(). However, the latter cannot be used safely with null
pointers. This commit adds a safety check in order to make sure that
we do not get a crash.
Thanks to Christoph Feck for pointing out this issue.
|
|
This patch should make a crash with a backtrace as provided in the bug
report impossible. I'm not sure if this would really prevent the crash
- it looks like the actual cause of the problem could be in
QGraphicsView or anywhere else, but it's hard to tell because the bug
was reported just once and does not seem reproducible. But I'm pretty
sure that this change doesn't make anything worse.
BUG: 334785
REVIEW: 121087
|
|
Checking whether the input contains '*', '?' or '[' alone will
not do since there can be files with '[' in their name.
REVIEW: 120986
BUG: 340470
FIXED-IN: 14.12
|
|
|
|
|
|
|
|
This commit is analogous to 5cf8941ac789e47da70fe466033f45df9af1a3fa,
but the problem existed since the frameworks port was started and was
not obvious because the QString -> KUrl/QUrl port was done implicitly
when calling KIO::rename(oldPath, newPath, KIO::HideProgressInfo).
REVIEW: 120941
|
|
These were caused by 86e31084ced8ba4875a6128f91ec2ca3d6df7a31 - note
that the correct replacement for KUrl(fileName) is
QUrl::fromLocalFile(fileName), and that calling the const function
urlA.adjusted(QUrl::RemoveFilename) only has an effect if the return
value is taken.
|
|
|
|
take into accound the whole list, not just the first shortcut
|
|
|
|
fixes being unable to access eg. removable drives
|
|
|
|
dolphin accordingly.
|
|
|
|
Since 6a6cf1ab328e7600f0c2b375e43a1e3bd236a5a7, it depends on rootItem()
which is not available until the dirlister emits it.
|
|
Remove KonqOperations::doPaste.
|
|
This commit enables KRun's script/desktop file execution prompts,
which is shown when the user launches an executable script or a
desktop file. This is done so as to prevent the user from accidentaly
executing programs. A checkbox to enable or disable the prompts is also
being added to the preferences window
REVIEW: 120171
BUG: 275405
|
|
|
|
BUG: 339882
FIXED-IN: 4.14.3
REVIEW: 120776
|
|
|
|
|
|
looks like writableLocation() already includes the app name
|
|
Conflicts:
dolphin/src/panels/terminal/terminalpanel.cpp
dolphin/src/panels/terminal/terminalpanel.h
|
|
|
|
The previous solution could cause problems if the user navigates to a
different URL in one view, and then activates another split view very
quickly: the new active view might be switched to the same URL as the
first view, which is unwanted.
To fix this problem, we record a history of "cd" commands that Dolphin
sends to the Terminal Panel in a queue. If a currentDirectoryChanged
signal is received, and the new terminal directory is "dir", this patch
does the following:
1. If the queue is empty, change the view URL to "dir".
2. Otherwise, take the queue's head, and check if it is equal to
"dir". If that is the case, ignore the signal and return.
3. Go back to step 1.
This ensures that every currentDirectoryChange signal that is caused by
a "cd" that was sent from Dolphin to the terminal is ignored.
BUG: 339009
BUG: 314038
REVIEW: 120768
|
|
Patch from ROSA Linux.
BUG: 337107
BUG: 337033
BUG: 334924
CCBUG: 339882
REVIEW: 120745
FIXED-IN: 4.14.3
|
|
|
|
This fixes the problem that the view URL may be reset to the Home URL
when opening the Terminal Panel while browsing a remote URL. Moreover,
it fixes crashes that can occur when the signal is received during the
shell setup if the DolphinMainWindow does not have a valid
m_activeViewContainer yet.
BUG: 339502
BUG: 340233
REVIEW: 120726
FIXED-IN: 4.14.3
|
|
fixes the determination of the closest item for me.
|
|
|