┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-17Separate Delete/Move To Trash menu items in context menuNate Graham
Right now these actions are in a visual group with "Rename" and "Add to Places" which is silly as those actions have no logical connection whatsoever to deletion. This commits moves those items into the section above, putting them in a more logical place and leaving the Delete/Move To Trash item in its own section. BUG: 429256 FIXED-IN: 21.04
2020-11-17Add missing kconfig_version.h includeElvis Angelaccio
This should have been part of edced8460b.
2020-11-17Correct indentation and whitespace in prior commitNate Graham
2020-11-17Allow folder creation on desktop via F10 shortcutDomenico Panella
2020-11-16Merge branch 'release/20.12'Nate Graham
2020-11-16PlacesPanel: tooltip, use toLocalFile instead of pathMéven Car
To avoid Windows compatiblity issues.
2020-11-15Merge branch 'release/20.12'Elvis Angelaccio
2020-11-15Increment kpartgui versionFelix Ernst
The defaults changed in 37327c9b0aae112c5890703cba1f0157043007e0 but I forgot to also bump the kpartgui version so this commit rectifies that.
2020-11-14Context Menu: Only add paste action to foldersMéven Car
Either the viewport, or the selected folder is used as destination. The paste action is only added when enabled.
2020-11-14GIT_SILENT made messages (after extraction)l10n daemon script
2020-11-13Merge branch 'release/20.12'Felix Ernst
2020-11-13Fix navigator alignment for right-to-left localizationsFelix Ernst
2020-11-12Merge branch 'release/20.12'Nate Graham
2020-11-12Fix qrc iconAlexander Lohnau
Apparently the icon was not null, because the mimetype was known. But there was no icon associated with it and we got an icon which is not null, but has a null pixmap.
2020-11-12Set empty value for packagekit transaction flagsAlexander Lohnau
Otherwise the value would be Trusted Only, which will forbid installing local packages
2020-11-12Set empty value for packagekit transaction flagsAlexander Lohnau
Otherwise the value would be Trusted Only, which will forbid installing local packages
2020-11-10Merge branch 'release/20.12'Nate Graham
2020-11-10Places panel: show a tooltip after 500 msMéven Car
BUG: 426455 FIXED-IN: 20.12
2020-11-10Merge branch 'release/20.12'Elvis Angelaccio
2020-11-09Adress the third round of Angelaccio's review commentsFelix Ernst
Additionally remove some redundant code concerning UrlNavigator visuals.
2020-11-09Adress most of the second round of Angelaccio's review commentsFelix Ernst
This commit applies most suggestions which were made on the MR. Most notably the DolphinUrlNavigator class is split up which leads to the creation of a DolphinUrlNavigatorsController class. Additionally some minor coding style and const correctness changes are included. The error value of cached integers is changed from -1 to INT_MIN because situations could come up in which -1 would be a valid value.
2020-11-09Apply Méven Car's suggestionsFelix Ernst
2020-11-09Fix a crash and extract unrelated changesFelix Ernst
The secondary UrlNavigator is now created when and only when: - split view mode is activated for the active tab OR - switching to a tab that has split view already enabled. This fixes a crash that occurs when the setting to always start in split view mode is enabled. An animation for activating split view is also removed from this and moved into a separate MR. Another unrelated name change left over from a previous commit (viewContainers() -> activeViewContainers()) is dropped.
2020-11-09Make UrlNavigators in the toolbar the only optionFelix Ernst
The UrlNavigators will be automatically added to the toolbar. The Sort By action is removed from the default toolbar to make space. Remove all options to have UrlNavigators outside the toolbar and remove those code paths. Make it so the new NavigatorsWidgetAction contains two UrlNavigators when in split view mode. Spacing was also added to align these UrlNavigators with the ViewContainers when enough space is available. Force the toolbar to be either at the top or bottom of the window. Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this in KUrlNavigator in the future. This commit also contains a changes which should be moved to a separate merge requests before this gets merged: - Add an expansion animation when split view is enabled by the user
2020-11-09Add the UrlNavigator to the toolbar automatically if neededFelix Ernst
This commit adds the DolphinUrlNavigatorWidgetAction::addToToolbarAndSave() method which changes the users toolbar configuration to contain an Url Navigator. This way the user doesn't need to do anything manually. Aside from that a bunch of minor fixes like renaming and reordering
2020-11-09Adress the first round of Angelaccio's review commentsFelix Ernst
- Split the viewContainers(bool includeInActive) into two methods without parameters - Prevent users from accidently hiding all Url Navigators by preventing the dangerous action and then displaying a helpful message instead Unrelated to review comments: Remove a useless line of code
2020-11-09trailing whitespacesFelix Ernst
2020-11-09Add an option to use an UrlNavigator in the toolbar insteadFelix Ernst
This commit adds a locationInToolbar KToggleAction to switch between using a location bar to navigate or using a new custom QWidgetAction in the toolbar. A big portion of this MR is refactoring because until now the UrlNavigator was tightly intertwined with the DolphinViewContainer. With this MR an UrlNavigator for controlling a View can be freely connected or disconnected with a single method call. A DolphinUrlNavigator class is created in the process which contains all Dolphin-specific UrlNavigator code which did previously reside in the DolphinViewContainer class. Other application parts that belong to UrlNavigator-management are also moved here.
2020-11-09PlacesItemListWidget: Use Solid to check if device is a network shareMéven Car
2020-11-08Merge branch 'release/20.12'Elvis Angelaccio
2020-11-08Add missing referenceElvis Angelaccio
2020-11-08Iterate over a const copy list of containersIsmael Asensio
This effectively reverts the mutable iterations approach on 2448f88c5f42d7a2040fcf3bcd3c5f2a2f62cd03, and fix crashes and ghost items when using the filter bar BUG: 428374
2020-11-08GIT_SILENT Upgrade release service version to 21.03.70.Albert Astals Cid
2020-11-08GIT_SILENT Upgrade release service version to 20.11.80.Albert Astals Cid
2020-11-07Do not expose KCMs in application launchersAlexander Lohnau
We still need to build them, because they are also loaded on konqueror.
2020-11-07KDirectoryContentsCounter: fix support of symlinks dirMéven Car
BUG: 428712 FIXED-IN: 20.12
2020-11-05Add support for KUserFeedbackElvis Angelaccio
This commit introduces KUserFeedback in dolphin with some basic data sources and with a settings page to configure the telemetry values. There are also a couple custom data sources as proof of concept: a bunch of settings and the count of available network shares as listed by Solid. The settings page is shown only if the user feedback framework is enabled, but currently in Plasma we don't have a global kill switch to disable it. At the moment we never show an encouragement message. We need to connect to the `Provider::showEncouragementMessage()` signal, but first we should agree to a common way to show a non-annoying message to the users.
2020-11-05Details view: display empty text instead of unknown for sizeless dirsMéven Car
BUG: 420037 BUG: 420040 FIXED-IN: 20.12
2020-11-04Move m_textInfo to fix ctor warning, and document why it's protected.Chris Holland
2020-11-04Use QDeadlineTimer instead of QDateTime.Chris Holland
Use early returns instead of deeply nested if/else.
2020-11-04Cleanup importsChris Holland
2020-11-04Remove wip debuggingChris Holland
2020-11-04Fix freeSpaceInfo cache not being reset.Chris Holland
2020-11-04Use KDE GitLab url instead of the GitHub mirrorChris Holland
2020-11-04Cleanup unused colors. Use const. Use KColorScheme danger.Chris Holland
The draw code is more like the last state of D21312 now.
2020-11-04Refactor capacity by to use async KIO FreeSpaceJob.Chris Holland
Based on this kio filepicker patch: https://github.com/KDE/kio/commit/933887dc334f3498505af7a86d25db7faae91019
2020-11-04Only show capacity bar for devices (has a udi).Chris Holland
2020-11-04Only check if place url is mount point once during polish event.Chris Holland
The capacity bars will no longer update when capacity changes. It only checks the size on init. Updating during polish event is only a temporarily solution just to draft code flow for seperating logic from painting. Eventually this logic update should be in a worker thread detached from blocking the rendering thread that blocks launching the dolphin window.
2020-11-04Draw 2 Rectangles below mount points to represent a disk capacity barChris Holland
Draws overtop text that's goes below the baseline like a 'j'. It's fairly difficult to add extra space below the text as the places view is a "details" view, so the text is vertically centered in the widget's "row" as you'd desire it to in the main file view. We can make the widget 8px taller, adding 4px above and below so there's adequate room for the capacitybar, but that wastes 4px for each mount point. Ideally we'd use the "compact" view, which displays the text/size in a column beside the icon. However the compact view was not designed to take up the entire width of the viewport. It's also designed to overflow with a horizontal scrollbar.
2020-11-04Improve padding in the Places ViewEzike Ebuka