┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-18Add role for file creation time.Tobias C. Berner
Summary: At least on FreeBSD UFS and ZFS support birthtimes of files. Reviewers: #freebsd, #dolphin Subscribers: #konqueror Differential Revision: https://phabricator.kde.org/D6243
2017-07-17GIT_SILENT Upgrade KDE Applications version to 17.07.80.Albert Astals Cid
2017-07-17GIT_SILENT Upgrade KDE Applications version to 17.11.70.Albert Astals Cid
2017-07-15Merge remote-tracking branch 'origin/Applications/17.04'Luigi Toscano
2017-07-13Fix knewstuff popup menu position on waylandElvis Angelaccio
On Wayland we need to pass a parent to popup menus. See https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Popup_Menus So we use the new setParentWidget() method from KNewStuff (introduced in Frameworks 5.37).
2017-07-13Add missing emit keywordsElvis Angelaccio
GIT_SILENT
2017-07-10GIT_SILENT Upgrade KDE Applications version to 17.04.3.Albert Astals Cid
2017-06-27[Places Panel] Disallow editing devicesKai Uwe Broulik
I introduced this bug when I changed the layout of the menu. While it would be nice if one could edit devices, it is currently not possible and would require significant re-engineering effort in Solid. While the "Edit" menu works just fine, changes are not persisted. Reviewed-By: emmanuelp Differential Revision: https://phabricator.kde.org/D6294
2017-06-20Support "Deletion Time" role in TrashKai Uwe Broulik
This allows to sort by and show (both as additional data in icon view and column in column view) deletion date of files in Trash. CHANGELOG: It is now possible to view and sort by "Deletion Time" in Trash BUG: 153492 FIXED-IN: 17.08.0 Differential Revision: https://phabricator.kde.org/D6269
2017-06-11Merge branch 'Applications/17.04'Elvis Angelaccio
* Applications/17.04: Change in "Open in new tab" feature in Dolphin Ignore drops-onto-items from invalid places items Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"
2017-06-11Change in "Open in new tab" feature in DolphinEmirald Mateli
Summary: This patch proposes a change to the "open in new tab" feature. The "open in new tab" feature will try to open selected items (files or folders) in a new tab, however, if there are no valid items to be opened in a new tab then nothing will happen, making it look like a bug. This patch adds the functionality that when there are no valid items(files or folders) to be opened in a new tab the current folder will be opened. Test Plan: 1. Select a file(pdf, text, image etc) in Dolphin 2. Click on the "Open in new tab" toolbar button Expected: since the file is not a valid target to open in a new tab, the current directory should be opened (as is the case where selection is empty) Actual: Nothing happens after the button is pressed Reviewed By: #dolphin, elvisangelaccio Differential Revision: https://phabricator.kde.org/D6182
2017-06-11Ignore drops-onto-items from invalid places itemsElvis Angelaccio
If the QMimeData object created by PlacesItemModel doesn't have any url set (e.g. when dragging unmounted devices), it is detected by the resulting DropJob as "drop raw data" because the mimeData has one format set (the internalMimeType() used for dragging between places items). This results in a crash because the DropJob schedules a PasteJob, but in the meantime the QDrag from Dolphin ends and deletes the mimeData object that was passed to the paste job. The fix is to prevent the DropJob in the first place. We can introduce a new internal mimetype that we use to blacklist drops-onto-items (while still allowing drops-between-items). This way PlacesItemModel can set the blacklist flag if the mimeData is being created without urls. BUG: 373005 FIXED-IN: 17.04.3 Test Plan: Drag and drop an unmounted device to another place item or the DolphinView, doesn't crash anymore. Dropping the unmounted device between two places item still works. Differential Revision: https://phabricator.kde.org/D5535
2017-06-06Drop unnecessary methodElvis Angelaccio
2017-06-05GIT_SILENT Upgrade KDE Applications version to 17.04.2.Albert Astals Cid
2017-05-31Revert "Increase smooth scrolling animation duration from 100 to 300 ms and ↵Elvis Angelaccio
set easing curve to InOutQuart" This reverts commit 58c5eae1953bbdcf6d4150b21cb7ffdad07a5257. Reasons against this change: 1. Scroll is now too fast with devices such as touchpads or trackpoints. 2. Scroll behavior is now inconsistent between Dolphin and other applications (e.g. the Plasma file dialog). Breeze's default animation duration is 100 ms. 3. Many people complained and this feature is currently not configurable. We should introduce a QStyle::SH_Widget_Animation_Duration hint that would allow us to not hardcode durations in Dolphin (i.e. respect whatever duration the users set in their QStyle). Proposal in https://codereview.qt-project.org/#/c/195712/ Reviewers: #vdg, #plasma, emmanuelp, davidedmundson Reviewed By: #plasma, davidedmundson Differential Revision: https://phabricator.kde.org/D5883
2017-05-27Introduce DolphinMainWindowTestElvis Angelaccio
For now it contains a test case for the crash in bug #379135 CCBUG: 379135 Reviewers: emmanuelp, dfaure Differential Revision: https://phabricator.kde.org/D5936
2017-05-27Move non-exported code to a static libraryElvis Angelaccio
This allows us to speed up the compilation because we don't need to build twice the source files we use in the unit tests. Test Plan: Builds, dolphin works and tests pass. Reviewers: emmanuelp, dfaure Differential Revision: https://phabricator.kde.org/D5935
2017-05-25SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-05-22Merge branch 'Applications/17.04'Luca Beltrame
2017-05-22Correct searchbox, split view transitions between tabsAnthony Fieroni
Differential Revision: https://phabricator.kde.org/D5864 BUG: 379135 BUG: 380032 FIXED-IN: 17.04.2 Signed-off-by: Anthony Fieroni <[email protected]>
2017-05-12add few more Q_DECL_OVERRIDEPino Toscano
2017-05-11Port tests from ecm_mark_as_test to ecm_add_testHannah von Reth
Summary: This enables us to run the tests on Windows. Reviewers: elvisangelaccio, kfunk, dfaure Reviewed By: elvisangelaccio Subscribers: #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D5810
2017-05-11Fix kfileitemmodeltestElvis Angelaccio
Commit 6dcbb8127c introduced the isHidden role, update the test accordingly.
2017-05-11Remove define to disable exportsHannah von Reth
As the tests are now correctly linked to dolphinprivate we need the actual export macro.
2017-05-08Merge branch 'Applications/17.04'Elvis Angelaccio
2017-05-08Don't ignore tag clicks in the tooltipsElvis Angelaccio
Summary: Now that we can use the metadata widgets in the tooltips, we can also open the tags:// url if the user clicks some tag in a tooltip. The behavior is now consistent with the metadata widget in the information panel. Test Plan: Click a tag when the metadata tooltip shows up. Reviewers: emmanuelp Subscribers: #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D5658
2017-05-08GIT_SILENT Upgrade KDE Applications version to 17.04.1.Albert Astals Cid
2017-04-29Sort the tag-values alphabetically in the "Tags" columnAthanasios Kanellopoulos
Up until now tag-values have appeared unsorted in the Tags column when the selected View Mode is "Details". In older versions of Dolphin (in KDE4) the tags-values were alphabetically sorted in the Tags column, which means that back then this was the desired behavior. This commit restores this functionality. BUG: 377589 FIXED-IN: 17.04.1 REVIEW: 130068
2017-04-12GIT_SILENT Upgrade KDE Applications version to 17.04.0.Albert Astals Cid
2017-04-07Fix some compiler warningsKevin Funk
2017-04-05GIT_SILENT Upgrade KDE Applications version to 17.03.90.Albert Astals Cid
2017-03-29Update name of the delete action in the .rc filesElvis Angelaccio
Summary: Small regression in commit 68bb0ec22a. We need to use the new (standard) name for the delete action, otherwise it won't be properly enabled/disabled. BUG: 378154 FIXED-IN: 17.03.90 Reviewers: emmanuelp Differential Revision: https://phabricator.kde.org/D5248
2017-03-28Merge remote-tracking branch 'origin/Applications/17.04'Albert Astals Cid
2017-03-28behavior change -> New Window opens with same URLDon Nguyen
This patch will cause a "New Window" command to open a new window with the URL from the active view. Opening a new instance via launcher will still open a new window with the URL specified in Startup settings. This is the behavior in Windows 10 file explorer. The advantage is this gives the user a way to open a new window with the current URL(New Window) as well as a new window with URL specified in Startup settings(new instance) whereas currently, there isn't an easy way to open a new window with the current URL. You'd have to either open a new window and copy and paste the URL, or open a new tab(which opens with the same URL) and detach it. I'd much rather have the new window open with the current URL and if what I wanted was the Startup URL I could easily get there as it's already bookmarked. REVIEW: 129973
2017-03-20GIT_SILENT Upgrade KDE Applications version to 17.03.80.Albert Astals Cid
2017-03-20GIT_SILENT Upgrade KDE Applications version to 17.07.70.Albert Astals Cid
2017-03-15[PlacesItemModel] Use QDir::homePath() instead of KUser().homeDir()Kai Uwe Broulik
KUser does quite a lot of stuff under the hood and also calls getpwuid which might block with network login. Differential Revision: https://phabricator.kde.org/D5049
2017-03-14Cleanup Places Panel context menusKai Uwe Broulik
Differential Revision: https://phabricator.kde.org/D4498
2017-03-14make services GHNS work with store.kde.orgMarco Martin
Summary: point the knsrc providers file to the new kde store, and port the servicemenuinstallation/servicemenudeinstallation scripts to kf5 (they still were based on kde4-config) BUG:376922 Test Plan: downloaded some service menus (send to telegram, convert svg) by the knewstuff ui available in the services page of config dialog they get installed in the proper folder and work, uninstall works Reviewers: #dolphin, emmanuelp Reviewed By: #dolphin, emmanuelp Subscribers: elvisangelaccio Differential Revision: https://phabricator.kde.org/D5035
2017-03-13Port to KStandardAction::DeleteFileElvis Angelaccio
Summary: It was introduced in kconfig 5.25 and it properly handles the shift+del shortcut (together with kxmlgui >= 5.30). This allows us to drop the custom delete shortcut as well as the shift+del workaround in DolphinMainWindow. Test Plan: Shift+Del still deletes files, without the 'ambiguous shortcut' warning dialog. Reviewers: emmanuelp Differential Revision: https://phabricator.kde.org/D5010
2017-03-12Revert "Make "show filter bar" a toggle action"Sergey Kalinichev
This reverts commit edf8e5737316204e4a96e5edf4cba4cdec1c71ef. See https://git.reviewboard.kde.org/r/129662 for discussion
2017-03-10Show pointing hand cursor when hovering spaceinfo barElvis Angelaccio
Summary: This improves the discoverability of the diskspace menu, a feature otherwise almost impossible to find. Reviewers: gregormi, emmanuelp Differential Revision: https://phabricator.kde.org/D4873
2017-03-08Pass application name and icon to KRunKai Uwe Broulik
Otherwise this results in the generic executable icon as bouncy cursor. Differential Revision: https://phabricator.kde.org/D4823
2017-03-08Honor KFileItem isHidden() in viewKai Uwe Broulik
Instead of just assuming hidden files always start with a "." The items were already filtered out but when showing hidden files they weren't painted at reduced opacity. Differential Revision: https://phabricator.kde.org/D4978
2017-02-26Increase smooth scrolling animation duration from 100 to 300 ms and set ↵Vishal Rao
easing curve to InOutQuart Summary: The current animation duration for smooth scrolling is 100 ms which feels as if there is no smooth scroll animation in the first place. Bumping this up to something like 300 ms seems to make the scrolling actually appear smooth. Also, based on diff comments the easing curve is set to InOutQuart. Test Plan: Built this change locally and tried scrolling a folder with many items both single step mouse wheel and also larger steps of the mouse wheel. Reviewers: elvisangelaccio, emmanuelp Reviewed By: emmanuelp Subscribers: htietze, colomar, andreask, emmanuelp, elvisangelaccio Differential Revision: https://phabricator.kde.org/D4560
2017-02-24GIT_SILENT made messages (after extraction)l10n daemon script
2017-02-20Work round missing right click event after dismissing a context menuDavid Edmundson
There is a bug that can happen in the following situation: - user right clicks to open a menu - that context menu grabs input - the QGrabphicsView also notes the mouse was pressed, but not that the mouse was released because it doesn't have mouse events any more - when a user clicks to dismiss the menu and then without moving clicks quickly again to send, we don't get another press event because the QGraphicsScene still thinks the mouse is pressed from the first time the context menu was shown and QGraphicsScenePrivate::lastMouseGrabberItemHasImplicitMouseGrab still points to the old object. This is a known bug in QGraphicsView and you can see QGraphicsScenePrivate::sendMouseEvent has a workaround to reset the lastMouseGrabberItemHasImplicitMouseGrab on mouse moves, with the comment: "This is a temporary fix for until we get proper mouse grab events." Realistically this isn't going to happen in QGraphicsView now. We do get a double click event though. By checking for double click events we can grab those missed clicks. It doesn't cause any other side effects because normally the context menu will fire after the first click and this rarely gets processed. REVIEW: 129960
2017-02-19Disallow executing Dolphin as root on LinuxEmmanuel Pescosta
Basically a copy of commit kate/9adcebd3c2e476c8a32e9b455cc99f46b0e12a7e which was written by Martin Grässlin.
2017-02-18Added .kdev4 to gitignoreEmmanuel Pescosta
2017-02-18Add a gitignore fileDon Nguyen
The entries in this patch are very minimal and are as follows: apidocs - user generated doc doxygen.log - log from generating doc CMakeLists.txt.user - from Qt Creator .directory - created by dolphin REVIEW: 129865
generated by cgit v1.3 (git 2.53.0) at 2026-04-27 00:22:25 +0000