| Age | Commit message (Collapse) | Author |
|
|
|
This reverts commit 648c2db6e4c6552962c20d2f9e4d3ce44e02d212.
|
|
|
|
|
|
|
|
When one instance of Dolphin activates another it passes a startupId (X11) / activation token (wayland) along.
On X11 this is passed using the DESKTOP_STARTUP_ID environment variable. The code tries to read that through KStartupInfo::startupId().
That doesn't work though, since Qt at startup reads the environment variable afterwards. However, it is nice enough to allow us to access
it through QX11Info::nextStartupId(). Use that to read the token in the first instance and pass it to the second instance like we do on Wayland
The user-facing impact of this is minimal since KStartupInfo::setNewStartupId internally falls back to KWindowSystem::forceActiveWindow when no
startupId is passed.
|
|
Completes all non-generic-Qt options listed in --help output.
Note: it uses the new variable KDE_INSTALL_ZSHAUTOCOMPLETEDIR, which was
added in ECM 5.101.
Read more: https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/310
|
|
|
|
In KF we already looking for 5.15.2
and looking something lower than that
is a bit meaningless
|
|
|
|
ecm_set_disabled_deprecation_versions() in versions < 5.96 was brokwn
when it comes to SHOW_DEPRECATIONS, warnings for newer deprecations
were disabled if the flag was set or not.
Starting with ECM 5.96 the macro now enables warnings by default,
so the flag is no longer needed.
GIT_SILENT
|
|
|
|
|
|
Using the gesture recognizer from KWidgetsAddons, so that the source code for the gestures is only in one place
|
|
|
|
|
|
|
|
|
|
This removes the custom-view engine version of the places panel
and replaces it with the upstream `KFilePlacesView` from KIO.
|
|
When Dolphin gets packaged as a flatpak, this patch gets applied:
https://invent.kde.org/packaging/flatpak-kde-applications/-/blob/master/dolphinpatch.patch
That's not really an ideal solution, so this is probably a better idea -- to upstream the patches and apply them depending on a CMake definition
|
|
Now that you can get elevated privileges while using the app, we can
display a more useful and descriptive error message when people try to
run Dolphin using `sudo` or `kdesu`.
Also bump the frameworks dependency to 5.90 since that's the KIO
version that includes this change, so we can be sure that the message is
always accurate.
|
|
The latter is only for KF modules to use.
Also include the KDE cmake modules as first thing, as their settings
can influence other included macros.
GIT_SILENT
|
|
|
|
popup
|
|
|
|
Dolphin still uses KToolInvocation::invokeTerminal() which is
deprecated and requires KInit. However Dolphin was ported away from
requiring it in other ways, so it is now possible to have Dolphin
running but not KInit, which breaks the "Open in Terminal"
functionality.
Using KTerminalLauncherJob fixes this. It was introduced in Frameworks
5.83, so the CMake dependency version is accordingly increased.
BUG: 441072
FIXED-IN: 21.12
|
|
Since KIO 5.82, KCoreDirLister (the base class of KDirLister) emits a jobError()
signal when the ListJob used internally emits an error.
Drop KFileItemModelDirLister class, now redundant.
This also bump the KF version to 5.82.
|
|
|
|
I am cross-compiling dolphin and haven't build KDocTools. Since it's only
needed for the handbook we can make the dependency optional.
|
|
|
|
|
|
Amends 9e8e58147
|
|
|
|
Not only does C++17 bring many nice things, it also will be required
with Qt6.
Many KDE projects already require 17 without issues.
|
|
|
|
|
|
Correctly scopes dolphin in systemd service `app-org.kde.dolphin.service` when dbus-activated (while still working if systemd is not present), as per https://systemd.io/DESKTOP_ENVIRONMENTS/
uses new ECM modules:
- https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/5 to simplify the systemd service templating + install
- https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/17 to generate the dbus service file automatically
needs https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/25
|
|
|
|
This commit introduces KUserFeedback in dolphin with some basic data
sources and with a settings page to configure the telemetry values.
There are also a couple custom data sources as proof of concept: a bunch
of settings and the count of available network shares as listed by Solid.
The settings page is shown only if the user feedback framework is
enabled, but currently in Plasma we don't have a global kill switch to
disable it.
At the moment we never show an encouragement message. We need to connect
to the `Provider::showEncouragementMessage()` signal, but first we
should agree to a common way to show a non-annoying message to the users.
|
|
This reverts commit eb441b11885fc44dcba1bef693b95819657ed753.
We'll push it again after we branch 20.12. We don't want to push a too
recent version of KF5 on distros.
!27
|
|
Correctly scopes dolphin in systemd service `app-org.kde.dolphin.service` when dbus-activated (while still working if systemd is not present), as per https://systemd.io/DESKTOP_ENVIRONMENTS/
uses new ECM modules:
- https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/5 to simplify the systemd service templating + install
- https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/17 to generate the dbus service file automatically
needs https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/25
|
|
The QSet range constructor requires Qt 5.14.
In `DolphinView::slotHeaderContextMenuRequested()` the conversion from
QList to QSet was pointless, so we just use a QList now.
|
|
StatJob::mostLocalUrl only works with ":local" protocols, adjust the code
accordingly.
Make the code async.
Remove activeContainerLocalPath() method as it isn't needed anymore.
Drive-by change: minimum required version of Qt should be 5.12 because
that's what KF >= 5.73 already requires.
|
|
In DolphinMainWindow, since KRun allows running executables by default, use
setRunExecutables(true) so as not to change the behaviour.
Remove the now redundant slotHandleUrlStatFinished, that whole StatJob
logic is now handled by OpenUrlJob.
Bump KF required version to 5.73, since that's where
OpenUrlJob::setShowOpenOrExecuteDialog was introduced.
|
|
|
|
Summary:
BUG: 415281
FIXED-IN: 20.08
Counter-part of D26113
Test Plan:
Before:
{F8215025}
After:
{F8215027}
Reviewers: ngraham, #dolphin
Reviewed By: ngraham, #dolphin
Subscribers: broulik, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D26114
|
|
Summary: The deb/rpm/pacman packages are now installed/uninstalled using packagekit.
Test Plan: Try to install deb package from kde store (search for `jetbrains`). Then uninstall it.
Reviewers: #dolphin, ngraham, elvisangelaccio, meven
Reviewed By: #dolphin, ngraham, elvisangelaccio, meven
Subscribers: cblack, anthonyfieroni, asturmlechner, meven, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D29119
|
|
Summary: Useful for trash:/ in particular
Test Plan: {F8233980}
Reviewers: #dolphin, dfaure, elvisangelaccio, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D28794
|
|
Needed after 885916b7b4.
|
|
|