| Age | Commit message (Collapse) | Author |
|
Switching the 'Move to Trash' action to 'Delete' using the shift key
does not work when the mouse hovers a submenu. This fix resolves the
issue by using an event filter instead of the key event functions.
BUG: 425997
|
|
This makes a bit easier to handle the stuff.
Also we don't need the `addVersionControlPluginActions` utility method
and we can put it in the new utility method instead.
|
|
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
|
|
TimelineOrSearchContext
Reviewers: #dolphin, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D25615
|
|
Summary:
This patch moves the "Open", "Open With", and "Open in" items to the top of the context menu to reap the following benefits:
- Move the "Open" and "Open With" items closer to the top since they're commonly used items, and right now they're buried in the middle of the menu
- Group related functionality
- Consistency with other common platforms (macOS Finder and Windows Explorer both have these items at the top of the context menu)
For folders, the "Open With" entries are moved higher, but not all the way to the top, since the "open in New tab/folder" entries are more useful.
Test Plan:
Tested all menu items in the context menu for files, folders, and links; all still work.
Context menu for single file:
{F5806809}
Context menu for multiple files:
{F5806810}
Context menu for single folder:
{F5806811}
Context menu for multiple folders:
{F5806812}
Context menu for symlink to folder:
{F5806815}
Reviewers: #dolphin, #vdg, elvisangelaccio, abetts
Reviewed By: #dolphin, #vdg, elvisangelaccio, abetts
Subscribers: markg, abetts, elvisangelaccio
Differential Revision: https://phabricator.kde.org/D11884
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
Also use override instead of Q_DECL_OVERRIDE
|
|
|
|
REVIEW: 129085
|
|
|
|
|
|
REVIEW: 120688
|
|
|
|
|
|
This adds a third option to the "in new tab" and "in new window" which opens
the parent folder in the same view
BUG: 298704
FIXED-IN: 4.15
REVIEW: 110133
|
|
Removed all signal-slot-connections related to DolphinNewFileMenu->errorMessage(QString)
in DolphinMainWindow and DolphinContextMenu and replaced it by a better solution.
Now we make use of the already existing DolphinNewFileMenuObserver singleton class to achieve a better
error handling, because every newly created DolphinContextMenu instance registers himself by DolphinNewFileMenuObserver
and we use this to connect the errorMessage(QString) signal of every DolphinContextMenu instance to the errorMessage(QString)
signal of the DolphinNewFileMenuObserver singleton class.
So we need only one connection from DolphinNewFileMenuObserver to DolphinMainWindow (or to DolphinPart) to
collect all error messages thrown by every DolphinNewFileMenu instance.
REVIEW: 112178
|
|
handling is now done via signals.
REVIEW: 111989
|
|
BUG: 261762
REVIEW: 111206
FIXED-IN: 4.11
|
|
- Updated both the Dolphin KPart and context menu to use the new
DolphinRemoveAction class to manage "Delete/Move to Trash" actions.
See also https://git.reviewboard.kde.org/r/107509/.
REVIEW: 108802
|
|
Finding out whether shift is pressed initially can be done
with qApp->keyboardModifiers(), and finding out that the user is pressing
or release shift can be done with keyPressEvent/keyReleaseEvent.
This required to inherit from KMenu rather than having the KMenu
as a member.
KModifierKeyInfo is only implemented on X11, so this makes the code
more portable. If similar solutions can be found for other users of
KModifierKeyInfo, it will be deprecated in KF5.
REVIEW: 110303
|
|
BUG: 300430
FIXED-IN: 4.9.0
|
|
See bug 188032 for an ongoing discussion. In case if this behavior
is really not wanted by users (the feedback on bugs.kde.org will
show), the review-request
https://git.reviewboard.kde.org/r/104915/ should be merged too
(after adjusting some parts of the code).
|
|
Thanks to Jekyll Wu for the analyses of the issue!
BUG: 290307
BUG: 269096
BUG: 290954
BUG: 264583
FIXED-IN: 4.8.0
|
|
- Open the context menu on the mouse-press event, not on the
mouse-release event.
- Provide an explicit position-information and don't use
QCursor::pos(). This fixes the issue that opening a context-menu
by the keyboard opens below the cursor.
- Provide different signals in the KItemListController for
the different context-menu types (item vs. view vs. header).
- Implement turning on/off roles by the header-context-menu.
|
|
If the user has hidden the menubar and the toolbar there is no way to
get back the menu (at least not without knowing the Ctrl+M shortcut).
Show an entry in the context-menu to bring back the menubar.
|
|
Use a similar default UI like in Rekonq and other browsers: Hide the
menubar and add access to all actions by a button in the toolbar.
Of course it is still possible to show the menubar so that the same UI
is given like before.
|
|
|
|
|
|
- Internal cleanups of DolphinContextMenu code
svn path=/trunk/KDE/kdebase/apps/; revision=1189651
|
|
actions "Open Parent Folder in New Window" and "Open Parent Folder in New Tab"
svn path=/trunk/KDE/kdebase/apps/; revision=1178362
|
|
X11-issue in combination with KModifierKeyInfo. Thanks to David Faure for the hint.
svn path=/trunk/KDE/kdebase/apps/; revision=1177902
|
|
constructing KModifierKeyInfo in the constructor of the context menu, the user interface might freeze. Thanks to Mark Gaiser for clarifying this with the KModifierKeyInfo maintainer and testing the workaround!
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=1177658
|
|
File menu get invisible
- Use KFileItemListProperties to check whether all selected URLs are local
- Coding style cleanups
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=1176534
|
|
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=1176513
|
|
the delete action line is not enabled in the settings) then the
"Move to trash (del)" action gets replaced by the "Delete (shift del)" action and replaced back to "Move to trash (del)" when you release
shift.
BUG: 194275
svn path=/trunk/KDE/kdebase/apps/; revision=1176493
|
|
- KNewMenu has been deprecated by KNewFileMenu. Reflect this in the names of related Dolphin classes.
- Provide context-sensitive actions also when a context-menu is opened on the viewport
BUG: 191938
FIXED-IN: 4.6.0
svn path=/trunk/KDE/kdebase/apps/; revision=1168586
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1065347
|
|
Don't show 'Add to Places' context-menu action for urls already in places.
svn path=/trunk/KDE/kdebase/apps/; revision=1048149
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1001385
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=948007
|
|
- let the "details view" show the "[x] Expandable Folders" action in the context menu
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=924867
|
|
avoid this independent reimplementation,
which brought back bug 121728 ('&' in application name treated as accelerator)
svn path=/trunk/KDE/kdebase/apps/; revision=815838
|
|
Also, move FileItemCapabilities from dolphin to KonqFileItemCapabilities at dfaure's request (making it implicitly shared along the way).
BUGS:161594
svn path=/trunk/KDE/kdebase/apps/; revision=815584
|
|
To/Copy To (note that this is just an initial version; adjustments must also be done for the global actions like Delete, Rename etc.)
svn path=/trunk/KDE/kdebase/apps/; revision=798658
|
|
can also be used by Dolphin now :-) In opposite to Konqueror the sub menus are turned off per default.
Minor issue: the Dolphin context menu should take care about the protocol capabilities (copy, move, delete, ...) like in konq_popupmenu (I'll fix this before 4.1).
CCMAIL: [email protected]
BUG: 155969
svn path=/trunk/KDE/kdebase/apps/; revision=792995
|
|
This allows to show the information inside the statusbar, that the paste operation has been completed (also some code duplication can be prevented by the way).
svn path=/trunk/KDE/kdebase/apps/; revision=791436
|
|
Konqueror and other file managers. Only if a context menu for a folder is opened, a pasting should be done into this folder.
Some internal cleanups are still required (see TODO comments), so that after finishing the operation an indication can be given to the user in the statusbar (must go for breakfast now, otherwise I'll eat my keyboard...).
BUG: 159862
svn path=/trunk/KDE/kdebase/apps/; revision=791354
|
|
BUG: 156375
svn path=/trunk/KDE/kdebase/apps/; revision=766406
|
|
BUG: 152463
svn path=/trunk/KDE/kdebase/apps/; revision=738282
|
|
used it from both KonqPopupMenu and DolphinContextMenu.
This isn't the port-to-ktrader yet, this will come later, but at least the code is factorized and the impl can be changed without affecting the dolphin+konqpopupmenu code
Should I also implement the "Open With..." actions in KonqMenuActions? Seems like another bit of similar code duplicated.
CCMAIL: [email protected], [email protected]
Removed KonqBookmarkManager (was a two-liner call to KBookmarkManager)
svn path=/trunk/KDE/kdebase/apps/; revision=722668
|