┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/dolphinmainwindow.cpp
AgeCommit message (Collapse)Author
2018-03-10Fix some compile warningsRoman Inflianskas
Reviewers: markg, elvisangelaccio Reviewed By: markg, elvisangelaccio Subscribers: chehrlic, rkflx, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10995
2018-03-05Revert "Fix some compile warnings"Elvis Angelaccio
This reverts commit 533f050855a50212bba7be57a1590f9ce743e26d. D10995 has not been approved.
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-04Fix some compile warningsRoman Inflianskas
Reviewers: #dolphin, markg Reviewed By: markg Subscribers: elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10995
2018-03-03Modernize the syntax of shortcutsRoman Inflianskas
Reviewers: #dolphin, markg Reviewed By: markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10986
2018-03-03Add default shortcut "/" for opening filter panelRoman Inflianskas
Summary: Add default shortcut "/" for opening filter panel. FEATURE: 156381 Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D10961
2018-02-14Add icons to Edit menuMarjio Mustac
Summary: Since Breeze offers such a great palette of action icons I thought we should make use of them which make things also more consistent with other applications. Before: {F5711158} After: {F5711159} Test Plan: Show menubar Icons are shown in Edit menu Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham Differential Revision: https://phabricator.kde.org/D10503
2018-02-10Build TerminalPanel also on WindowsElvis Angelaccio
Summary: terminalpanel.cpp *should* compile on Windows, so there is no reason to remove it from the build and use tons of #ifdefs in dolphinmainwindow. We still keep the terminal panel disabled on Windows (i.e. the two remaining #ifndef Q_OS_WIN in dolphinmainwindow), because it is probably not functional. But at least we won't break the Windows CI every time someone touches the terminal panel code (see e.g. 2e942237c9). Test Plan: Builds on Linux, someone on Windows should test this patch if possible. Reviewers: #dolphin, #craft Differential Revision: https://phabricator.kde.org/D10006
2018-02-03Use new KStandardAction slot syntaxElvis Angelaccio
This was probably forgotten from commit 3bfdf0d2.
2018-01-30Merge branch 'Applications/17.12'Nathaniel Graham
2018-01-29Let the terminal panel sit on the left or right side of the windowNathaniel Graham
Summary: Just what it says: Let the terminal panel sit on the left or right side of the window. Test Plan: Tested in KDE Neon. Works great! Reviewers: #dolphin Differential Revision: https://phabricator.kde.org/D10189
2018-01-21Don't show 'Open Terminal' on WindowsElvis Angelaccio
We already disable the TerminalPanel on Windows, we should do the same with the 'Open Terminal' action for consistency.
2018-01-18Exclude m_terminalPanel references when built on WindowsAdrián Chaves (Gallaecio)
Fixes an issue reported by elvisangelaccio at https://phabricator.kde.org/D9955
2018-01-18Set the focus to the active view, after leaving the terminal panelAdrián Chaves Fernández (Gallaecio)
Summary: BUG: 298467 Set the focus to the active view, after leaving the terminal panel. This is a fork of the patch at https://git.reviewboard.kde.org/r/116118/ by @emmanuelp which should fix the issue with the original patch reported by Frank Reininghaus. Test Plan: Works for me. Reviewers: #dolphin, emmanuelp, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, emmanuelp Differential Revision: https://phabricator.kde.org/D9955
2017-12-13Change "Empty Search" to just "Search" to handle searches with no search textNathaniel Graham
Summary: BUG: 387854 The pre-defined searches (Documents, Videos, etc) all default to no search text. https://cgit.kde.org/dolphin.git/commit/?id=702429ac8e64a5aff4e110a56f526b96ecb795fd changed their window title from "baloosearch - /" to "Empty Search", but the search isn't really empty; it just lacks a search string. It's still looking for documents, or videos, or whatever. Test Plan: Is it too late to get this into 5.12? Tested in KDE Neon. Before: {F5545170} After: {F5545171} Reviewers: #dolphin, elvisangelaccio, broulik Reviewed By: broulik Differential Revision: https://phabricator.kde.org/D9305
2017-12-03Change window title when searchingJulian Schraner
Summary: When you search for a file (e.g. "hello world") the window title of Dolphin will now change to "Search for [input]" instead of "baloosearch - /". BUG: 321575 Test Plan: - Disables it iself after search bar is hidden - Works with multiple word searches Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D8273
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-10Use new folder-stash iconNathaniel Graham
Summary: Resolves T7185 Use the new folder-stash icon introduced in https://cgit.kde.org/breeze-icons.git/commit/?id=b909a8008a7e3ffabb090bc82127ebb561f58597 Test Plan: Tested in KDE Neon. Dolphin now uses the new icon is `kio-stash` is installed: {F5482031} Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: cfeck Maniphest Tasks: T7185 Differential Revision: https://phabricator.kde.org/D8722
2017-10-14Fix Q_OS_WIN ifdefElvis Angelaccio
This should fix my previous commit.
2017-10-14Fix build on WindowsElvis Angelaccio
TerminalPanel is not available on Windows, so commit bd47eb2e6d broke the MSVC build on the CI.
2017-10-12Don't block unmounting when terminal panel's cwd is the mountpointMiklos Marton
When unmounting a removable media Dolphin checks if there are some files open on the device before performing the unmount. If the terminal window in dolphin is open and the to be unmounted path is open, the unmount process will be blocked. This patch sets the terminal window current path to the home directory upon unmount request if the terminal directory is set to the mount path. The unmount request could came from two sources: The user could hit right click on the media in the dolphin's places panel and hit unmount. The user could request an unmount from the indicator applet This patch was originally written by Arjun AK for the kdelibs4 version of Dolphin: https://git.reviewboard.kde.org/r/121613/ BUG: 158264 FIXED-IN: 17.11.80 Differential Revision: https://phabricator.kde.org/D7847
2017-08-29Prefer place name over actual name in title barKai Uwe Broulik
When inside a place, the address bar already gives it precedence over the actual folder name. By doing this in the title bar also, we make it consistent and can mask ugly technical terminology like "trash:/" and instead show the nice localized "Trash" place name as well as "Home" instead of lowercase internal user name. BUG: 211959 Differential Revision: https://phabricator.kde.org/D4826
2017-08-24Port to new KStandardAction slot syntaxElvis Angelaccio
For more compile-time safety.
2017-08-24Support middle clicking of Back/Forward/Up/Home toolbar buttonsKai Uwe Broulik
This opens the resulting page in a new tab. BUG: 358649 Differential Revision: https://phabricator.kde.org/D7390
2017-08-09Port to KStandardAction::RenameFileElvis Angelaccio
It was introduced in kconfig(widgets) 5.25. Using the standard action results in less code and no need to hardcode the F2 shortcut. Differential Revision: https://phabricator.kde.org/D6777
2017-08-03Port to KHelpMenuElvis Angelaccio
Less code and KHelpMenu respects KIOSK restrictions. Differential Revision: https://phabricator.kde.org/D7095
2017-07-28Merge branch 'Applications/17.08'Elvis Angelaccio
2017-07-28Fix loading of dolphinui.rcElvis Angelaccio
dolphin.qrc is compiled into a static library, which means we need to force its loading with the Q_INIT_RESOURCE macro. See http://doc.qt.io/qt-5/resources.html#using-resources-in-a-library BUG: 382848 FIXED-IN: 17.07.90 Differential Revision: https://phabricator.kde.org/D6958
2017-07-27Port to KStandardAction::MoveToTrashElvis Angelaccio
It was introduced in kconfig(widgets) 5.25. Using the standard action results in less code and no need to hardcode the Del shortcut. Test Plan: - Change shortcut in System Settings -> Shortcuts -> Standard Shortcuts - Make sure the new shortcut is used by dolphin. Differential Revision: https://phabricator.kde.org/D6778
2017-06-11Merge branch 'Applications/17.04'Elvis Angelaccio
* Applications/17.04: Change in "Open in new tab" feature in Dolphin Ignore drops-onto-items from invalid places items Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"
2017-06-11Change in "Open in new tab" feature in DolphinEmirald Mateli
Summary: This patch proposes a change to the "open in new tab" feature. The "open in new tab" feature will try to open selected items (files or folders) in a new tab, however, if there are no valid items to be opened in a new tab then nothing will happen, making it look like a bug. This patch adds the functionality that when there are no valid items(files or folders) to be opened in a new tab the current folder will be opened. Test Plan: 1. Select a file(pdf, text, image etc) in Dolphin 2. Click on the "Open in new tab" toolbar button Expected: since the file is not a valid target to open in a new tab, the current directory should be opened (as is the case where selection is empty) Actual: Nothing happens after the button is pressed Reviewed By: #dolphin, elvisangelaccio Differential Revision: https://phabricator.kde.org/D6182
2017-05-27Introduce DolphinMainWindowTestElvis Angelaccio
For now it contains a test case for the crash in bug #379135 CCBUG: 379135 Reviewers: emmanuelp, dfaure Differential Revision: https://phabricator.kde.org/D5936
2017-05-08Don't ignore tag clicks in the tooltipsElvis Angelaccio
Summary: Now that we can use the metadata widgets in the tooltips, we can also open the tags:// url if the user clicks some tag in a tooltip. The behavior is now consistent with the metadata widget in the information panel. Test Plan: Click a tag when the metadata tooltip shows up. Reviewers: emmanuelp Subscribers: #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D5658
2017-03-28behavior change -> New Window opens with same URLDon Nguyen
This patch will cause a "New Window" command to open a new window with the URL from the active view. Opening a new instance via launcher will still open a new window with the URL specified in Startup settings. This is the behavior in Windows 10 file explorer. The advantage is this gives the user a way to open a new window with the current URL(New Window) as well as a new window with URL specified in Startup settings(new instance) whereas currently, there isn't an easy way to open a new window with the current URL. You'd have to either open a new window and copy and paste the URL, or open a new tab(which opens with the same URL) and detach it. I'd much rather have the new window open with the current URL and if what I wanted was the Startup URL I could easily get there as it's already bookmarked. REVIEW: 129973
2017-03-13Port to KStandardAction::DeleteFileElvis Angelaccio
Summary: It was introduced in kconfig 5.25 and it properly handles the shift+del shortcut (together with kxmlgui >= 5.30). This allows us to drop the custom delete shortcut as well as the shift+del workaround in DolphinMainWindow. Test Plan: Shift+Del still deletes files, without the 'ambiguous shortcut' warning dialog. Reviewers: emmanuelp Differential Revision: https://phabricator.kde.org/D5010
2017-03-12Revert "Make "show filter bar" a toggle action"Sergey Kalinichev
This reverts commit edf8e5737316204e4a96e5edf4cba4cdec1c71ef. See https://git.reviewboard.kde.org/r/129662 for discussion
2017-03-08Pass application name and icon to KRunKai Uwe Broulik
Otherwise this results in the generic executable icon as bouncy cursor. Differential Revision: https://phabricator.kde.org/D4823
2017-02-18Make "show filter bar" a toggle actionDon Nguyen
REVIEW: 129662
2017-02-13Merge branch 'stashAction'arnav dhamija
This adds the support for the Stash action which will be helpful for the upcoming stash:/ ioslave
2017-02-13Whitespace?arnav dhamija
2017-02-13Whitespace?arnav dhamija
2017-02-13Whitespace?arnav dhamija
2017-02-13Improved the patcharnav dhamija
2017-02-05Drop no longer needed version checkElvis Angelaccio
Frameworks 5.30 is now the minimum version required.
2017-02-02More happy with this patcharnav dhamija
2017-01-29Made more changesarnav dhamija
2017-01-29Time to get back to businessarnav dhamija
2017-01-18Port away from deprecated KIO::Job::ui()Elvis Angelaccio
It's equivalent to KJob::uiDelegate() from kcoreaddons.
2017-01-14Show full path in title barJohn Salatas
BUG: 229810 Differential Revision: https://phabricator.kde.org/D4078
2016-11-03This seems to work. Though it could be betterarnav dhamija
generated by cgit v1.3 (git 2.53.0) at 2026-04-20 16:29:57 +0000