| Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
This mostly red MR should have no visible effect. It is part of my work towards !273.
There are two calls necessary to open the DolphinContextMenu:
One to construct it and one to execute/show it.
Before this commit, the actual populating of the ContextMenu was
done on execute. This meant that the actions of the ContextMenu
couldn't be looked at or changed without first showing the Menu
to the user. It also meant that the construction itself didn't
actually do much constructing/populating at all which might seem
a bit unintuitive.
This commit changes this behaviour so the DolphinContextMenu is
actually populated fully on construction. The executing/showing of
the ContextMenu now does just that and nothing more.
Previously, some actions in the context menu were actually not
wired up to anything and instead the DolphinContextMenu or the
DolphinMainWindow executed some code after the user had clicked
such a dummy action from the ContextMenu. Now all the actions are
properly constructed beforehand and no special handling is
necessary when the ContextMenu hides itself.
This commit removes the pos parameter from the DolphinContextMenu
constructor. This parameter contained the position where the Menu
would be shown later. This information isn't necessary to have on
construction and was already part of the exec(pos) call in the
first place. The variable m_pos that stored the value is removed.
This commit also removes a "customActions" functionality that can
supposedly be used to add further custom actions to the
DolphinContextMenu but this functionality isn't ever used
anywhere so its usefulness is questionable. It also wouldn't be
difficult to re-add this functionality if it was ever required for
something.
This commit also addresses an old TODO in dolphinpart.cpp that
asked for the calls for opening the DolphinContextMenu to actually
contain the information for which items the DolphinContextMenu is
supposed to be constructed. Before this, only the item that was
directly clicked was transmitted and then DolphinContextMenu
retrieved the currently selected set of items by itself.
It makes more sense that DolphinContextMenu would be informed on
construction which items it is supposed to show context actions
for.
Most of this is necessary so we are able to show the contextual
actions anywhere else than in the ContextMenu in the future.
I am targeting 22.08 with this MR because it makes no sense to merge a refactor for the upcoming release already.
|
|
|
|
|
|
|
|
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
|
|
Summary:
Added "Open Preferred Search Tool" action to Tools menu.
It runs preferred (topmost) external search tool as configured in the "More Search Tools" menu.
By default Ctrl+Shift+F shortcut is assigned to this action.
FEATURE: 384798
FIXED-IN: 20.03.80
{F7134238}
{F7134240}
{F7134242}
Reviewers: #dolphin, ngraham, elvisangelaccio
Reviewed By: #dolphin, ngraham
Subscribers: pkloc, kfm-devel, kde-doc-english
Tags: #dolphin, #documentation
Differential Revision: https://phabricator.kde.org/D22594
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
Also use override instead of Q_DECL_OVERRIDE
|
|
REVIEW: 126771
|
|
|
|
REVIEW: 120688
|
|
REVIEW: 120650
|
|
|
|
|
|
|
|
This does not work properly yet, there are probably quite a few bad signal/
slot connections due to KUrl -> QUrl. However dolphin starts without
crashing.
Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
and I have no idea how it is supposed to be used.
This is the first commit for review 117395
|
|
REVIEW: 113132
|
|
Removed all signal-slot-connections related to DolphinNewFileMenu->errorMessage(QString)
in DolphinMainWindow and DolphinContextMenu and replaced it by a better solution.
Now we make use of the already existing DolphinNewFileMenuObserver singleton class to achieve a better
error handling, because every newly created DolphinContextMenu instance registers himself by DolphinNewFileMenuObserver
and we use this to connect the errorMessage(QString) signal of every DolphinContextMenu instance to the errorMessage(QString)
signal of the DolphinNewFileMenuObserver singleton class.
So we need only one connection from DolphinNewFileMenuObserver to DolphinMainWindow (or to DolphinPart) to
collect all error messages thrown by every DolphinNewFileMenu instance.
REVIEW: 112178
|
|
- Updated both the Dolphin KPart and context menu to use the new
DolphinRemoveAction class to manage "Delete/Move to Trash" actions.
See also https://git.reviewboard.kde.org/r/107509/.
REVIEW: 108802
|
|
multiple files are selected
BUG: 304299
REVIEW: 107305
|
|
(cherry picked from commit 1e45cb9019e08ca574a997f2e41da5e3e47928b4)
|
|
(cherry picked from commit f0d5e062bf0452258d337d7dcb2edd2eefa1c37b)
|
|
REVIEW: 106333
(cherry picked from commit acef4b1c287a315b42550c27fc18ac4b9f49746c)
|
|
KParts::ListingFilterExtension.
REVIEW: 106289
(cherry picked from commit cb79ee6a881e2b4418bccc22480e3e269e5b0af9)
|
|
only.
BUG: 279283
FIXED-IN: 4.9.0
REVIEW: 105607
(cherry picked from commit 9a622c16d969a39571b610304db759f941b5d4f3)
|
|
|
|
Fix some naming inconsistencies regarding the usage of 'dir' vs.
'directory' vs. 'folder'.
|
|
- Open the context menu on the mouse-press event, not on the
mouse-release event.
- Provide an explicit position-information and don't use
QCursor::pos(). This fixes the issue that opening a context-menu
by the keyboard opens below the cursor.
- Provide different signals in the KItemListController for
the different context-menu types (item vs. view vs. header).
- Implement turning on/off roles by the header-context-menu.
|
|
|
|
When the searching has been integrated into Dolphin the "Find File..."
entry had been removed from the Tools menu. Readd it into the Dolphin
KPart so that it is still available for Konqueror.
BUG: 270072
FIXED-IN: 4.7.0
|
|
proxy model to DolphinView. By this it will be easier later to replace the traditional QAbstractItemViews by any kind of other implementation (e.g. based on QGraphicsView/QML).
svn path=/trunk/KDE/kdebase/apps/; revision=1213189
|
|
QAbstractItemView-specific things like QItemSelectionModel. Just providing interfaces for KFileItem and KUrl will make it easier in future to change the view-implementations internally to QML-specific itemviews or whatever.
svn path=/trunk/KDE/kdebase/apps/; revision=1193113
|
|
obtain such information
svn path=/trunk/KDE/kdebase/apps/; revision=1191993
|
|
- KNewMenu has been deprecated by KNewFileMenu. Reflect this in the names of related Dolphin classes.
- Provide context-sensitive actions also when a context-menu is opened on the viewport
BUG: 191938
FIXED-IN: 4.6.0
svn path=/trunk/KDE/kdebase/apps/; revision=1168586
|
|
requestUrlChange signal. This signal was removed in r1080351, so the
code isn't needed any more.
svn path=/trunk/KDE/kdebase/apps/; revision=1095213
|
|
Dolphin.
While at it, I reworked the handling of command-line options in main completely,
to factorize code and make --select do the right thing even in case of multiple args
(wasn't supported in kde3).
svn path=/trunk/KDE/kdebase/apps/; revision=1081246
|
|
only way to avoid duplicating code until kde5)
Port all of kdebase' use of KNewMenu to KNewFileMenu.
Also port from KonqNameAndUrlInputDialog to KNameAndUrlInputDialog,
and from KonqMenuActions to KFileItemActions in dolphincontextmenu.cpp
svn path=/trunk/KDE/kdebase/apps/; revision=1080547
|
|
management. It includes the actions "Select All" and "Select Items
Matching a Pattern".
This feature will be in KDE 4.4.
FEATURE: 197536
svn path=/trunk/KDE/kdebase/apps/; revision=1053976
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1049182
|
|
1. the current item,
2. the scroll position of the view, and
3. the expansion state of the details view.
Before 3. can be implemented in Dolphin itself, some changes in
KUrlNavigator are required.
This fix will be in KDE 4.4.
BUG: 193549
BUG: 198073
BUG: 213137
svn path=/trunk/KDE/kdebase/apps/; revision=1049164
|
|
BrowserExtension)
svn path=/trunk/KDE/kdebase/apps/; revision=1047090
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1004949
|
|
operation-completed messages.
svn path=/trunk/KDE/kdebase/apps/; revision=1004346
|
|
has been pressed, so that the directory gets automatically selected afterwards.
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=945037
|
|
GUI:
The remote encoding code adapted from Konqueror to Dolphin. Now user can change
encoding for remote urls like ftp. Konqueror doesn't use
KRemoteEncodingPlugin anymore. Instead, this feature is supplied to
Konqueror via DolphinPart.
svn path=/trunk/KDE/kdebase/apps/; revision=944659
|
|
- let the "details view" show the "[x] Expandable Folders" action in the context menu
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=924867
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=912124
|