┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/dolphinpart.h
AgeCommit message (Collapse)Author
2023-12-14Dolphin: Remove unused code, fix clazy warningsMéven Car
2023-08-29Fix a bunch of clazy warningsMéven Car
2023-02-05Add clang-format and format code as in FrameworksSerg Podtynnyi
2022-04-02Refactor DolphinContextMenu so its actions are retrievableFelix Ernst
This mostly red MR should have no visible effect. It is part of my work towards !273. There are two calls necessary to open the DolphinContextMenu: One to construct it and one to execute/show it. Before this commit, the actual populating of the ContextMenu was done on execute. This meant that the actions of the ContextMenu couldn't be looked at or changed without first showing the Menu to the user. It also meant that the construction itself didn't actually do much constructing/populating at all which might seem a bit unintuitive. This commit changes this behaviour so the DolphinContextMenu is actually populated fully on construction. The executing/showing of the ContextMenu now does just that and nothing more. Previously, some actions in the context menu were actually not wired up to anything and instead the DolphinContextMenu or the DolphinMainWindow executed some code after the user had clicked such a dummy action from the ContextMenu. Now all the actions are properly constructed beforehand and no special handling is necessary when the ContextMenu hides itself. This commit removes the pos parameter from the DolphinContextMenu constructor. This parameter contained the position where the Menu would be shown later. This information isn't necessary to have on construction and was already part of the exec(pos) call in the first place. The variable m_pos that stored the value is removed. This commit also removes a "customActions" functionality that can supposedly be used to add further custom actions to the DolphinContextMenu but this functionality isn't ever used anywhere so its usefulness is questionable. It also wouldn't be difficult to re-add this functionality if it was ever required for something. This commit also addresses an old TODO in dolphinpart.cpp that asked for the calls for opening the DolphinContextMenu to actually contain the information for which items the DolphinContextMenu is supposed to be constructed. Before this, only the item that was directly clicked was transmitted and then DolphinContextMenu retrieved the currently selected set of items by itself. It makes more sense that DolphinContextMenu would be informed on construction which items it is supposed to show context actions for. Most of this is necessary so we are able to show the contextual actions anywhere else than in the ContextMenu in the future. I am targeting 22.08 with this MR because it makes no sense to merge a refactor for the upcoming release already.
2021-02-09Add missing includesNicolas Fella
2020-12-29update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl()Piotr Henryk Dabrowski
2020-12-07dolphinpart: port to new KPluginMetaData-based KParts APIFriedrich W. H. Kossebau
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2019-11-17[Dolphin] Open Preferred Search Tool actionPiotr Henryk Dabrowski
Summary: Added "Open Preferred Search Tool" action to Tools menu. It runs preferred (topmost) external search tool as configured in the "More Search Tools" menu. By default Ctrl+Shift+F shortcut is assigned to this action. FEATURE: 384798 FIXED-IN: 20.03.80 {F7134238} {F7134240} {F7134242} Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham Subscribers: pkloc, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D22594
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2014-11-03Q_DECL_OVERRIDELukáš Tinkl
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-21port Konqueror from KUrl to QUrlLukáš Tinkl
REVIEW: 120650
2014-10-18Fix includesMontel Laurent
2014-10-11clean forward declarationMontel Laurent
2014-05-05KParts::ReadOnlyPart::openUrl() changed from KUrl parameter to QUrlAlex Richardson
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2013-10-12Moved all the extension code into dolphinpart_ext.*Dawit Alemayehu
REVIEW: 113132
2013-08-28Replaced all KNewFileMenu usages in DolphinPart by DolphinNewFileMenu.Emmanuel Pescosta
Removed all signal-slot-connections related to DolphinNewFileMenu->errorMessage(QString) in DolphinMainWindow and DolphinContextMenu and replaced it by a better solution. Now we make use of the already existing DolphinNewFileMenuObserver singleton class to achieve a better error handling, because every newly created DolphinContextMenu instance registers himself by DolphinNewFileMenuObserver and we use this to connect the errorMessage(QString) signal of every DolphinContextMenu instance to the errorMessage(QString) signal of the DolphinNewFileMenuObserver singleton class. So we need only one connection from DolphinNewFileMenuObserver to DolphinMainWindow (or to DolphinPart) to collect all error messages thrown by every DolphinNewFileMenu instance. REVIEW: 112178
2013-05-14- Factored out the Delete/Move To Trash action into own class.Dawit Alemayehu
- Updated both the Dolphin KPart and context menu to use the new DolphinRemoveAction class to manage "Delete/Move to Trash" actions. See also https://git.reviewboard.kde.org/r/107509/. REVIEW: 108802
2012-12-13Fix Bug 304299 - Dolphin launches multiple instances of a program when ↵Emmanuel Pescosta
multiple files are selected BUG: 304299 REVIEW: 107305
2012-09-15Corrected the compile fix commit, rev 965fc6b3.Dawit Alemayehu
(cherry picked from commit 1e45cb9019e08ca574a997f2e41da5e3e47928b4)
2012-09-11Fix compile against the minimum required kdelibs version (v4.7.97)Dawit Alemayehu
(cherry picked from commit f0d5e062bf0452258d337d7dcb2edd2eefa1c37b)
2012-09-07Implemented the new KParts extension, KParts::ListingiNotificationExtension.Dawit Alemayehu
REVIEW: 106333 (cherry picked from commit acef4b1c287a315b42550c27fc18ac4b9f49746c)
2012-09-05Implemented the new KParts' listing filter extension, ↵Dawit Alemayehu
KParts::ListingFilterExtension. REVIEW: 106289 (cherry picked from commit cb79ee6a881e2b4418bccc22480e3e269e5b0af9)
2012-07-22Show the "Find File" and "Open Terminal" actions in the Tools for file URLs ↵Dawit Alemayehu
only. BUG: 279283 FIXED-IN: 4.9.0 REVIEW: 105607 (cherry picked from commit 9a622c16d969a39571b610304db759f941b5d4f3)
2012-04-17Fixed the signal connection that emits completed in Dolphin's KPartDawit Alemayehu
2012-04-11KFileItemModel: interface cleanupsPeter Penz
Fix some naming inconsistencies regarding the usage of 'dir' vs. 'directory' vs. 'folder'.
2011-10-08Context menu cleanupsPeter Penz
- Open the context menu on the mouse-press event, not on the mouse-release event. - Provide an explicit position-information and don't use QCursor::pos(). This fixes the issue that opening a context-menu by the keyboard opens below the cursor. - Provide different signals in the KItemListController for the different context-menu types (item vs. view vs. header). - Implement turning on/off roles by the header-context-menu.
2011-08-29Renamed some signals for consistency with KItemViews classesPeter Penz
2011-04-10Readd KFind shortcut for the Dolphin KPartPeter Penz
When the searching has been integrated into Dolphin the "Find File..." entry had been removed from the Tools menu. Readd it into the Dolphin KPart so that it is still available for Konqueror. BUG: 270072 FIXED-IN: 4.7.0
2011-01-09Encapsulate the creation and handling of the directory lister, the model and ↵Peter Penz
proxy model to DolphinView. By this it will be easier later to replace the traditional QAbstractItemViews by any kind of other implementation (e.g. based on QGraphicsView/QML). svn path=/trunk/KDE/kdebase/apps/; revision=1213189
2010-11-04Interface cleanup: The DolphinView should not expose ↵Peter Penz
QAbstractItemView-specific things like QItemSelectionModel. Just providing interfaces for KFileItem and KUrl will make it easier in future to change the view-implementations internally to QML-specific itemviews or whatever. svn path=/trunk/KDE/kdebase/apps/; revision=1193113
2010-11-01Added implementation of the FileInfoExtension to allow KPart plugins to ↵Dawit Alemayehu
obtain such information svn path=/trunk/KDE/kdebase/apps/; revision=1191993
2010-08-27Context-menu cleanups:Peter Penz
- KNewMenu has been deprecated by KNewFileMenu. Reflect this in the names of related Dolphin classes. - Provide context-sensitive actions also when a context-menu is opened on the viewport BUG: 191938 FIXED-IN: 4.6.0 svn path=/trunk/KDE/kdebase/apps/; revision=1168586
2010-02-23Remove all code that is related to DolphinController'sFrank Reininghaus
requestUrlChange signal. This signal was removed in r1080351, so the code isn't needed any more. svn path=/trunk/KDE/kdebase/apps/; revision=1095213
2010-01-27Implement the --select option in konqueror again, using Peter's nice work in ↵David Faure
Dolphin. While at it, I reworked the handling of command-line options in main completely, to factorize code and make --select do the right thing even in case of multiple args (wasn't supported in kde3). svn path=/trunk/KDE/kdebase/apps/; revision=1081246
2010-01-26Deprecated KNewMenu and make it derive from KNewFileMenu (BIC, but SC; the ↵David Faure
only way to avoid duplicating code until kde5) Port all of kdebase' use of KNewMenu to KNewFileMenu. Also port from KonqNameAndUrlInputDialog to KNameAndUrlInputDialog, and from KonqMenuActions to KFileItemActions in dolphincontextmenu.cpp svn path=/trunk/KDE/kdebase/apps/; revision=1080547
2009-11-25Restore the "Edit->Selection" menu from Konqueror 3 for fileFrank Reininghaus
management. It includes the actions "Select All" and "Select Items Matching a Pattern". This feature will be in KDE 4.4. FEATURE: 197536 svn path=/trunk/KDE/kdebase/apps/; revision=1053976
2009-11-14SVN_SILENT: Remove trailing white spaceFrank Reininghaus
svn path=/trunk/KDE/kdebase/apps/; revision=1049182
2009-11-14When navigating back/forward in the DolphinPart inside Konqueror, rememberFrank Reininghaus
1. the current item, 2. the scroll position of the view, and 3. the expansion state of the details view. Before 3. can be implemented in Dolphin itself, some changes in KUrlNavigator are required. This fix will be in KDE 4.4. BUG: 193549 BUG: 198073 BUG: 213137 svn path=/trunk/KDE/kdebase/apps/; revision=1049164
2009-11-10Fix RMB/paste on a subfolder (konq calls pasteTo(KUrl), as documented in ↵David Faure
BrowserExtension) svn path=/trunk/KDE/kdebase/apps/; revision=1047090
2009-07-31Fix forward declarationLaurent Montel
svn path=/trunk/KDE/kdebase/apps/; revision=1004949
2009-07-29Allow the revision control plugins to indicate information-, error- and ↵Peter Penz
operation-completed messages. svn path=/trunk/KDE/kdebase/apps/; revision=1004346
2009-03-26Use KNewMenu::createDirectory() instead of KonqOperations::newDir() when F10 ↵Peter Penz
has been pressed, so that the directory gets automatically selected afterwards. CCMAIL: [email protected] svn path=/trunk/KDE/kdebase/apps/; revision=945037
2009-03-25BUG: 175658Rahman Duran
GUI: The remote encoding code adapted from Konqueror to Dolphin. Now user can change encoding for remote urls like ftp. Konqueror doesn't use KRemoteEncodingPlugin anymore. Instead, this feature is supplied to Konqueror via DolphinPart. svn path=/trunk/KDE/kdebase/apps/; revision=944659
2009-02-11- allow the view implementations to attach custom actions to the context menuPeter Penz
- let the "details view" show the "[x] Expandable Folders" action in the context menu CCMAIL: [email protected] svn path=/trunk/KDE/kdebase/apps/; revision=924867
2009-01-16Remove useless code, replaced with slotRedirection.David Faure
svn path=/trunk/KDE/kdebase/apps/; revision=912124