┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/dolphinviewcontainer.cpp
AgeCommit message (Collapse)Author
2018-03-19Introduce singleton for KFilePlacesModelKai Uwe Broulik
There are various places where Dolphin created a new KFilePlacesModel which would then query all storage devices and do other expensive work. Differential Revision: https://phabricator.kde.org/D11283
2018-03-18Show "Empty Trash" button inside trash directoryRoman Inflianskas
Summary: Show "Empty Trash" button inside trash directory. FEATURE: 163306 Test Plan: {F5734949} Reviewers: ngraham, rkflx, markg, elvisangelaccio Reviewed By: ngraham, markg, elvisangelaccio Subscribers: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D10804
2018-03-11Add Trash (empty, isEmpty, emptinessChanged)Roman Inflianskas
Summary: Add `Trash` class to handle all trash operations. Reviewers: elvisangelaccio, markg, ngraham Reviewed By: elvisangelaccio, markg, ngraham Subscribers: ngraham, markg, rkflx, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D11012
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2017-12-03Change window title when searchingJulian Schraner
Summary: When you search for a file (e.g. "hello world") the window title of Dolphin will now change to "Search for [input]" instead of "baloosearch - /". BUG: 321575 Test Plan: - Disables it iself after search bar is hidden - Works with multiple word searches Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D8273
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-01Make Saved Search feature discoverableNathaniel Graham
Summary: FEATURE: 269332 Make Dolphin's Saved Search feature discoverable by adding a button inside the search field. The button only becomes enabled when there is a valid search term. When pushed, it saves the search to the Places panel, providing a visible-by-default way to do this to complement the existing implementation that is only visible in the context menu. Also harmonized the label text so that it's consistent no matter how you create a saved search (button or context menu) Test Plan: Tested in KDE Neon. Works great: {F5449508} Reviewers: #dolphin, broulik, dfaure, markg, emateli, elvisangelaccio Reviewed By: #dolphin, markg, emateli, elvisangelaccio Subscribers: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D8454
2017-09-21Select child folder when navigating to a parent folderGregor Mi
Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view. REVIEW: 123253 BUG: 377392 CCBUG: 335616
2017-07-27Fix drop menu position with urlnavigator dropsElvis Angelaccio
Commit 1e251d2f6a in kio broke drop menus when dropping on the URL navigator (menus show up in the DolphinView rather than the URL bar). This happens because in DolphinView::dropUrls() we set `this` as the widget passed to KJobWidgets::setWindow() (in DragAndDropHelper::dropUrls()). We need to replace `this` with the actual widget that received the QDropEvent and that can mapToGlobal() the relative pos of the drop event. Unfortunately this widget is not KUrlNavigator itself, but one of its KUrlNavigatorButton children (private class, not exported). So unfortunately we need a new API in KIO that exposes this child widget. Differential Revision: https://phabricator.kde.org/D6684
2017-03-12Revert "Make "show filter bar" a toggle action"Sergey Kalinichev
This reverts commit edf8e5737316204e4a96e5edf4cba4cdec1c71ef. See https://git.reviewboard.kde.org/r/129662 for discussion
2017-02-18Make "show filter bar" a toggle actionDon Nguyen
REVIEW: 129662
2017-02-18Restore the view state after the URL of the DolphinView has been changed,Emmanuel Pescosta
as stated in the documentation of KUrlNavigator::saveLocationState. The historyChanged signal of the KUrlNavigator is emitted before the urlChanged signal and so the view state restoring happens before the view URL has been changed. This makes it impossible to save and restore the selected URLs, because DolphinView::setUrl clears the list of selected items (which has been restored right before). This changes removes the history changed slot and restores the view state after the setUrl call.
2017-01-16In doubt use URL scheme for placeKai Uwe Broulik
If we neither have a filename nor a host, we might be in a foo:/ URL, use the scheme then. Differential Revision: https://phabricator.kde.org/D3935
2016-10-04Hide message widgets only when reloading the viewElvis Angelaccio
Otherwise an error message might be hidden before it's even shown. BUG: 357651 FIXED-IN: 16.08.2 REVIEW: 129061
2016-06-25add_definitions(-DQT_NO_URL_CAST_FROM_STRING) + fix compilationDavid Faure
This fixes some URLs built from local paths without scheme.
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-10-21Allow home directories with non-local file paths.Emmanuel Pescosta
Paths like file:/home/me work now instead of showing an error message. BUG: 352743 BUG: 353550 FIXED-IN: 15.08.3 REVIEW: 125586
2015-01-05Dolphin: port from KonqOperations::doDrop to the new KIO::DropJobDavid Faure
REVIEW: 121678
2014-12-14port away from deprecated KFileItem(mode_t mode, mode_t permissions, const ↵Emmanuel Pescosta
QUrl &url, bool delayedMimeTypes = false);
2014-11-02Many cleanups in KonqOperationsDavid Faure
2014-11-01Enable KRun's script execution prompt.Arjun AK
This commit enables KRun's script/desktop file execution prompts, which is shown when the user launches an executable script or a desktop file. This is done so as to prevent the user from accidentaly executing programs. A checkbox to enable or disable the prompts is also being added to the preferences window REVIEW: 120171 BUG: 275405
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-09-11Merge branch 'master' into frameworksEmmanuel Pescosta
2014-09-01Make it possible to open archives via the command lineFrank Reininghaus
This used to work before afcf8961f6666a912e0e6e5072a000837f7cf6aa (only if "Open archives as folder" was enabled in the settings though). The reason why this commit broke it is that the mime type of a file is not determined automatically any more before asking KProtocolManager::protocolForArchiveMimetype for the correct protocol, so the determination of the protocol may fail. Keeping the isMimeTypeKnown() check in DolphinView::openItemAsFolderUrl still makes sense, because it prevents GUI blocking if the user tries to open many files at the same time. Therefore, we now call determineMimeType() in DolphinViewContainer::slotUrlIsFileError(const KUrl&) and then try to determine the correct protocol and use it to open the archive in the view, rather than hoping that slotItemActivated(item) will do the right thing. BUG: 333078 REVIEW: 119877 FIXED-IN: 4.14.1
2014-08-22Merge branch 'master' into frameworksEmmanuel Pescosta
Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/dolphinmainwindow.h dolphin/src/dolphinrecenttabsmenu.cpp dolphin/src/dolphinviewcontainer.cpp kfind/CMakeLists.txt
2014-08-22Hide an already visible KMessageWidget message before showing a new oneArjun AK
1. Do some operation that causes the KMessageWidget to show an error message 2. Immediately Repeat the same action. The user has no way to know whether the error message is from the second operation or is a leftover from the first one. By hiding the widget first and then showing it using animatedShow(), the user can clearly see that a new message was generated. Also once the directory successfully loads, the widget should be hidden. BUG: 323077 FIXED-IN: 4.14.1 REVIEW: 119401
2014-08-13Port from KonqMimeData to KIO::isClipboardDataCut/setClipboardDataCutDavid Faure
2014-07-10Merge branch 'master' into frameworksEmmanuel Pescosta
Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/dolphinviewcontainer.cpp
2014-07-04Implemented DolphinTabPage class to encapsulate the split view handling from ↵Emmanuel Pescosta
DolphinMainWindow. The signal activeViewUrlChanged in DolphinTabPage is currently unused, but we need it later when we implement the tab widget and tab bar. DolphinTabPage has saveState/restoreState which are using a QByteArray instead of the KConfigGroup to be more generic. REVIEW: 118964
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-13Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Since the master branch had never been merged into frameworks since the creation of the frameworks branch, I had to fix a couple of merge conflicts and make another change in order to make it build - I hope I did not get anything wrong. We should probably merge master into frameworks on a regular basis from now on. CCMAIL:[email protected] Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/search/dolphinfacetswidget.cpp dolphin/src/statusbar/dolphinstatusbar.cpp dolphin/src/views/dolphinview.cpp
2014-05-05dolphin: convert the remaining code to Qt5 signal/slot syntaxAlex Richardson
Middle clicking on Forward/Backward/Home/etc. will no longer open a new tab since the QAction triggered signal no longer tell us which mouse button was pressed
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2014-03-28When you open a new tab while the search mode is enabled, theEmmanuel Pescosta
newly opened tab also starts the same search (Because new tab is opened with the current view url), but the search box is in read-only mode. So you cannot close the search bar nor edit the search text. This patch fixes this by parsing the search url. The value of the "search" parameter is used as search text and the value of the "url" parameter is used for the search path ("root" folder for the search when "Search from here" mode is enabled). In case of Baloo search urls, we use Baloo::Query::fromSearchUrl. Removed everything related to read only mode in DolphinSearchBox, not needed anymore. REVIEW: 111968 BUG: 311950 FIXED-IN: 4.13.0
2014-02-06Port Dolphin to BalooVishesh Handa
Nepomuk is being replaced with Baloo
2013-10-26Merge remote-tracking branch 'origin/KDE/4.11'Frank Reininghaus
2013-10-26Fix broken view state restorationFrank Reininghaus
The fix for bug 161385 (which was about Dolphin still showing an empty view if a device that had been unmounted earlier was clicked in the Places Panel) caused a regression: the view state (current item, scroll position, Details View expansion state) was not restored any more when going "Back". The reason is that "m_view->reload()" in DolphinViewContainer::setUrl(const KUrl& newUrl) was always executed just after entering a directory, and that command overwrites this information. Distinguishing between "change URL" and "reload the view" works better if it's done in DolphinMainWindow instead of DolphinViewContainer. BUG: 326039 FIXED-IN: 4.11.3 REVIEW: 113290
2013-10-07Merge remote-tracking branch 'origin/KDE/4.11'Frank Reininghaus
2013-10-07Reload the view if a previously unmounted device is mounted againFrank Reininghaus
The problem was that DolphinViewContainer::setUrl(newUrl) was ignored if newUrl is equal to the URL which is shown in the view already. The new approach is to reload the view in that method if it is empty, to make sure that we do not miss that a previously unmounted device has been re-mounted. Thanks to Grigoriadis Grigoris for analyzing the root cause of this issue! BUG: 161385 FIXED-IN: 4.11.3
2013-09-09Merge remote-tracking branch 'origin/KDE/4.11'Frank Reininghaus
The most recent commit from the KDE/4.11 branch (new unit test) had to be modified slightly due to the changed signal emission when resorting the model changes only the groups, and not the order of the items (groupsChaged instead of itemsMoved).
2013-09-05Fix Bug 296970 - split view wrong behavior with search tabEmmanuel Pescosta
Implemented setActive(bool active), isActive() and activated() signal for DolphinSearchBox - similar to the KUrlNavigator implementation. BUG: 296970 FIXED-IN: 4.11.2 REVIEW: 112534
2013-08-18dolphin: Show full KFileItem statusbar text with hovered folders tooFabio D'Urso
This patch changes the status bar text dolphin shows when a folder is hovered. It now shows full folder info, eg: "mydir (folder, symlink to /opt/mydir") instead of: "mydir" This is consistent with dolphin's behavior on regular files, and DolphinPart already does that (DolphinPart::slotRequestItemInfo has no special cases for folders). CCBUG: 260717 REVIEW: 112106
2013-07-02Fix crash when dropping URLs on the URL navigator's drop down menusFrank Reininghaus
The problem was that the files were copied/moved inside the nested event loop of the drag, which caused problems if the "File exists" dialog was shown. The solution is to make the copy/move operation delayed, such that it is executed in the main event loop. Note that dropping files on these menus does apparently not work at the moment when using the Oxygen style (see bug 310016). BUG: 192139 BUG: 256338 BUG: 293220 BUG: 309076 FIXED-IN: 4.11.0 REVIEW: 111273
2013-06-04Bug 196035 - middle clicking on archive files in dolphin does not open them ↵Emmanuel Pescosta
in a new tab When 'browse through archives' is enabled, open archive files like folders on middle clicking, context menu -> new tab action and context menu -> new window action. BUG: 196035 REVIEW: 110487
2013-05-22Filter bar: add a button that prevents clearing if the URL changesStuart Citrin
FEATURE: 256651 FIXED-IN: 4.11.0 REVIEW: 107392
2013-05-12Hide the message widget when the URL changesFrank Reininghaus
Most error messages are only relevant when trying to open a URL, e.g., they inform the user that opening the URL failed. After the next successful URL change, these errors are not relevant any more. Therefore, it makes sense to hide the message widget automatically to prevent that the user is forced to close it manually. BUG: 312872 FIXED-IN: 4.11.0 REVIEW: 110369
2013-03-07Remove duplicated slotFrank Reininghaus
The slot DolphinViewContainer::focusView(), introduced in commit 2f0114730d1f5c3dfaee833300168b8e16b068f2, is actually unnecessary because DolphinViewContainer::requestFocus() provides the same functionality already.
2013-02-19Return the focus from the filter bar to the view if Enter is pressedJens Rutschmann
BUG: 297140 FIXED-IN: 4.11.0 REVIEW: 109020
generated by cgit v1.3 (git 2.53.0) at 2026-04-18 11:49:53 +0000