┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/kitemviews/kstandarditemlistwidget.cpp
AgeCommit message (Collapse)Author
2012-09-24Revert part of 20b0cb68bf5cc1099fd6e61982817d9e2ae0130cFrank Reininghaus
That commit, which disregarded roles with empty text for the row number calculation in Icons View, caused the problem that icons might jump around while information was retrieved asynchronously because previously empty roles could get a non-empty value, and the corresponding items would need an additional row in the view. Thanks to Hrvoje Senjan for testing this feature in master and reporting this issue early, such that we could fix it quickly and prevent that other users suffer from this bug! CCBUG: 304752
2012-09-21Merge branch 'KDE/4.9'Luca Beltrame
Conflicts: konq-plugins/dirfilter/dirfilterplugin.cpp konq-plugins/dirfilter/dirfilterplugin.h
2012-09-11Fix possible crash in KStandardItemListWidget::paint()Frank Reininghaus
According to the backtrace in the bug report, it is possible that KStandardItemListWidget::paint() is called if the hash m_textInfo has not been initialised. The widget's index must be -1 in this case, see KStandardItemListWidget::triggerCacheRefreshing(). It looks like this can only happen if the item is about to be removed from the view, see KItemListView::slotItemsRemoved(). I could not reproduce the crash, so I'm not sure why exactly this happens, but this commit should at least prevent the crash. BUG: 306167 FIXED-IN: 4.9.2
2012-09-06Do not show '-' for additional info which is not available for an itemFrank Reininghaus
Thanks to Todd Jennings for the patch! CCBUG: 304752 REVIEW: 106304
2012-08-24Do not crash when finishing inline renaming in unusual waysFrank Reininghaus
The crash was caused by a null pointer dereference when, e.g., minimizing Dolphin. The root cause was that KStandardItemListWidget::closeRoleEditor() was called twice: once when the role editor loses focus, and once again when the window is resized. After m_roleEditor was set to 0, the second call dereferenced this null pointer. I think the best solution is to disconnect from the role editor's signals when the editor is not needed any more by the KStandardItemListWidget. CCBUG: 304524 (cherry picked from commit a9c2bdc3b53955693e716bbab58c318fe25bdc9b)
2012-08-24Do not crash when finishing inline renaming in unusual waysFrank Reininghaus
The crash was caused by a null pointer dereference when, e.g., minimizing Dolphin. The root cause was that KStandardItemListWidget::closeRoleEditor() was called twice: once when the role editor loses focus, and once again when the window is resized. After m_roleEditor was set to 0, the second call dereferenced this null pointer. I think the best solution is to disconnect from the role editor's signals when the editor is not needed any more by the KStandardItemListWidget. BUG: 304524 FIXED-IN: 4.9.1
2012-08-15Fix wrong text color in Places Group Header. Use QPalette::Window for base ↵Emmanuel Pescosta
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient. BUG: 303133 FIXED-IN: 4.9.1 (cherry picked from commit b3c3da985159a9627c079ad615cd77fc5f7bb72a)
2012-08-14Fix wrong text color in Places Group Header. Use QPalette::Window for base ↵Emmanuel Pescosta
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient. BUG: 303133
2012-08-13Fix bug 303375 - Dots in directory names treated as file extension.David Faure
Patch by Emmanuel Pescosta <[email protected]> BUG: 303375 REVIEW: 105575 FIXED-IN: 4.9.0
2012-08-13Fix wrong text color in places and in folders panel.Emmanuel Pescosta
FIXED-IN: 4.9.1 REVIEW: 105832 BUG: 303133
2012-08-13Fix wrong text color in places and in folders panel.Emmanuel Pescosta
FIXED-IN: 4.9.1 REVIEW: 105832 BUG: 303133
2012-08-07Fix the size of the rating stars in Icons ViewFrank Reininghaus
Moreover, make sure that the selection rectangle is large enough to include the stars. Patch by Emmanuel Pescosta. Thanks for the patch! CCBUG: 302624 REVIEW: 105830 (cherry picked from commit 146c77eaa226915cd3cd01e112fcde42fd8c06c4)
2012-08-07Fix the size of the rating stars in Icons ViewFrank Reininghaus
Moreover, make sure that the selection rectangle is large enough to include the stars. Patch by Emmanuel Pescosta. Thanks for the patch! BUG: 302624 FIXED-IN: 4.9.1 REVIEW: 105830
2012-07-20Fix bug 303375 - Dots in directory names treated as file extension.David Faure
Patch by Emmanuel Pescosta <[email protected]> BUG: 303375 REVIEW: 105575 FIXED-IN: 4.9.0
2012-06-16Renaming: Don't select unknown extensionsPeter Penz
If a file with an unknown extension gets renamed, it is assumed that the letters after the last point represent the extension and won't be selected. BUG: 301893 FIXED-IN: 4.9.0
2012-06-12Drag-pixmap fixesPeter Penz
- Don't use the selection-tinted icon when dragging a single item - Decrease the vertical gap for the hotspot - Prevent drawing tree-lines when dragging items for the Places Panel CCBUG: 301624
2012-06-09Inline renaming: ESC should cancel the renamingPeter Penz
When emitting the roleEditingCanceled-signal it must be prevented that a roleEditingFinished-signal is emitted because of some action taken in the receiver-slot. BUG: 301480 FIXED-IN: 4.9.0
2012-06-08Inline renaming: Improve focus handlingPeter Penz
Fix issue that cancelling the inline-renaming by clicking on the other split view applies the wrong focus. Thanks to Frank Reininghaus for the initial patch and noticing this issue. CCBUG: 301252
2012-06-08Inline renaming fixesPeter Penz
- Don't use an outdated KFileItem when renaming an item more than once - Use the same font as the view - Don't lose the focus when an editor-popup is shown BUG: 299327 BUG: 298883 BUG: 301253 FIXED-IN: 4.9.0
2012-05-26Use an italic font for symbolic linksFrank Reininghaus
BUG: 298218 FIXED-IN: 4.9.0
2012-05-21Colorize icons when an item is selectedPeter Penz
BUG: 295515 FIXED-IN: 4.9.0
2012-05-18Enable basic drag and drop support for the Places PanelPeter Penz
The dropping has not been implemented yet, however in the context of this step the creating of the drag-pixmap is now forwarded to the item-widgets. This allows creating some optimized dragging-pixmaps e.g. for the details-view, where only the name and icon should be provided as drag-pixmap.
2012-05-02Places Panel: Allow showing of hidden itemsPeter Penz
2012-05-01Places Panel: Allow hiding of itemsPeter Penz
Related changes: - Animate changed items for the details-view in case it is not expandable - Remove the hardcoded "isHidden"-code in KStandardItemListWidget and allow derived widgets to define themselves what means "hidden" within their context. The current code needs a lot of bugfixing, but lets make this in smaller steps during the next days...
2012-04-23Details mode: Fix wrong required column-width calculationPeter Penz
BUG: 298577 FIXED-IN: 4.9.0
2012-04-21Bring back basic bookmark support for the Places PanelPeter Penz
The folders-panel signals have been adjusted too for consistency.
2012-04-21Prepare view-engine for non-KFileItem usecasePeter Penz
Up to now the view-engine only provided a model-implementation that supports file-items. The view-engine always had been designed to be able to work with any kind of model, so now a KStandardItemModel is available. The plan is to convert the places panel to the new view-engine. It should be no problem to fix this until the feature freeze - in the worst case the places-panel code could be reverted while still keeping the KStandardItemModel changes.
generated by cgit v1.3 (git 2.53.0) at 2026-04-20 20:04:45 +0000