┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/kitemviews/private
AgeCommit message (Collapse)Author
2017-09-12Qt 5 Porting: Q_WS_WIN -> Q_OS_WINBen Cooksley
(cherry picked from commit 4c1df50d522a09577274e19a8fe66bd865f3a2da)
2017-05-31Revert "Increase smooth scrolling animation duration from 100 to 300 ms and ↵Elvis Angelaccio
set easing curve to InOutQuart" This reverts commit 58c5eae1953bbdcf6d4150b21cb7ffdad07a5257. Reasons against this change: 1. Scroll is now too fast with devices such as touchpads or trackpoints. 2. Scroll behavior is now inconsistent between Dolphin and other applications (e.g. the Plasma file dialog). Breeze's default animation duration is 100 ms. 3. Many people complained and this feature is currently not configurable. We should introduce a QStyle::SH_Widget_Animation_Duration hint that would allow us to not hardcode durations in Dolphin (i.e. respect whatever duration the users set in their QStyle). Proposal in https://codereview.qt-project.org/#/c/195712/ Reviewers: #vdg, #plasma, emmanuelp, davidedmundson Reviewed By: #plasma, davidedmundson Differential Revision: https://phabricator.kde.org/D5883
2017-04-29Sort the tag-values alphabetically in the "Tags" columnAthanasios Kanellopoulos
Up until now tag-values have appeared unsorted in the Tags column when the selected View Mode is "Details". In older versions of Dolphin (in KDE4) the tags-values were alphabetically sorted in the Tags column, which means that back then this was the desired behavior. This commit restores this functionality. BUG: 377589 FIXED-IN: 17.04.1 REVIEW: 130068
2017-02-26Increase smooth scrolling animation duration from 100 to 300 ms and set ↵Vishal Rao
easing curve to InOutQuart Summary: The current animation duration for smooth scrolling is 100 ms which feels as if there is no smooth scroll animation in the first place. Bumping this up to something like 300 ms seems to make the scrolling actually appear smooth. Also, based on diff comments the easing curve is set to InOutQuart. Test Plan: Built this change locally and tried scrolling a folder with many items both single step mouse wheel and also larger steps of the mouse wheel. Reviewers: elvisangelaccio, emmanuelp Reviewed By: emmanuelp Subscribers: htietze, colomar, andreask, emmanuelp, elvisangelaccio Differential Revision: https://phabricator.kde.org/D4560
2017-01-21Merge remote-tracking branch 'origin/Applications/16.12'Albert Astals Cid
2017-01-21Fix missing audio duration in details viewMarc André Wittorf
Enabling the 'duration' column in a folder with audio files did only show empty information. Properly initializing the QTime object fixes this. Testing Done Find a folder with audio files Make sure that Baloo has indexed this folder Open this folder in Dolphin, detail view, enable the Audio/Duration column Unpatched Dolphin does not display audio duration, patched Dolphin does Tested on Gentoo x86_64 with Qt 5.5.1, KF 5.21.0 and Arch x86_64 with Qt 5.6.0 and KF 5.21.0. REVIEW: 127799
2017-01-12Add document title to additional informationKai Uwe Broulik
Allows showing the document title of e.g. a PDF alongside the file name BUG: 321356 Differential Revision: https://phabricator.kde.org/D3972
2017-01-03Add missing Q_DECL_OVERRIDEMontel Laurent
2016-11-20Fix slow scrolling in dock panelsElvis Angelaccio
Commit f688bcd1f1 fixed slow scrolling with xf86-input-libinput on DolphinView. However the commit also exposed a bug in the Dolphin scrolling algorithm, which was previously hidden. This resulted in slow scrolling in dock panels (Places and Folders), with both xf86-input-evdev and xf86-input-libinput drivers, as well as libinput on Wayland. KItemListContainer::updateScrollOffsetScrollBar() relied on the view's itemSize() method to compute the scrollbar's singleStep, but this QSize was invalid for the dock panels' views. We use a new itemSizeHint() method instead, which is always valid and also adapts to the current icon size set in the view. BUG: 365968 FIXED-IN: 16.12.0 REVIEW: 129409
2016-08-06Fix some low-hanging warning fruitsMartin T. H. Sandsmark
2016-07-16Fix scrolling on hidpi screensMartin T. H. Sandsmark
Scrolling with libinput was unbearably slow. QScrollBar is much better at scrolling than us, so let it handle it. REVIEW: 128432 BUG: 357618
2016-04-09Selection toggle: Use emblem-remove and emblem-added icons from BreezeEmmanuel Pescosta
This raises the minimum KF5 version to 5.21.0 BUG: 357587 FIXED-IN: 16.08.0 REVIEW: 127400 CCMAIL: [email protected]
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2016-02-09Support KFileMetadata OriginUrl as "Downloaded From"Kai Uwe Broulik
This brings back the functionality to show where a file originally was downloaded from using xattr originUrl. REVIEW: 126927
2016-01-12Take into account QApplication::wheelScrollLines() in wheel eventsMarco Martin
when setting a different "mouse wheel scrolls by" value in the mouse kcm, the user expects every view to scroll more or less accordingly (even if it's not strictlya text view) This makes the scroll in dolphin take that into account REVIEW:126718
2015-09-03Merge branch 'Applications/15.08'Frank Reininghaus
2015-09-03Only store modified columns widths after the mouse button was releasedFrank Reininghaus
This prevents that the new widths are written to disk multiple times in quick succession, which can make column resizing quite slow. BUG: 351846 REVIEW: 351846 FIXED-IN: 15.08.1
2015-09-01Scrolling fixes for DolphinMaxim Mikityanskiy
KItemListSmoothScroller::handleWheelEvent has some issues: 1. When I scroll file list holding mouse over the list, one mouse wheel tick corresponds to 1/4 page interval, but when I hover on QScrollBar, one wheel tick corresponds to 1 page interval. 2. In KItemListSmoothScroller::eventFilter we don't return true, so that QScrollBar also handles this event, and total scroll interval is m_scrollBar->pageStep() + m_scrollBar->singleStep(). 3. When I use touchpad that supports smooth scrolling via XInput2, and I hover it over QScrollBar, I can only scroll content if I move my fingers very fast, because numSteps = event->delta() / 8 / 15 is just zero unless I move very fast (event->delta() in this case is less than 120). 4. Holding Shift while scrolling has no effect when holding mouse over QScrollBar in contrast to scrolling faster when holding mouse over file list. The patch eliminates all these issues making the behavior of KItemListSmoothScroller the same as in KItemListContainer::wheelEvent, adding support for QWheelEvent::pixelDelta() and removing usage of deprecated QWheelEvent::delta(). REVIEW: 124670 FIXED-IN: 15.12.0
2015-05-07Fix KFileItemModel performance regressionFrank Reininghaus
Commit 119f7a3f fixed a crash that was caused by the porting of the natural sorting code to QCollator. QCollator is not thread-safe, so every thread needs its own instance. However, that commit made every recursive call in the sorting code create a new deep-copied QCollator instance, which is quite expensive and thus made inserting any items into the model very slow (this could also be seen in the KFileItemModel benchmark). This commit avoids unnecessary QCollator copying by forcing all sorting functions which are called in the same thread to pass the 'lessThan' object by const reference, such that no unnecessary copying of that object, including a deep copy of the QCollator, takes place. REVIEW: 123620
2015-03-31Remove deprecated X scaling of QPixmapsDavid Edmundson
QPixmaps are no longer X pixmaps so this won't ever work anymore REVIEW: 123138
2015-03-30Merge branch 'davidedmundson/highdpi'David Edmundson
REVIEW: 123137
2015-03-27review commentsDavid Edmundson
2015-03-26Make KPixmapModifier::applyFrame handle high DPI imagesDavid Edmundson
2015-03-25Copy device pixel ratio from original pixmap inside KPixmapModifier::scaleDavid Edmundson
2015-03-19Fix some EBN issuesYuri Chornoivan
2015-02-25Move the KVersionControlPlugin2 interface from konqlib to Dolphin and remove ↵Emmanuel Pescosta
the deprecated KVersionControlPlugin interface from konqlib REVIEW: 122687
2015-02-24Replace kDebug/kWarning by categorized logging (org.kde.dolphin)Emmanuel Pescosta
2015-02-24Removed unused KGlobal includes and use KIO/Job instead of KIO/JobClassesEmmanuel Pescosta
2015-02-06kdelibs4support--Montel Laurent
2015-02-06Fix includesMontel Laurent
2015-01-30Port away from KGlobalSettings::graphicEffectsLevel()Emmanuel Pescosta
REVIEW: 122309
2015-01-28Merge branch 'Applications/14.12' into frameworksEmmanuel Pescosta
Conflicts: dolphin/src/main.cpp kdepasswd/kcm/kcm_useraccount.desktop konqueror/settings/ebrowsing/ebrowsing.desktop konqueror/settings/kio/cache.desktop konqueror/settings/kio/cookies.desktop konqueror/settings/kio/netpref.desktop konqueror/settings/kio/proxy.desktop konqueror/settings/kio/smb.desktop konqueror/settings/kio/uasproviders/firefox30oncurrent.desktop konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop konqueror/settings/kio/useragent.desktop lib/konq/konq_operations.cpp
2014-11-20Fix Exports.Andrius da Costa Ribas
REVIEW: 121078
2014-11-09Ensure input is a valid regexp before enabling regexp filter modeArjun AK
Checking whether the input contains '*', '?' or '[' alone will not do since there can be files with '[' in their name. REVIEW: 120986 BUG: 340470 FIXED-IN: 14.12
2014-10-27Port to QDebug*. KVBox--Montel Laurent
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-14Port Dolphin to the new Baloo APIsVishesh Handa
REVIEW: 120582
2014-10-10Clean includes + port to QMenuMontel Laurent
2014-07-31Clean up KAction leftovers.Arnold Dumas
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-06-27Fix build.Christophe Giboudeaux
2014-06-20kde-baseapps frameworks dolphin with snapshot frameworks branch ↵Scarlett Clark
baloo/baloo-widgets path fixes.
2014-06-12Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Conflicts: dolphin/src/dolphincontextmenu.cpp dolphin/src/panels/folders/treeviewcontextmenu.cpp
2014-06-12Do not crash if QApplication::clipboard()->mimeData() is a null pointerFrank Reininghaus
This removes the remaining unchecked accesses to the clipboard mime data after commit 7828b057da0491f1b08bfaec681067e195d7b6ca. According to a bug report, it can be a null pointer on Wayland. BUG: 335053 REVIEW: 118649
2014-06-05Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
2014-06-05Separate width and height info in the layouting codeFrank Reininghaus
By separating the width and height info, we can save some unnecessary overhead in terms of memory and CPU cycles, and make the calculation of the height of a row (or the width of a column in Compact View) a bit simpler. To achieve this, this patch extends the concept of "logical rows" (which are actually columns in Compact View) to "logical width" and "logical height" (which is the actual height and width, respectively, in Compact View). The distinction between rows/columns and "logical" rows/columns may be a bit confusing, but the confusion is already in the current code, and I hope that it will be mitigated a bit by prefixing the corresponding variables with "logical". REVIEW: 118454
2014-05-13Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Since the master branch had never been merged into frameworks since the creation of the frameworks branch, I had to fix a couple of merge conflicts and make another change in order to make it build - I hope I did not get anything wrong. We should probably merge master into frameworks on a regular basis from now on. CCMAIL:[email protected] Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/search/dolphinfacetswidget.cpp dolphin/src/statusbar/dolphinstatusbar.cpp dolphin/src/views/dolphinview.cpp
2014-05-05dolphin: convert kitemviews/ to qt5 signal slot syntaxAlex Richardson
This conversion was performed automatically using convert2qt5signalslot. The only manual changes required were changing the overloaded signal KDirLister::redirection and KDirLister::completed from KUrl to QUrl. All other cases were no problem since these signals are not overloaded and a static_cast for disambiguation is not necessary. Code inside HAVE_BALOO is not converted yet, will do that once I can build a version with Baloo.