┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/kitemviews/private
AgeCommit message (Collapse)Author
2013-06-20Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-20Make it possible to select files like "a_b" using keyboard searchFrank Reininghaus
The problem was that pressing the Shift key would reset the keyboard search. BUG: 321286 FIXED-IN: 4.11.0 REVIEW: 111102
2013-06-20Prevent the selection rectangle from being reduced to 0pxEmmanuel Pescosta
width or 0px height, so the selected items can not be accidently unselected when the rectangle width/height becomes 0px. BUG: 320897 REVIEW: 111144 FIXED-IN: 4.10.5
2013-06-10Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-10Do not rename files unexpectedly when changing the URLFrank Reininghaus
If the role editor loses focus, it considers the current renaming operation finished, and tells DolphinView to rename the file. This is a problem when changing the directory, because the URL change happens before DolphinView receives the signal, which results in a file in the new directory being renamed unexpectedly. The solution is to establish the connection to the slotRoleEditingFinished signal only when the "rename inline" editor is opened, and disconnect it when renaming is finished or canceled or the URL changes. BUG: 319912 FIXED-IN: 4.10.5 REVIEW: 110908
2013-04-23Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
Conflicts: plasma/applets/folderview/folderview.cpp CCMAIL: [email protected] @Ignat: We've been following a merge-based approach in kde-baseapps for quite some time now, see http://lists.kde.org/?t=134744909400005&r=1&w=1 It would be nice if you could merge KDE/4.10 into master after any non-trivial changes in folderview to prevent that others have to figure out how to resolve the merge conflicts. Thanks!
2013-04-23Disable Find/Replace in the "rename inline" line editFrank Reininghaus
These actions do not work correctly because renaming is considered finished as soon as the line edit loses focus, which happens when the "Replace" dialog pops up. BUG: 317772 FIXED-IN: 4.10.3
2013-01-15Remove incorrect comments about the sorting functionsFrank Reininghaus
In fact, we could use the sorting functions provided by Qt or the STL. The reason why we have our own is that we want to support parallel sorting because sorting many items naturally by name can be expensive.
2013-01-15Re-organise the sorting codeFrank Reininghaus
The KFileItemModel-specific parts are now separated from the generic ones, like the parallel sorting implementation. REVIEW: 108386
2013-01-15Change the sort and merge functions to a more generic form.Frank Reininghaus
This might make it easier to reuse the parallel sorting code. Moreover, some the upperBound/lowerBound functions have been removed because equivalents are provided by the STL.
2013-01-15Use std::rotate, rather than reversing three timesFrank Reininghaus
We need less code now, and moreover, the STL implementation of rotate should be more efficient than three reverse() calls.
2013-01-11Only use parallel sorting when sorting by nameFrank Reininghaus
The reentrant natural comparison of strings is the only really expensive operation. Other comparison functions are much cheaper and might not be reentrant at all. Therefore, we disable parallel sorting when not sorting by name to prevent crashes and other unpleasant behaviour. BUG: 312679 FIXED-IN: 4.10 REVIEW: 108309
2013-01-09Show the real audio file duration in additional informationsEmmanuel Pescosta
Big Thanks to Frank Reininghaus and Vishesh Handa! BUG: 311794 REVIEW: 108281 FIXED-IN: 4.10
2012-12-13Merge remote-tracking branch 'origin/KDE/4.9'Frank Reininghaus
2012-12-12Fix Bug 240820 - [Usability Bug] Handling Bad Filenames, dolphin gives ↵Emmanuel Pescosta
unclear error message Fix Bug 308597 - Regression: Renaming a file/folder to something that contains a "/" will result in several message boxes Uses the same solution as Dolphin-Rename-Dialog does. (KIO::encodeFileName) BUG: 240820 BUG: 308597 REVIEW: 107681 FIXED-IN: 4.9.5
2012-12-07Merge remote-tracking branch 'origin/KDE/4.9'Frank Reininghaus
2012-12-07Fix keyboard focus handling after renaming items inlineFrank Reininghaus
This reverts 951cb9c35d7a9ef814b3de5b359915968da9b881 and 3143acc084d54d43df469b54762bfa10a7050a9f, and fixes the crash caused by nested event loops by delaying the deletion of the KItemListRoleEditor until the next item is renamed inline. BUG: 311206 FIXED-IN: 4.9.5 REVIEW: 107606
2012-11-25Merge remote-tracking branch 'origin/KDE/4.9'Frank Reininghaus
2012-11-25Fix regression caused by 4120805872c2e9fac909a403b83221c09c9110a2Frank Reininghaus
Copied items should not be shown in gray. Thanks to Christoph Feck for testing and reporting this regression! CCBUG: 304615 CCMAIL: [email protected]
2012-11-24Merge remote-tracking branch 'origin/KDE/4.9'Frank Reininghaus
2012-11-24Update the 'isCut' state of items when cutting non-files, e.g., textFrank Reininghaus
BUG: 304615 FIXED-IN: 4.9.4 REVIEW: 107390
2012-11-10Merge remote-tracking branch 'origin/KDE/4.9'Dawit Alemayehu
2012-11-09Fix Bug 309760 - Crash while inline-renaming a file and apply change with ↵Emmanuel Pescosta
return-key BUG: 309760 FIXED-IN: 4.9.4
2012-11-05Merge remote-tracking branch 'origin/KDE/4.9'Frank Reininghaus
2012-11-05Prevent crashes caused by nested event loops run when renaming inlineFrank Reininghaus
When renaming inline and starting a drag or invoking the context menu, a nested event loop will be run. If the role editor loses focus and emits roleEditingFinished(), we must prevent that deleteLater() is called because this would delete the role editor inside a nested event loop which is run from one of its own functions. We would get a crash when returning from that event loop otherwise. BUG: 308018 BUG: 309421 FIXED-IN: 4.9.4
2012-10-28Fix wrong function call in KFileItemModelSortAlgorithm::sequentialSort (Bug ↵Emmanuel Pescosta
introduced in commit 429218eaf22c1bde24ba6875895c33facfa6ae12)
2012-10-28Implemented multithreading in KFileItemModelSortAlgorithm. Use as many ↵Emmanuel Pescosta
threads as possible. Thanks to Frank Reininghaus for all his suggestions. REVIEW: 107025
2012-10-15Port Dolphin from Nepomuk to Nepomuk2 according to the Nepomuk2Port mini ↵Emmanuel Pescosta
guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port REVIEW: 106825
2012-09-22Merge branch for accessibilityAmandeep Singh
2012-09-06Do not show '-' for additional info which is not available for an itemFrank Reininghaus
I'm only backporting the removal of the '-', not the update for the line number calculation in Icons View, because this is the safest part of the patch and also the one that fixes the most annoying part of the bug. Thanks to Todd Jennings for the patch! BUG: 304752 REVIEW: 106304 (cherry picked from commit 20b0cb68bf5cc1099fd6e61982817d9e2ae0130c)
2012-09-06Do not show '-' for additional info which is not available for an itemFrank Reininghaus
Thanks to Todd Jennings for the patch! CCBUG: 304752 REVIEW: 106304
2012-09-05Implemented the new KParts' listing filter extension, ↵Dawit Alemayehu
KParts::ListingFilterExtension. REVIEW: 106289 (cherry picked from commit cb79ee6a881e2b4418bccc22480e3e269e5b0af9)
2012-09-05Implemented the new KParts' listing filter extension, ↵Dawit Alemayehu
KParts::ListingFilterExtension. REVIEW: 106289
2012-08-14Adding the Accessibility classesAmandeep Singh
2012-06-13Fix regression: Open file if entering it in the URL-navigatorPeter Penz
The regression has been introduced when hiding the DolphinDirLister inside KFileItemModel. Now the signal urlIsFileError() gets forwarded to the container again where the file will be opened. BUG: 301757 FIXED-IN: 4.9.0
2012-06-09Inline renaming: ESC should cancel the renamingPeter Penz
When emitting the roleEditingCanceled-signal it must be prevented that a roleEditingFinished-signal is emitted because of some action taken in the receiver-slot. BUG: 301480 FIXED-IN: 4.9.0
2012-06-08Krazy fixesPeter Penz
2012-06-08Inline renaming fixesPeter Penz
- Don't use an outdated KFileItem when renaming an item more than once - Use the same font as the view - Don't lose the focus when an editor-popup is shown BUG: 299327 BUG: 298883 BUG: 301253 FIXED-IN: 4.9.0
2012-05-06Remove kde-runtime dependency "nepomukdatamanagement"Peter Penz
Follow the suggestion from Vishesh Handa and copy the ResourceWatcher code from kde-runtime instead of creating a dependency. This will of course get removed again as soon as Nepomuk's resource watcher will get a public API.
2012-05-06Show "duration" in the format hh::mm::ssPeter Penz
2012-04-26Reset to ascending sort order when changing the columnPeter Penz
When changing the sort-column the sort order should always be reset to 'ascending' to by consistent with the QListView behavior. BUG: 298830 FIXED-IN: 4.9.0
2012-04-25Provide correct labels for Nepomuk resourcesPeter Penz
2012-04-25When the current item is removed, make -1 the current index temporarilyFrank Reininghaus
This fixes two problems: 1. KItemListKeyboardSearchManger can cancel the current search when a new folder is opened (note that this action removes the current item from the view). 2. The view can underline the new current item (which is the item that used to be below the removed item). Note that this did not work before because the view did not receive a currentChanged() signal in this case and therefore did not update the "current item" status of the new current item. CCBUG: 297488 CCBUG: 298782 REVIEW: 104709 (cherry picked from commit 68ce395a192362969783615e50a8004d3029eb7e)
2012-04-25When Esc is pressed, clear the selection and cancel the keyboard searchFrank Reininghaus
This patch restores the Dolphin 1.x behaviour that Esc clears the selection (Dolphin 2.0 did not have an easy way to clear the selection using the keyboard so far). Moreover, Esc now also cancels the current keyboard search. This fixes the problem that the only way to cancel the search is to wait until the timeout has expired. CCBUG: 298742 CCBUG: 297458 (cherry picked from commit d3b1312d3edc615b03fb17c1a5fa62ccb61cdabd)
2012-04-25Reduce the timeout in KItemListKeyboardSearchManager to 1 secondFrank Reininghaus
It turned out that the longer timeout, introduced recently in 02eab49b2de51c31fe46a0d9501327b579b3648e, not only made multi-letter keyboard searches easier, but also had some unwanted side effects. I hope that 1 second, which is between the previous value of 5 seconds and the pre-KDE 4.8.2 value of 0.4 seconds, is a compromise which will fit most users' needs. We will try to improve the situation further in future releases by providing visual feedback about the keyboard search, but such a change would not be suitable for a bug-fix release. (cherry picked from commit d8732a59d3b1f2d0bebf43f294df7e9f333abde4)
2012-04-18Inline renaming fixesPeter Penz
- Increase the editor-height in the icons-view if required - Don't try to react on resizings of the parent, just finish the renaming
2012-04-17Documentation update for KItemListRoleEditorPeter Penz
2012-04-17Implement inline-renaming for the new view-enginePeter Penz
BUG: 286893 FIXED-IN: 4.9.0
2012-04-11Fix compile issue resulted by commit 2caff15bPeter Penz
2012-04-11KItemViews: Internal directory restructurationPeter Penz
- Move all private headers from the kitemviews-directory into the 'private' subdirectory. - Get rid of DolphinDirLister and just use a directory-lister internally in KFileItemModel. - Minor interface-cleanups for signals