┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/kitemviews
AgeCommit message (Collapse)Author
2012-09-29Find out the main window by calling the parent widget's window() memberFrank Reininghaus
KFileItemModel calls the dir lister's setMainWindow() method to make sure that the dir lister caches authentication data. However, the method used to determine the main window (qApp->activeWindow()) is not guaranteed to yield the DolphinMainWindow or the KonqMainWindow. In particular, if "Split View" is enabled in Dolphin's settings dialog, the active window is the dialog, and when it is closed, any later access to the stored pointer leads to a crash. A better method is to verify that the model's parent is a QWidget and then use this widget's window(). I had to make a small modification in DolphinMainWindow to make sure that it also works correctly when the view is split (the new view container had been created with a 0 parent previously). I tested it in Dolphin and Konqueror and verified that the "main window" passed to the dir lister is really the application's main window. BUG: 306459 FIXED-IN: 4.9.3
2012-09-28Redo the fix for CTRL+Tab not working when using Dolphin's filemanagement partDawit Alemayehu
in Konqueror. The original fix, commit 4f7ed2b, prevents drag and drop from working correctly. CCBUG: 302329 REVIEW: 106569
2012-09-26Fix a Bug in KFileItemModelRolesUpdate::setEnabledPlugins.Emmanuel Pescosta
Changes were never overtaken because of a wrong comparison. FIXED-IN: 4.9.2
2012-09-26Fixed CTRL+Tab not working when using Dolphin's filemanagement part in ↵Dawit Alemayehu
Konqueror. BUG: 302329 FIXED-IN: 4.9.2 REVIEW: 106569
2012-09-25Fixes Bug 305783 - dragging a file over a directory #c4Emmanuel Pescosta
does not expand the dir => Bug discovered: When you drag a item onto a folder-view-item and then move it away instantly before the autoactivation event is triggered (After 750ms), the folder will be opened anyway. BUG: 305783 REVIEW: 106381 FIXED-IN: 4.9.2 (cherry picked from commit 9ab8bcd6aa3ce5d96ee380d5f22d77c2f0a38881)
2012-09-24Fix crash when receiving Nepomuk info for a recently deleted file.Frank Reininghaus
BUG: 306036 FIXED-IN: 4.9.2
2012-09-20Restore old behavior: Navigating by double-clicking in folder panel ↵Emmanuel Pescosta
(Double-Click - show folder content and expand folder) BUG: 295573 REVIEW: 106497 FIXED-IN: 4.9.2
2012-09-19Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve originEmmanuel Pescosta
Patch 106381 Comment #3: When "Open folders during drag operations" is enabled, two things happen, both in the DolphinView and in the Folders Panel: 1) When hovering a folder that can be expanded (this is the case for folders with sub-folders in the Folders Panel and in the DolphinView if in Details View mode), toggle its "expanded" state. 2) When hovering a folder that can not be expanded (i.e., a folder without sub-folders or any folder in Icons or Compact View), open this folder in the DolphinView via the KItemListController's itemActivated(int) signal. The bug described in bug 293200 comment 3 is that 1) is always wanted, but 2) is not wanted for the Folders Panel. BUG: 293200 FIXED-IN: 4.9.2
2012-09-11Fix possible crash in KStandardItemListWidget::paint()Frank Reininghaus
According to the backtrace in the bug report, it is possible that KStandardItemListWidget::paint() is called if the hash m_textInfo has not been initialised. The widget's index must be -1 in this case, see KStandardItemListWidget::triggerCacheRefreshing(). It looks like this can only happen if the item is about to be removed from the view, see KItemListView::slotItemsRemoved(). I could not reproduce the crash, so I'm not sure why exactly this happens, but this commit should at least prevent the crash. BUG: 306167 FIXED-IN: 4.9.2
2012-09-07Implemented the new KParts extension, KParts::ListingiNotificationExtension.Dawit Alemayehu
REVIEW: 106333
2012-09-06Do not show '-' for additional info which is not available for an itemFrank Reininghaus
I'm only backporting the removal of the '-', not the update for the line number calculation in Icons View, because this is the safest part of the patch and also the one that fixes the most annoying part of the bug. Thanks to Todd Jennings for the patch! BUG: 304752 REVIEW: 106304 (cherry picked from commit 20b0cb68bf5cc1099fd6e61982817d9e2ae0130c)
2012-09-05Implemented the new KParts' listing filter extension, ↵Dawit Alemayehu
KParts::ListingFilterExtension. REVIEW: 106289
2012-08-24Do not crash when finishing inline renaming in unusual waysFrank Reininghaus
The crash was caused by a null pointer dereference when, e.g., minimizing Dolphin. The root cause was that KStandardItemListWidget::closeRoleEditor() was called twice: once when the role editor loses focus, and once again when the window is resized. After m_roleEditor was set to 0, the second call dereferenced this null pointer. I think the best solution is to disconnect from the role editor's signals when the editor is not needed any more by the KStandardItemListWidget. BUG: 304524 FIXED-IN: 4.9.1
2012-08-24Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menusFrank Reininghaus
For top-level roles like "Name" and "Size", the group translation is 0. In that case, the "group" member of the corresponding RoleInfo struct must be an empty string. This is expected by the code which generates Dolphin's menus, which group the top-level roles into a sub menu with the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c. Thanks to Christoph Feck for investigating this issue! CCBUG: 305228
2012-08-16Fix translations not showing in the Sort by and Additional Information submenusAlbert Astals Cid
Acked by Frank REVIEW: 106049 BUGS: 305228 FIXED-IN: 4.9.1
2012-08-15Fix wrong text color in Places Group Header. Use QPalette::Window for base ↵Emmanuel Pescosta
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient. BUG: 303133 FIXED-IN: 4.9.1 (cherry picked from commit b3c3da985159a9627c079ad615cd77fc5f7bb72a)
2012-08-13Fix wrong text color in places and in folders panel.Emmanuel Pescosta
FIXED-IN: 4.9.1 REVIEW: 105832 BUG: 303133
2012-08-07Fix the size of the rating stars in Icons ViewFrank Reininghaus
Moreover, make sure that the selection rectangle is large enough to include the stars. Patch by Emmanuel Pescosta. Thanks for the patch! BUG: 302624 FIXED-IN: 4.9.1 REVIEW: 105830
2012-08-06Stop preview jobs when closing DolphinFrank Reininghaus
Patch by Benni Hill. Thanks for the patch! BUG: 304467 FIXED-IN: 4.9.1
2012-07-29msvc needs to have the class definition for reference parameters in methodsPatrick Spendrin
2012-07-20Fix bug 303375 - Dots in directory names treated as file extension.David Faure
Patch by Emmanuel Pescosta <[email protected]> BUG: 303375 REVIEW: 105575 FIXED-IN: 4.9.0
2012-07-18Respect platform's icon sizesChristoph Feck
Use QStyle icon sizes instead of hard coding 16 or 32 pixels. Using styles that follow KDE settings (every KStyle, e.g. Oxygen) the icon sizes can be configured by the user in System Settings. The size for the icon/details view can be later changed by the user, overriding the defaults. The icon size for the places panel is not (yet?) configurable separately. (Not resolving the bug, see comment in review request) CCBUG: 301959 REVIEW: 105548 (cherry picked from commit 79211f6e48d33b6be235811912061fda265fefb6)
2012-07-12Re-implement dropping of files on folders in the Places Panel.Frank Reininghaus
This resolves a regression caused by the Places Panel rewrite. There is a small glitch left when reordering items (dragging below the last or above the first item only shows the drop indicator when first dragging out of the item and then back), but I prefer not to fix this glitch right now because this would require a more intrusive change, and I do not want to risk regressions because is not much time left to fix them before 4.9.0 is released. Thanks to Peter Penz for providing some advice about this issue. BUG: 302557 FIXED-IN: 4.9.0 (cherry picked from commit f4c960025167b7c7e04e1290ac9d9fee03a9b62d)
2012-06-16Renaming: Don't select unknown extensionsPeter Penz
If a file with an unknown extension gets renamed, it is assumed that the letters after the last point represent the extension and won't be selected. BUG: 301893 FIXED-IN: 4.9.0
2012-06-13Fix regression: Open file if entering it in the URL-navigatorPeter Penz
The regression has been introduced when hiding the DolphinDirLister inside KFileItemModel. Now the signal urlIsFileError() gets forwarded to the container again where the file will be opened. BUG: 301757 FIXED-IN: 4.9.0
2012-06-12Drag pixmap: Turn off the hover-statePeter Penz
2012-06-12Drag-pixmap fixesPeter Penz
- Don't use the selection-tinted icon when dragging a single item - Decrease the vertical gap for the hotspot - Prevent drawing tree-lines when dragging items for the Places Panel CCBUG: 301624
2012-06-11Update "isExpandable" and "size"-rolesPeter Penz
If the "isExpandable"- or "size"-role is shown for a folder, the number of sub-items must be watched to be able to update the state of those 2 roles. This fixes the issue that e.g. no expanding-toggle is shown if an sub-directory has been created inside an empty directory. BUG: 293972 FIXED-IN: 4.9.0
2012-06-09Folders Panel: Also count directory linksPeter Penz
... otherwise no expansion toggle will be shown. The implementation is a compromise between performance and correctness: If the directory contains links that are not directories, an unnecessary expansion toggle will be shown. But this is better than showing no expansion toggle in case if the directory contains links that point to other directories. BUG: 299997 FIXED-IN: 4.9.0
2012-06-09Inline renaming: ESC should cancel the renamingPeter Penz
When emitting the roleEditingCanceled-signal it must be prevented that a roleEditingFinished-signal is emitted because of some action taken in the receiver-slot. BUG: 301480 FIXED-IN: 4.9.0
2012-06-08Inline renaming: Improve focus handlingPeter Penz
Fix issue that cancelling the inline-renaming by clicking on the other split view applies the wrong focus. Thanks to Frank Reininghaus for the initial patch and noticing this issue. CCBUG: 301252
2012-06-08Krazy fixesPeter Penz
2012-06-08Inline renaming fixesPeter Penz
- Don't use an outdated KFileItem when renaming an item more than once - Use the same font as the view - Don't lose the focus when an editor-popup is shown BUG: 299327 BUG: 298883 BUG: 301253 FIXED-IN: 4.9.0
2012-06-03Ctrl+Shift+click should have the same effect as Shift+clickFrank Reininghaus
This makes Dolphin 2.0's behaviour consistent with Dolphin 1.x. BUG: 300788 FIXED-IN: 4.9.0
2012-06-02Always support a moving animation in case of the details viewPeter Penz
This fixes the issue that resizing items results in flickering when expandable items are shown.
2012-05-30Improve arrow key navigation in Details View with expanded foldersFrank Reininghaus
If the current folder is collapsed, pressing the left arrow key now moves the focus to the parent folder. CCBUG: 300582 (cherry picked from commit 93daadae28f7e3b5cffd7b713a2a287e4fa62ccd)
2012-05-28Implement dropping of items into the Places PanelPeter Penz
Some polishing regarding the icons and group-alignment must still be done, but at least the basic functionality is back again.
2012-05-26Show all items in the directory when the name filter is clearedFrank Reininghaus
The problem was the following: While a QMutableSetIterator iterates the items in the QSet m_filteredItems, all items that match the new filter are removed from the set. However, to ensure that the iterator still reaches all items in the set, one must not use QSet::remove(), but rather the iterator's remove() method (see QMutableSetIterator docs). CCBUG: 300504 (cherry picked from commit 288473a96cdd8888f7fc91d0a551d6cbde5fd5dc)
2012-05-26Use an italic font for symbolic linksFrank Reininghaus
BUG: 298218 FIXED-IN: 4.9.0
2012-05-26Minor coding style fixesPeter Penz
2012-05-26Further preperations for drag & drop support in the places panelPeter Penz
2012-05-21Colorize icons when an item is selectedPeter Penz
BUG: 295515 FIXED-IN: 4.9.0
2012-05-21Places Panel: Show drop indicatorPeter Penz
The dropping itself has not been implemented yet.
2012-05-18Enable basic drag and drop support for the Places PanelPeter Penz
The dropping has not been implemented yet, however in the context of this step the creating of the drag-pixmap is now forwarded to the item-widgets. This allows creating some optimized dragging-pixmaps e.g. for the details-view, where only the name and icon should be provided as drag-pixmap.
2012-05-17Fix index-range issuePeter Penz
2012-05-17Create unit-test for KStandardItemModelPeter Penz
2012-05-17KStandardItemModel: Fix inconsistent internal statePeter Penz
Assure that the index-cache is kept consistent with the items when a removing or inserting is done. A unit-test will be created as soon as possible.
2012-05-17Add unit-test to test a possible crash when updating group-headersPeter Penz
2012-05-17Fix crash related to group-headersPeter Penz
If multiple ranges are inserted or removed, the updating of the group-headers may only be done after _all_ ranges have been inserted/removed and not after each individual range. Otherwise the layouter-cache is not in a consistent state yet.
2012-05-16Shorten the "path" content if possiblePeter Penz
Replace the home-path by '~' for having a shorter content.
generated by cgit v1.3 (git 2.53.0) at 2026-05-06 12:04:35 +0000