| Age | Commit message (Collapse) | Author |
|
If doLayout() is invoked with the 'NoAnimation' hint, it must be assured
that any ongoing animations are stopped.
|
|
At the moment, only key press events are tested, and the current item
and selection after the event are verified.
Moreover, this commit makes sure that
KItemListController::keyPressEvent() really does not select anything
if the selection mode is NoSelection.
(cherry picked from commit 7457f4868cf0bc83e8a90ce5693292378f3d07c4)
|
|
The asynchronous resolving to bypass performance bottlenecks is not necessary
anymore as multiple ranges can be inserted in one step now. This solves the issue
that e.g. opening a tree resulted in temporary unknown icons for a short period
of time.
|
|
Having animated items is useful when e.g. deleting or inserting one
item or when the size or position slightly changes by increasing the
zoom level or the window size. However if the number of rows or columns
change, the animation gets obtrusive and in this case lets just apply
the final layout.
|
|
The problem was that m_keyboardAnchorIndex and m_keyboardAnchorPos were
not updated when Home or End are pressed. This causes the following
unexpected behavior in Icons View: Press Home, then Right, then Down,
then Home, finally Down. One would expect that the first item in the
second row is the current item then, but before this commit, it was the
second one because the controller still remembered that the second
column was active before Home was pressed.
(cherry picked from commit 999234a94ae41cfb4f2167d2779b562ebf8127ce)
|
|
Prevent that the moving-animation crosses other items when zooming or
changing the window size.
|
|
For some roles the sorting has not been implemented.
BUG: 292941
FIXED-IN: 4.8.1
|
|
|
|
- Assure a proper minimim width in the compact mode.
- Don't calculate the old position of hidden items to animate the
moving. Just show them directly.
|
|
CCBUG: 292816
FIXED-IN: 4.8.1
(cherry picked from commit f5ecaee9c40c940fe8e1bf4a7d50fe0b18e1932b)
|
|
Only animate the moving of items if the new position is within the same
row or the same column. Otherwise just fade in the icon on the new position.
This makes the the animations when resizing the window or changing the zoom-level
a lot more pleasant.
CCBUG: 289238
|
|
BUG: 292270
FIXED-IN: 4.8.1
|
|
BUG: 292501
FIXED-IN: 4.8.1
|
|
The problem was that KFileItemModel::setExpanded() used KUrl::url()
to determine the names of the subfolders. This method encodes special
characters, such that comparing the folder names with the unencoded URLs
stored in the model fails.
Using KUrl::path(), which does not encode special characters, fixes the
problem.
CCBUG: 291781
FIXED-IN: 4.8.1
(cherry picked from commit 80d9bfec580bf01b0ee584fc4bb46e3d59a0ba7c)
|
|
This commit fixes a regression caused by the recent commit
9f711b5f2e1d1fd856cd6b033e6adb96f9b46d8a.
CCBUG: 292250
(cherry picked from commit 84a9cc4bf6e9decc4c102102c4b04162369eb0fe)
|
|
This commit fixes a problem in KItemListView::doLayout(): This function
assumed that firstVisibleIndex is a constant.
However, if the view is scrolled to the bottom with previews enabled,
and then previews are disabled (and the icon size is much smaller
without previews), this function changes the scroll offset, which also
changes the the first visible index. Using the unchanged variable causes
trouble later on (i.e., it makes items which are actually inside the
view area invisible).
lastVisibleIndex is not needed before the scroll offset change and is
const after that, so its calculation is moved a few lines down.
CCBUG: 291841
FIXED-IN: 4.8.1
(cherry picked from commit cc8f5b4939062df44ce0bd314ac4ae04973b9830)
|
|
BUG: 288748
FIXED-IN: 4.8.0
REVIEW: 103721
(cherry picked from commit e56a363aa6106477fa1577cb0b1bc2a6389910c8)
|
|
(cherry picked from commit dbf0bfffa72c190ed1c8b406c65c9e67b6f65d4f)
|
|
Thanks to Nikita Skovoroda for the initial patch and the analyses.
BUG: 290947
FIXED-IN: 4.8.0
|
|
Thanks to Nikita Skovoroda for the patch!
CCMAIL: [email protected]
|
|
This prevents a delayed update when resizing the window e.g. in the details
view. As no animated item position changes can happen for dynamic item sizes
the synchronous relayout is fine from a performance point of view.
BUG: 290953
FIXED-IN: 4.8.0
|
|
If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance
-> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled.
Additionally the duration for the smooth-scrolling has been decreased from 200 ms
to 100 ms to reduce the lag.
A wrong calculation of the end-value has been fixed that might trigger
a wrong position of the content.
BUG: 291740
BUG: 291607
FIXED-IN: 4.8.0
|
|
Note that the clearing is not done on mouse press, but on mouse release.
The reason is that there are situations when multiple items are selected
and pressing the mouse on one of them should not clear the selection
(e.g., drag and drop of multiple items).
BUG: 290854
REVIEW: 103703
FIXED-IN: 4.8.0
(cherry picked from commit 9f711b5f2e1d1fd856cd6b033e6adb96f9b46d8a)
|
|
|
|
subdirectories
BUG: 290745
FIXED-IN: 4.8.0
|
|
Thanks to Christoph Feck for the hint.
BUG: 290536
FIXED-IN: 4.8.0
|
|
The selection anchor must be reset when changing the current item
to the root of the tree.
BUG: 290832
FIXED-IN: 4.8.0
|
|
|
|
BUG: 291103
FIXED-IN: 4.8.0
|
|
When downloading a large file the preview should not be recreated each time
a change-notification has been received. Create the preview after getting
the first file change, but postpone creating the next previews until no change
has been done during a longer period of time.
BUG: 290698
FIXED-IN: 4.8.0
|
|
I'm trusting Christoph Feck's advice here. Additionally the smooth scaling
has been activated to fix bug 290865.
BUG: 290865
FIXED-IN: 4.8.0
|
|
The calculation of the root-expansion level had been incorrect which
lead to a wrong indentation on some directories.
BUG: 290757
FIXED-IN: 4.8.0
|
|
Root-cause was that the signal KDirLister::completed(KUrl) must be watched
by the model and not KDirLister::completed().
BUG: 290182
FIXED-IN: 4.8.0
|
|
Even if double-click is used as default setting, the folders panel should
open folders with a single-click.
BUG: 289971
FIXED-IN: 4.8.0
|
|
Thanks to Jonathan Marten and Christoph Feck for the analyses
and the patch.
Still open: The focus frame in cleanlooks is not drawn.
CCBUG: 290536
|
|
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.
As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).
BUG: 288908
FIXED-IN: 4.8.0
|
|
BUG: 289917
BUG: 278236
FIXED-IN: 4.8.0
|
|
|
|
BUG: 289889
FIXED-IN: 4.8.0
|
|
|
|
Don't check whether the m_layoutTimer is active: Changing the
item offset must always trigger a synchronous layout, otherwise
the smooth-scrolling might get jerky.
|
|
When groups are enabled in Dolphin the key-up and key-down keys did not behave
consistent in comparison to traditional views or like done in editors.
CCBUG: 261995
CCBUG: 262038
|
|
When switching to a group that is not shown currently, the group headers
won't be updated. The root-cause was that the m_groups-cache must be reset
when the roles have been changed.
CCBUG: 289654
|
|
- Uninitialized types count as one group
- Let the receiver of the signal itemsMoved() decide whether unmoved items
really result in an unchanged visual appearance. This might e.g. be the case
if the grouping is turned on and the group-names change although the items
themselves have not changed their position.
BUG: 289654
FIXED-IN: 4.8.0
|
|
If a protocol like fish is used, the sorting of sub-trees was wrong. The root
cause was a wrong comparing of URLs where the protocol was not initialized.
BUG: 289697
FIXED-IN: 4.8.0
|
|
This allows a useful grouping by paths when e.g. searching files.
BUG: 269335
FIXED-IN: 4.8.0
|
|
The role is used to determine whether a directory can be expanded at all. This
is e.g. not the case if a directory has 0 items or the target-URL is different
from the item-URL.
The expansion toggle will get hidden if a directory is not expandable.
CCBUG: 288521
|
|
The patch 30ae57ba807ecadfdef833a4895621fc330badc9 did not resolve the
issue completely: The pending items to insert must be dispatched before
checking for duplicates.
Related to this report the expanding for the remote-protocol has been
disabled.
BUG: 288521
FIXED-IN: 4.8.0
|
|
Also in case if only one item is shown the navigation-keys should
trigger a selection of the current item. This works now consistent
within all view-modes (there have been been behavior differences
in Dolphin 1.7 depending on the used mode).
BUG: 289589
FIXED-IN: 4.8.0
|
|
If a parent item got expanded and collapsed again, KDirLister keeps
the items of the previously expanded directory. Hence inserting new
items there will result in emitting the signal newItems() and a check
must be done whether the parent is still expanded.
BUG: 289598
FIXED-IN: 4.8.0
|