| Age | Commit message (Collapse) | Author |
|
REVIEW: 106333
(cherry picked from commit acef4b1c287a315b42550c27fc18ac4b9f49746c)
|
|
Thanks to Todd Jennings for the patch!
CCBUG: 304752
REVIEW: 106304
|
|
KParts::ListingFilterExtension.
REVIEW: 106289
(cherry picked from commit cb79ee6a881e2b4418bccc22480e3e269e5b0af9)
|
|
The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.
CCBUG: 304524
(cherry picked from commit a9c2bdc3b53955693e716bbab58c318fe25bdc9b)
|
|
For top-level roles like "Name" and "Size", the group translation is 0.
In that case, the "group" member of the corresponding RoleInfo struct
must be an empty string. This is expected by the code which generates
Dolphin's menus, which group the top-level roles into a sub menu with
the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression
caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c.
Thanks to Christoph Feck for investigating this issue!
CCBUG: 305228
(cherry picked from commit 168d0511c754008cc679589566d961beb9f6cc10)
|
|
Acked by Frank
REVIEW: 106049
BUGS: 305228
FIXED-IN: 4.9.1
(cherry picked from commit 199fabbaa8d8a12fb49e4c9922c38ec8b033923c)
|
|
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
BUG: 303133
|
|
Patch by Emmanuel Pescosta <[email protected]>
BUG: 303375
REVIEW: 105575
FIXED-IN: 4.9.0
|
|
FIXED-IN: 4.9.1
REVIEW: 105832
BUG: 303133
|
|
Moreover, make sure that the selection rectangle is large enough to
include the stars.
Patch by Emmanuel Pescosta. Thanks for the patch!
CCBUG: 302624
REVIEW: 105830
(cherry picked from commit 146c77eaa226915cd3cd01e112fcde42fd8c06c4)
|
|
Patch by Benni Hill. Thanks for the patch!
CCBUG: 304467
(cherry picked from commit 4d39dbc9620cd30826bfab4a42cf31702aeac6d8)
|
|
|
|
Use QStyle icon sizes instead of hard coding 16 or 32 pixels.
Using styles that follow KDE settings (every KStyle, e.g.
Oxygen) the icon sizes can be configured by the user in
System Settings.
The size for the icon/details view can be later changed
by the user, overriding the defaults. The icon size for the
places panel is not (yet?) configurable separately.
(Not resolving the bug, see comment in review request)
CCBUG: 301959
REVIEW: 105548
|
|
This resolves a regression caused by the Places Panel rewrite. There is
a small glitch left when reordering items (dragging below the last or
above the first item only shows the drop indicator when first dragging
out of the item and then back), but I prefer not to fix this glitch
right now because this would require a more intrusive change, and I do
not want to risk regressions because is not much time left to fix them
before 4.9.0 is released.
Thanks to Peter Penz for providing some advice about this issue.
CCBUG: 302557
|
|
If a file with an unknown extension gets renamed, it is assumed
that the letters after the last point represent the extension and
won't be selected.
BUG: 301893
FIXED-IN: 4.9.0
|
|
The regression has been introduced when hiding the DolphinDirLister
inside KFileItemModel. Now the signal urlIsFileError() gets forwarded
to the container again where the file will be opened.
BUG: 301757
FIXED-IN: 4.9.0
|
|
|
|
- Don't use the selection-tinted icon when dragging a single item
- Decrease the vertical gap for the hotspot
- Prevent drawing tree-lines when dragging items for the Places Panel
CCBUG: 301624
|
|
If the "isExpandable"- or "size"-role is shown for a folder, the
number of sub-items must be watched to be able to update the
state of those 2 roles.
This fixes the issue that e.g. no expanding-toggle is shown
if an sub-directory has been created inside an empty directory.
BUG: 293972
FIXED-IN: 4.9.0
|
|
... otherwise no expansion toggle will be shown. The implementation
is a compromise between performance and correctness: If the directory
contains links that are not directories, an unnecessary expansion
toggle will be shown. But this is better than showing no expansion
toggle in case if the directory contains links that point to other
directories.
BUG: 299997
FIXED-IN: 4.9.0
|
|
When emitting the roleEditingCanceled-signal it must be prevented
that a roleEditingFinished-signal is emitted because of some
action taken in the receiver-slot.
BUG: 301480
FIXED-IN: 4.9.0
|
|
Fix issue that cancelling the inline-renaming by clicking
on the other split view applies the wrong focus.
Thanks to Frank Reininghaus for the initial patch and noticing
this issue.
CCBUG: 301252
|
|
|
|
- Don't use an outdated KFileItem when renaming an item more than once
- Use the same font as the view
- Don't lose the focus when an editor-popup is shown
BUG: 299327
BUG: 298883
BUG: 301253
FIXED-IN: 4.9.0
|
|
This makes Dolphin 2.0's behaviour consistent with Dolphin 1.x.
BUG: 300788
FIXED-IN: 4.9.0
|
|
This fixes the issue that resizing items results in flickering
when expandable items are shown.
|
|
If the current folder is collapsed, pressing the left arrow key now
moves the focus to the parent folder.
CCBUG: 300582
(cherry picked from commit 93daadae28f7e3b5cffd7b713a2a287e4fa62ccd)
|
|
Some polishing regarding the icons and group-alignment must still
be done, but at least the basic functionality is back again.
|
|
The problem was the following: While a QMutableSetIterator iterates the
items in the QSet m_filteredItems, all items that match the new filter
are removed from the set. However, to ensure that the iterator still
reaches all items in the set, one must not use QSet::remove(), but
rather the iterator's remove() method (see QMutableSetIterator docs).
CCBUG: 300504
(cherry picked from commit 288473a96cdd8888f7fc91d0a551d6cbde5fd5dc)
|
|
BUG: 298218
FIXED-IN: 4.9.0
|
|
|
|
|
|
BUG: 295515
FIXED-IN: 4.9.0
|
|
The dropping itself has not been implemented yet.
|
|
The dropping has not been implemented yet, however in the context of
this step the creating of the drag-pixmap is now forwarded to
the item-widgets. This allows creating some optimized dragging-pixmaps
e.g. for the details-view, where only the name and icon should
be provided as drag-pixmap.
|
|
|
|
|
|
Assure that the index-cache is kept consistent with the items when
a removing or inserting is done. A unit-test will be created as soon
as possible.
|
|
|
|
If multiple ranges are inserted or removed, the updating of
the group-headers may only be done after _all_ ranges have been
inserted/removed and not after each individual range. Otherwise
the layouter-cache is not in a consistent state yet.
|
|
Replace the home-path by '~' for having a shorter content.
|
|
|
|
Prevent that a manual call to save changed bookmarks is
necessary.
|
|
This should be handled automatically when the hidden-state of
the item itself gets toggled.
|
|
The saving is still disabled currently until 100 % backward
compatibility with KFilePlacesView has been reached.
|
|
|
|
Using the latest resource-watcher from kde-runtime does not make
this workaround necessary anymore.
|
|
Follow the suggestion from Vishesh Handa and copy the ResourceWatcher
code from kde-runtime instead of creating a dependency. This will of
course get removed again as soon as Nepomuk's resource watcher will
get a public API.
|
|
|
|
Just use a string-comparison as default-compare.
|