┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/kitemviews
AgeCommit message (Collapse)Author
2012-02-08Layout optimizationsPeter Penz
- Differ internally between margins and paddings - Add a small padding in the icons-view and the compact-views - Optimize the width of the icons-view if previews are shown
2012-02-08Drag and drop: Adjust destination if the item is no directory or desktop-filePeter Penz
The URL of the view should be used as destination target if a dropping is not done above a directory or desktop-file. BUG: 293511 FIXED-IN: 4.8.1
2012-02-07Compact view: Don't hide items at the bottom when grouping is turned onPeter Penz
When grouping has been turned on, it was possible that items aligned at the bottom have been hidden. BUG: 291640 FIXED-IN: 4.8.1
2012-02-06Group header improvementsPeter Penz
- Use a simpler background and colors as suggested by Martin Zilz. This is just an early draft, I need to post some comparison screenshots to Martin for review. - Fixes of some layout issues that have been revealed because of adjusting the group header heights. - More clever animation/no-animation detection when doing listview-property changes in parallel.
2012-02-05Fix potential endless loop in layoutPeter Penz
Usecase: - No scrollbar is shown - Window size will be decreased so that a scrollbar gets necessary The decreased window size minus the space required for the scrollbar results in a relayout of the items. In 99 % of all cases a decreased window size won't result in showing more items in parallel in comparison to a larger window size. However in the remaining 1 % this can happen (e.g. see bug 293318 for a sample). This results in an endless loop as now no scrollbar is required anymore, the layout changes again, the scrollbar is required again, ... BUG: 293318 FIXED-IN: 4.8.1
2012-02-05Replace setExpanded(const QSet<KUrl>&) by expandParentItems(const KUrl&)Frank Reininghaus
The use case of this function (Folders Panel) requires the expansion of the parent items of a single URL, so it's not needed to handle a full set of URLs in this function. Moreover, the issue that not only the parents, but also the URLs themselves were expanded is fixed by this commit. (cherry picked from commit 89082ca391807abdc26d8985efe6b4c27183a9b1)
2012-02-04Icons view: Layout optimizationsPeter Penz
- Assure that landscape-previews use the whole available width of the icon-area instead of only using the square width. This waste of space occured if the text-width was larger than the icon-width. - Only use one margin instead of two between the icons and the text to improve the visual appearance (thanks to Martin Zilz for the hint) BUG: 293268 FIXED-IN: 4.8.1 CCMAIL: [email protected]
2012-02-03Show the value "Unknown" for the item-count only after it has been verifiedPeter Penz
During determining the item-count for directories just show an empty string until either the item-count has been calculated or if the item-count is unknown. Thanks to Nikita Skovoroda for the initial proof-of-concept patch. BUG: 291823 FIXED-IN: 4.8.1
2012-02-03The autoscroll timer should be only a single-shot timerPeter Penz
2012-02-03Folders Panel: Show expansion toggles for directories on ISO-imagesPeter Penz
When counting the number of sub-directories consider unknown file types as potential directories. In the "worst case" an expansion toggle will be shown although the directory contains only files, however from a performance point of view this seems to be an acceptable compromise. BUG: 292642 FIXED-IN: 4.8.1
2012-02-02Fix sorting issue when sorting by "size"Peter Penz
Root cause of the issue was an overflow in: result = a - b; where result is 'int' and a and b are 'KIO::filesize_t'. BUG: 293086 FIXED-IN: 4.8.1
2012-02-02Fix pending zooming animationPeter Penz
If doLayout() is invoked with the 'NoAnimation' hint, it must be assured that any ongoing animations are stopped.
2012-02-01First version of a unit test for KItemListControllerFrank Reininghaus
At the moment, only key press events are tested, and the current item and selection after the event are verified. Moreover, this commit makes sure that KItemListController::keyPressEvent() really does not select anything if the selection mode is NoSelection. (cherry picked from commit 7457f4868cf0bc83e8a90ce5693292378f3d07c4)
2012-02-01KFileItemModelRolesUpdater: Optimize updatesPeter Penz
The asynchronous resolving to bypass performance bottlenecks is not necessary anymore as multiple ranges can be inserted in one step now. This solves the issue that e.g. opening a tree resulted in temporary unknown icons for a short period of time.
2012-02-01Don't animate items if the number of grid elements has been changedPeter Penz
Having animated items is useful when e.g. deleting or inserting one item or when the size or position slightly changes by increasing the zoom level or the window size. However if the number of rows or columns change, the animation gets obtrusive and in this case lets just apply the final layout.
2012-01-31Fix keyboard navigation issue when Home or End are pressedFrank Reininghaus
The problem was that m_keyboardAnchorIndex and m_keyboardAnchorPos were not updated when Home or End are pressed. This causes the following unexpected behavior in Icons View: Press Home, then Right, then Down, then Home, finally Down. One would expect that the first item in the second row is the current item then, but before this commit, it was the second one because the controller still remembered that the second column was active before Home was pressed. (cherry picked from commit 999234a94ae41cfb4f2167d2779b562ebf8127ce)
2012-01-31Animation optimizationsPeter Penz
Prevent that the moving-animation crosses other items when zooming or changing the window size.
2012-01-31Fix sorting issuesPeter Penz
For some roles the sorting has not been implemented. BUG: 292941 FIXED-IN: 4.8.1
2012-01-30Only move the items if at least one direction is within the item sizePeter Penz
2012-01-30Further animation optimizationsPeter Penz
- Assure a proper minimim width in the compact mode. - Don't calculate the old position of hidden items to animate the moving. Just show them directly.
2012-01-30Fix crash in Compact View if view height is smaller then item heightFrank Reininghaus
CCBUG: 292816 FIXED-IN: 4.8.1 (cherry picked from commit f5ecaee9c40c940fe8e1bf4a7d50fe0b18e1932b)
2012-01-29Make moving animations less obtrusivePeter Penz
Only animate the moving of items if the new position is within the same row or the same column. Otherwise just fade in the icon on the new position. This makes the the animations when resizing the window or changing the zoom-level a lot more pleasant. CCBUG: 289238
2012-01-28Fix regression: Respect "natural sorting" settingPeter Penz
BUG: 292270 FIXED-IN: 4.8.1
2012-01-28Assure to mark an item as unhovered on a drag-leave eventPeter Penz
BUG: 292501 FIXED-IN: 4.8.1
2012-01-25Handle folder names containing spaces correctly in the Folders PanelFrank Reininghaus
The problem was that KFileItemModel::setExpanded() used KUrl::url() to determine the names of the subfolders. This method encodes special characters, such that comparing the folder names with the unencoded URLs stored in the model fails. Using KUrl::path(), which does not encode special characters, fixes the problem. CCBUG: 291781 FIXED-IN: 4.8.1 (cherry picked from commit 80d9bfec580bf01b0ee584fc4bb46e3d59a0ba7c)
2012-01-23Make sure that Control+click toggles the selection stateFrank Reininghaus
This commit fixes a regression caused by the recent commit 9f711b5f2e1d1fd856cd6b033e6adb96f9b46d8a. CCBUG: 292250 (cherry picked from commit 84a9cc4bf6e9decc4c102102c4b04162369eb0fe)
2012-01-19Do not make items invisible when turning off previewsFrank Reininghaus
This commit fixes a problem in KItemListView::doLayout(): This function assumed that firstVisibleIndex is a constant. However, if the view is scrolled to the bottom with previews enabled, and then previews are disabled (and the icon size is much smaller without previews), this function changes the scroll offset, which also changes the the first visible index. Using the unchanged variable causes trouble later on (i.e., it makes items which are actually inside the view area invisible). lastVisibleIndex is not needed before the scroll offset change and is const after that, so its calculation is moved a few lines down. CCBUG: 291841 FIXED-IN: 4.8.1 (cherry picked from commit cc8f5b4939062df44ce0bd314ac4ae04973b9830)
2012-01-18Make PageUp/PageDown work in Dolphin's new view engineFrank Reininghaus
BUG: 288748 FIXED-IN: 4.8.0 REVIEW: 103721 (cherry picked from commit e56a363aa6106477fa1577cb0b1bc2a6389910c8)
2012-01-18Fix typo, which caused a Qt runtime warning when closing DolphinFrank Reininghaus
(cherry picked from commit dbf0bfffa72c190ed1c8b406c65c9e67b6f65d4f)
2012-01-17Avoid unnecessary animations when switching view modesPeter Penz
Thanks to Nikita Skovoroda for the initial patch and the analyses. BUG: 290947 FIXED-IN: 4.8.0
2012-01-17Fix probably wrong alternative background colorPeter Penz
Thanks to Nikita Skovoroda for the patch! CCMAIL: [email protected]
2012-01-17Do a synchronous layout for dynamic item sizes when changing the geometryPeter Penz
This prevents a delayed update when resizing the window e.g. in the details view. As no animated item position changes can happen for dynamic item sizes the synchronous relayout is fine from a performance point of view. BUG: 290953 FIXED-IN: 4.8.0
2012-01-17Disable smooth-scrolling dependent on the graphics-effect levelPeter Penz
If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance -> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled. Additionally the duration for the smooth-scrolling has been decreased from 200 ms to 100 ms to reduce the lag. A wrong calculation of the end-value has been fixed that might trigger a wrong position of the content. BUG: 291740 BUG: 291607 FIXED-IN: 4.8.0
2012-01-16If an item is clicked to trigger it, clear the rest of the selectionFrank Reininghaus
Note that the clearing is not done on mouse press, but on mouse release. The reason is that there are situations when multiple items are selected and pressing the mouse on one of them should not clear the selection (e.g., drag and drop of multiple items). BUG: 290854 REVIEW: 103703 FIXED-IN: 4.8.0 (cherry picked from commit 9f711b5f2e1d1fd856cd6b033e6adb96f9b46d8a)
2012-01-15Don't select items if the selection toggle has been disabledPeter Penz
2012-01-15Don't show a expanding-toggle in the Folders Panel if there are no ↵Peter Penz
subdirectories BUG: 290745 FIXED-IN: 4.8.0
2012-01-14Fix current-item indicator in combination with the cleanlooks stylePeter Penz
Thanks to Christoph Feck for the hint. BUG: 290536 FIXED-IN: 4.8.0
2012-01-12Fix selection issue when expanding a treePeter Penz
The selection anchor must be reset when changing the current item to the root of the tree. BUG: 290832 FIXED-IN: 4.8.0
2012-01-11Prevent accessing an item with an invalid indexPeter Penz
2012-01-10Fix issue that shift + drag does not move filesPeter Penz
BUG: 291103 FIXED-IN: 4.8.0
2012-01-09Prevent generating previews all the time during downloading a large filePeter Penz
When downloading a large file the preview should not be recreated each time a change-notification has been received. Create the preview after getting the first file change, but postpone creating the next previews until no change has been done during a longer period of time. BUG: 290698 FIXED-IN: 4.8.0
2012-01-07Revert patch using the native graphicssystem as defaultPeter Penz
I'm trusting Christoph Feck's advice here. Additionally the smooth scaling has been activated to fix bug 290865. BUG: 290865 FIXED-IN: 4.8.0
2012-01-06Details view: Fix wrong expansion levelPeter Penz
The calculation of the root-expansion level had been incorrect which lead to a wrong indentation on some directories. BUG: 290757 FIXED-IN: 4.8.0
2012-01-05Fix issue that an empty directory is shown in the split modePeter Penz
Root-cause was that the signal KDirLister::completed(KUrl) must be watched by the model and not KDirLister::completed(). BUG: 290182 FIXED-IN: 4.8.0
2012-01-05Folders Panel: Activate folders on single-clickPeter Penz
Even if double-click is used as default setting, the folders panel should open folders with a single-click. BUG: 289971 FIXED-IN: 4.8.0
2012-01-05Fix style-issues in items when not using OxygenPeter Penz
Thanks to Jonathan Marten and Christoph Feck for the analyses and the patch. Still open: The focus frame in cleanlooks is not drawn. CCBUG: 290536
2011-12-30Fix inconsistency in selection managerPeter Penz
When a selection has been done with non-linear ranges, it was possible that the anchor item pointed to an invalid index that resulted into an invalid selection. As part of this fix the sorting for DolphinView::selectedItems() has been disabled (if the caller assumes a sorted selection he must manually adjust it). BUG: 288908 FIXED-IN: 4.8.0
2011-12-27Fix issue that dragging pictures/videos to Google-Search/YouTube failsPeter Penz
BUG: 289917 BUG: 278236 FIXED-IN: 4.8.0
2011-12-27Fix group-header clipping in compact modePeter Penz
2011-12-27Fix icon alignment issue in the details viewPeter Penz
BUG: 289889 FIXED-IN: 4.8.0