┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/main.cpp
AgeCommit message (Collapse)Author
2019-06-22Open new instance of Dolphin if no URLs are givenAlexander Saoutkin
Summary: BUG: 408387 BUG: 408244 FIXED-IN: 19.08.0 Currently Dolphin only opens a new instance of itself in the following two scenarios: 1. No other Dolphin instances ( D21666 deals with not matching daemonized instances) are currently running. 2. A new instance is explicitly asked for via: `dolphin --new-window` A third scenario is needed to fix this bug: 3. If no URLs are passed in as arguments then open a new instance. This patch adds this third scenario. Test Plan: STEPS TO REPRODUCE 1. Open Dolphin 2. Right-click on Dolphin's Task Manager Entry and click "Start New Instance" 3. A new instance is created. As my system stuff is not built on master I am unable to replicate the bug (and can't confirm whether this fixes it), hence I'll rely on @ngraham to confirm whether this patch fixes the issue. Reviewers: ngraham, elvisangelaccio Reviewed By: ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21691
2019-05-30Open externally called files/directories in new tabsAlexander Saoutkin
Summary: FEATURE: 183429 FIXED-IN: 19.08.0 GUI: new cli argument --new-window Externally called files/directories are opened in a a new tab of an instance of Dolphin that already exists. If any of the given URIs are already open in a tab, then those tabs are activated instead of a new tab being opened. If there is no instance then the files/directories are opened in a new window. The newly opened file/directory has its tab activated, and consequently, the window is also activated. When the user clicks "Open In New Window" or "Detach Tab", the files/directories are opened in a new window. Test Plan: [Manual] Before testing, set the default file manager in system settings as the newly built Dolphin executable. One must also include the new dolphin executable in the $PATH, otherwise some functions will attempt to open the system dolphin instead of the new one. Furthermore, running two different versions of Dolphin (in particular, where one does not have this patch included) can result in bugs appearing, in particular, new tabs not opening as old instances will not recognise the DBus commands sent to it. However, I see no reason why a user will have two different versions of Dolphin (apart from people like us :D). Open directories with the help of auxillary programs (i.e. a browser). The files/directories should appear in a new window if an instance does not exist. If an existence already exists, then a new tab should be opened and activated in that instance and the window activated. Use QDBusViewer to open folders/items by calling the ShowFolders/ShowItems methods in org.freedesktop.FileManager1 of the Dolphin instance. When a user chooses to "Open In New Window"/"Detach Tab" then the files/directories should be opened in a new window. Reviewers: #dolphin, elvisangelaccio Subscribers: zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16648
2019-01-04Use https over http for homepage urlFriedrich W. H. Kossebau
2018-11-11Update copyright year in KAboutDataElvis Angelaccio
GIT_SILENT
2018-11-04Update maintainership in KAboutDataElvis Angelaccio
As discussed on kfm-devel and agreed upon with Emmanuel.
2018-07-29Drop redundant setAttribute for WA_DeleteOnCloseElvis Angelaccio
Every KMainWindow (which DolphinMainWindow inherits) already has this attribute set.
2018-06-19Do not duplicate work of KAboutData::setupCommandLine()Laurent Montel
2018-05-31Re-allow running Dolphin as the root user (but still not using sudo)Nathaniel Graham
Summary: Prohibiting the use of Dolphin as the actual root user (not using `sudo` or `kdesu`) breaks legitimate use cases for using the root user. An example is Kali, a distro that logs in as the root user by default as a deliberate design choice. In such an environment, there is no additional security vulnerability beyond what you're already potentially exposing yourself to. So, let's re-enable it. BUG: 387974 FIXED-IN: 18.08.0 Test Plan: - Log in as normal user and run `sudo dolphin`: you get an error message. - Log in as normal user and run `kdesu dolphin`: you get an error message. - Log in as the root user and run dolphin normally: it works. Reviewers: markg, elvisangelaccio, #dolphin Reviewed By: markg Subscribers: chinmoyr, cfeck, elvisangelaccio, mmustac, Fuchs, markg, graesslin, nicolasfella, zzag, kfm-devel, emmanuelp Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12795
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2017-02-19Disallow executing Dolphin as root on LinuxEmmanuel Pescosta
Basically a copy of commit kate/9adcebd3c2e476c8a32e9b455cc99f46b0e12a7e which was written by Martin Grässlin.
2016-11-22Use the current window icon in QIcon::fromTheme()R.J.V. Bertin
This prevents removing the application icon when icon lookup fails, on Mac or MS Windows.
2016-05-05Change wording of Directory to Folder.Frederik Schwarzer
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2016-01-14Update copyright yearFrank Reininghaus
2015-11-29Call KLocalizedString::setApplicationDomain("dolphin");Albert Astals Cid
dolphin is using -DTRANSLATION_DOMAIN=\"dolphin\" that is wrong for applications, apps need to use KLocalizedString::setApplicationDomain since that makes some other things like the transltators tab in the about dialog show. I have not removed -DTRANSLATION_DOMAIN=\"dolphin\" because on the other hand this code is also a library (i.e. the dolphin kpart). The "being pedandly correct" fix would be using -DTRANSLATION_DOMAIN=\"dolphin\" only to compile the files that are part of the kpart but that's prone to break at some point and using both KLocalizedString::setApplicationDomain and -DTRANSLATION_DOMAIN does not create any problem so i went that route CCMAIL: [email protected]
2015-11-14Enable KCrash crash handler.Andreas Cord-Landwehr
2015-10-21Allow home directories with non-local file paths.Emmanuel Pescosta
Paths like file:/home/me work now instead of showing an error message. BUG: 352743 BUG: 353550 FIXED-IN: 15.08.3 REVIEW: 125586
2015-07-29Enable automatic update of version numberRagnar Thomsen
Use CMake variables autoupdated by release script. Dolphin version is automatically updated to KDE Applications version.
2015-04-27Reorder code in main.cpp ("cluster definitions and setters")Emmanuel Pescosta
2015-04-27Simplify startup split view handlingEmmanuel Pescosta
* Instead of setting and resetting GeneralSettings's split view option, just pass it on to openFiles/openDirectories. * Require at least one url in openFiles/openDirectories REVIEW: 123395
2015-04-22Add dbus interface to dolphinAshish Bansal
Implemented org.freedesktop.FileManager1 dbus interface in dolphin http://www.freedesktop.org/wiki/Specifications/file-manager-interface/ REVIEW: 123313 BUG: 343016
2015-03-25Enable high DPI pixmaps in DolphinDavid Edmundson
2015-02-25Bump the Qt version to 5.4 and the KF5 version to 5.7Emmanuel Pescosta
Added all required components Reviewed-By: David Edmundson
2015-02-24Fix build on Jenkins (or with BUILD_TESTING=ON)Hrvoje Senjan
2015-02-24Fix the build temporarilyLuca Beltrame
The port of Dolphin to categorized logging created errors in one specific point only, in main.cpp: undefined reference to `DolphinDebug()' I couldn't spot any obvious error, so for now I did it the bad way (warnings should not be commented out!) to keep it building while a real solution is found. CCMAIL: [email protected]
2015-02-24Replace kDebug/kWarning by categorized logging (org.kde.dolphin)Emmanuel Pescosta
2015-02-10Assume links passed via cmdline args are local filesArjun AK
If not, when the user types 'dolphin nonexistantfile' he will be taken to 'http://nonexistantfile' BUG: 343906
2015-02-09Construct URLs passed via cmdline args using QUrl::fromUserInput()Arjun AK
Otherwise user will have to type "dolphin file:///tmp" instead of "dolphin /tmp" REVIEW: 122475 BUG: 343906
2015-02-06Migrate settingsMontel Laurent
2015-02-04Add dolphin dbus serviceEmmanuel Pescosta
2015-02-04Port Dolphin away from KApplication, KCmdLineArgs and K4AboutDataMathieu Tarral
2014-11-20Fix Exports.Andrius da Costa Ribas
REVIEW: 121078
2014-10-18Fix includesMontel Laurent
2014-10-16Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Conflicts: dolphin/src/main.cpp kdepasswd/kcm/kcm_useraccount.desktop plasma/applets/folderview/folderview.cpp
2014-10-16Update "About" dialog after maintainership changeFrank Reininghaus
See http://lists.kde.org/?t=140990649300001&r=1&w=2 REVIEW: 120608
2014-06-04Change the Dolphin version in frameworks to 4.60Frank Reininghaus
Since the KF5 libraries and the applications will not have a synchronized release schedule any more, it does not make sense to continue using KDE_VERSION_STRING as the Dolphin version.
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2014-01-12Update copyright yearFrank Reininghaus
2013-06-26Use the KDE SC version also as the Dolphin versionsFrank Reininghaus
This has some advantages: (a) The version actually changes for every bug fix release, making it easier to find out which version a bug reporter has used. (b) No changes in Dolphin's source code are required to keep the version always up to date. (c) It is more transparent for users because there are not two different versions any more.
2013-05-11Update copyright yearFrank Reininghaus
2013-02-17Update Dolphin version to 2.2.60Frank Reininghaus
2013-01-30Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
Conflicts: dolphin/src/tests/kfileitemmodeltest.cpp
2013-01-29Update Dolphin version to 2.2 for KDE 4.10.0Frank Reininghaus
2013-01-16Merge remote-tracking branch 'origin/KDE/4.10'Luca Beltrame
2013-01-15Update Dolphin version to 2.1.98 for KDE 4.10 RC 3Frank Reininghaus
2013-01-13Update Dolphin's About dialogFrank Reininghaus
Emmanuel has contributed a lot of useful patches to Dolphin. Thank you very much for that! The Dolphin community is looking forward to further contributions from you. CCMAIL: [email protected]
2012-12-27Increase Dolphin version to 2.1.97 for the 2nd release candidateFrank Reininghaus
2012-12-07Merge remote-tracking branch 'origin/KDE/4.9'Frank Reininghaus
2012-12-07Update Dolphin version to 2.1.95 for KDE 4.10 RC 1Frank Reininghaus
generated by cgit v1.3 (git 2.53.0) at 2026-04-18 15:32:40 +0000