| Age | Commit message (Collapse) | Author |
|
Summary:
The `RenameDialog::slotResult()` slot is currently never called because
the dialog is deleted first, due to the usage of the `WA_DeleteOnClose`
attribute. This breaks the scroll-to-renamed-file feature when the
inline renaming is disabled.
Instead of deleting the dialog on close, we can use `deleteLater()` when
we are sure the dialog has actually finished its job, which is when the
KIO move job emits the `result` signal.
Test Plan:
- Disable inline renaming
- Rename a file so that it goes out of the view
- Check whether the view scrolls to the renamed file.
Reviewers: #dolphin, emateli
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D13304
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
Conflicts:
CMakeLists.txt [versions]
src/panels/places/placesitemmodel.cpp
|
|
Summary:
Applied suggested changes to [[ https://phabricator.kde.org/D9662 | D9662 ]]
- Enum instead of bool
- Use QStringLiteral
Test Plan: Visual inspection
Reviewers: ngraham, elvisangelaccio, #dolphin
Reviewed By: ngraham, #dolphin
Subscribers: #dolphin
Tags: #dolphin, #kde_applications
Differential Revision: https://phabricator.kde.org/D9911
|
|
visible
Summary:
Only by chance I discovered that this option is visible but only when inside home. Before that I always edited dolphinrc to reenable it.
I think it's less confusing to always show it but toggle its enabled state
Test Plan:
compile and run
show folderspanel context-menu in different places
Reviewers: #dolphin, emmanuelp, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: elvisangelaccio
Tags: #dolphin, #kde_applications
Differential Revision: https://phabricator.kde.org/D9662
|
|
Changes in folderspanel.cpp in 464b13f3828e5cdd03438d0881c3a62c7cda6333 were unintended.
|
|
Also use override instead of Q_DECL_OVERRIDE
|
|
Test Plan: compile
Reviewers: #dolphin, broulik
Reviewed By: broulik
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D8637
|
|
Summary:
Added the option to limit the displayed folders in the folder panel (F7) to the tree below the user's home directory if the current URL is inside the home directory.
This can be configured in the preferences General/Behaviour tab by checking the corresponding check box.
Reviewers: #dolphin, elvisangelaccio, emmanuelp
Reviewed By: #dolphin, elvisangelaccio, emmanuelp
Subscribers: emmanuelp, elvisangelaccio, #konqueror, #dolphin
Differential Revision: https://phabricator.kde.org/D7477
|
|
It's equivalent to KJob::uiDelegate() from kcoreaddons.
|
|
We need to resolve from desktop:/ to file:/ so that DropJob
can handle application .desktop files.
CCBUG: 363991
|
|
REVIEW: 126771
|
|
present, because KFileMetaDataWidget is in KDELibs4Support)
Reviewed-By: Vishesh Handa
|
|
|
|
|
|
FoldersPanel::loadTree to make the FoldersPanel work again
REVIEW: 122631
BUG: 344204
FIXED-IN: 15.04
|
|
REVIEW: 121678
|
|
|
|
|
|
|
|
Remove KonqOperations::doPaste.
|
|
DolphinContextMenu::createPasteAction used to be precise about destination
("Paste To Folder"), while now it's precise about the source (what to paste).
It was decided that this was more useful and consistent anyway.
REVIEW: 120695
|
|
REVIEW: 120688
|
|
|
|
|
|
|
|
|
|
It's a bit more code, but this way if you want e.g. custom error handling
you know what to change :)
|
|
REVIEW: 120159
|
|
and remove them. Porting docs added to https://community.kde.org/Frameworks/Porting_Notes#libkonq
|
|
|
|
|
|
Conflicts:
dolphin/src/dolphincontextmenu.cpp
dolphin/src/panels/folders/treeviewcontextmenu.cpp
|
|
This removes the remaining unchecked accesses to the clipboard mime
data after commit 7828b057da0491f1b08bfaec681067e195d7b6ca. According
to a bug report, it can be a null pointer on Wayland.
BUG: 335053
REVIEW: 118649
|
|
TerminalPanel connections to konsole part were not converted since there
is no header available that defines these function, we have to keep the
old syntax here.
Additionally the new syntax no longer accepts QPointer arguments, we have
to explicitly call .data() there.
|
|
This does not work properly yet, there are probably quite a few bad signal/
slot connections due to KUrl -> QUrl. However dolphin starts without
crashing.
Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
and I have no idea how it is supposed to be used.
This is the first commit for review 117395
|
|
|
|
Fixes a regression introduced by commit
7a364cbf489af25e123d18713523151a3a53f814.
Patch reviewed and pushed by Frank Reininghaus.
BUG: 313342
FIXED-IN: 4.10.1
|
|
(because there exists items with it's names
Fixed the "same" buggy behavior when dropping files/folders
Select also putted files (PUT operation - SimpleJob) - e.g. Paste content from clipboard
BUG: 233335
REVIEW: 107351
|
|
* Implemented Rename-Inline-Option in Settings Dialog
* Re-enable renaming items with the rename dialog in Folderview-Panel
BUG: 306705
REVIEW: 107072
|
|
(Double-Click - show folder content and expand folder)
BUG: 295573
REVIEW: 106497
FIXED-IN: 4.9.2
|
|
Patch 106381 Comment #3:
When "Open folders during drag operations" is enabled, two things happen, both in the DolphinView and in the Folders Panel:
1) When hovering a folder that can be expanded (this is the case for folders with sub-folders in the Folders Panel and in the DolphinView if in Details View mode), toggle its "expanded" state.
2) When hovering a folder that can not be expanded (i.e., a folder without sub-folders or any folder in Icons or Compact View), open this folder in the DolphinView via the KItemListController's itemActivated(int) signal.
The bug described in bug 293200 comment 3 is that 1) is always wanted, but 2) is not wanted for the Folders Panel.
BUG: 293200
FIXED-IN: 4.9.2
|
|
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
BUG: 303133
FIXED-IN: 4.9.1
(cherry picked from commit b3c3da985159a9627c079ad615cd77fc5f7bb72a)
|
|
FIXED-IN: 4.9.1
REVIEW: 105832
BUG: 303133
|
|
- Determine group of a new entry dependent from the protocol
- Allow panels to forward error-messages to the view-container
(also applied to Folders Panel)
|
|
The folders-panel signals have been adjusted too for consistency.
|
|
Up to now the view-engine only provided a model-implementation that
supports file-items. The view-engine always had been designed to be able
to work with any kind of model, so now a KStandardItemModel is available.
The plan is to convert the places panel to the new view-engine. It should
be no problem to fix this until the feature freeze - in the worst case
the places-panel code could be reverted while still keeping the
KStandardItemModel changes.
|
|
BUG: 286893
FIXED-IN: 4.9.0
|
|
Fix some naming inconsistencies regarding the usage of 'dir' vs.
'directory' vs. 'folder'.
|