┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/information/informationpanel.cpp
AgeCommit message (Collapse)Author
2019-04-23[InformationPanel] Use the new inline configuration modeStefan Brüns
Summary: The current external configuration dialog has some issues: - its layout is suboptimal, as its initial size is typically to small - it is quite disassociated with the actual widget it configures, properties have a different order, and the property names can be quite abstract without the corresponding value. Doing the visibility selection inline typically avoids the sizing problem, as the containing application (dolphin) is often vertically maximized. The selection becomes more obvious, as the item order is kept, and the values are shown. Depends on D20524 CCBUG: 389571 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20525
2019-04-20More coding style fixesElvis Angelaccio
GIT_SILENT
2019-03-24[InformationPanel] Hide the video when the preview is disabled, avoid ↵Méven Car
computing the preview when it is disabled Summary: Bug symptom : {F6698879} Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled. Test Plan: # In dolphin with an information panel with preview on # launch the video preview # Disable the preview ->bug 1: the video player control is still visible (this bug fix this) # re-enable preview -> bug 2: the video stays visible and the preview is displayed above (this bug fix this) Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19844
2019-03-22Convert foreach to for loopsMéven Car
Test Plan: Compile Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19911
2019-03-17Fix a todo: InformationPanelContent::configureSettings code is moved to ↵Méven Car
InformationPanel::contextMenuEvent Summary: Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent Adding necessary accessors and changing visibility of one slot. Test Plan: 1 compile 2 in dolphin right on the information panel 3 toggle preview 4 from the same context menu, click configure, metadadata settings appears 5 toggle "condensed date" if available Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19832
2019-03-12Correctly position context menu of the information panel under wayland with ↵Méven Car
a secondary screen Summary: According to my testing this bug occurs because Qcursor::pos() does not work as expected under wayland on a secondary screen, then it returns inaccurate data. This could hide bugs elsewhere. BUG: 404799 FIXED-IN: 19.04.0 Test Plan: Under Wayland test the context menu on both screens. Do the same under Xorg. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, ngraham, nicolasfella, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19535
2018-11-30Use isEmpty() hereLaurent Montel
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-03Use nullptr + add explicit keywordMontel Laurent
Test Plan: compile Reviewers: #dolphin, broulik Reviewed By: broulik Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D8637
2017-01-18Port away from deprecated KIO::Job::ui()Elvis Angelaccio
It's equivalent to KJob::uiDelegate() from kcoreaddons.
2014-12-14port away from deprecated KFileItem(mode_t mode, mode_t permissions, const ↵Emmanuel Pescosta
QUrl &url, bool delayedMimeTypes = false);
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-05dolphin: convert panels/ and filterbar to qt signal/slot syntaxAlex Richardson
TerminalPanel connections to konsole part were not converted since there is no header available that defines these function, we have to keep the old syntax here. Additionally the new syntax no longer accepts QPointer arguments, we have to explicitly call .data() there.
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2012-04-17Ensure authentication data is cached properlyPeter Penz
The attached patch sets the main window on the main directory lister in DolphinView and KIO jobs in DolphinMainWindow to ensure that login data for remote protocols such as sftp, ftp are cached properly for the duration of the application. Otherwise, the end user is going to end up being unnecessarily re-prompted to enter password login information. Thanks to Dawit Alemayehu for the patch! REVIEW: 104614 FIXED-IN: 4.9.0
2011-12-06Fix selection issue for Information PanelPeter Penz
When the selection changes during the Information Panel is invisible, it still should get applied so that when making the Information Panel visible again a valid selection is shown. Thanks to A. Janardhan Reddy for the patch! (Additionally the obsolete check for an empty selection has been removed, as this cannot happen anymore with the new view engine) BUG: 281452 FIXED-IN: 4.8.0
2011-12-04avoid double marginsNi Hui
2011-07-31normalize signals/slotsMontel Laurent
2011-02-09Coding style update for pointer comparisonPeter Penz
Most developers seem to prefer if (ptr) ... if (!ptr) ... in comparison to if (ptr != 0) ... if (ptr == 0) ... Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
2011-02-09Use capitalized includes of recently committed kdelibs headersPeter Penz
2011-02-04Update e-mail address from [email protected] to [email protected]Peter Penz
2011-02-04Use capitalized KDE includesPeter Penz
2011-02-02Provide a default size-hint for all panelsPeter Penz
This fixes the issue that the initial size of the Filter Panel is too small.
2010-12-31Lock panels per default and allow to unlock them like in Amarok.Peter Penz
BUG: 229811 FIXED-IN: 4.7.0 svn path=/trunk/KDE/kdebase/apps/; revision=1210424
2010-11-04Fix issue that moving the mouse above the viewport might trigger showing the ↵Peter Penz
meta-information of an only shortly hovered file. svn path=/trunk/KDE/kdebase/apps/; revision=1193131
2010-10-07Reset the file-item when the viewport is entered and files are selected. ↵Peter Penz
Otherwise the information of the file-item will be shown instead of the selection. svn path=/trunk/KDE/kdebase/apps/; revision=1183544
2010-10-07Internal cleanups to assure that the asynchronous request for the ↵Peter Penz
folder-information works reliable when switching between directories. svn path=/trunk/KDE/kdebase/apps/; revision=1183537
2010-10-07Internal cleanup for panels: Let the panel-implementations decide whether ↵Peter Penz
they accept an URL or not. svn path=/trunk/KDE/kdebase/apps/; revision=1183480
2010-09-28Fix issue that no content is shown in the Information Panel on startupPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=1180723
2010-07-22Properly KIO::stat instead of simply using the KFileItem constructor whenSebastian Trueg
showing metadata for the currently selected folder. This way we can even get rid of the special handling of nepomuksearch:/ URLs since the KIO slave provides a nice name and all you need to show to the user. Even nicer: When clicking an entry in the metadata view the resulting query will be related to the one clicked resource. This resource will then be represented by the query folder. So all in all this patch makes Dolphin more generic while additionally activating a new feature. svn path=/trunk/KDE/kdebase/apps/; revision=1152959
2010-05-29Fix the nasty layout reparenting by adding the InformationPanelContent into ↵Peter Penz
a layout. Thanks to Sebastian Trüg for the hint! CCMAIL: [email protected] svn path=/trunk/KDE/kdebase/apps/; revision=1132028
2010-01-07Fixed issue that the Information Panel might show the old filename after ↵Peter Penz
renaming an item. Added implementation note, as a working code had been removed some time ago because of a performance bottleneck. BUG: 198375 svn path=/trunk/KDE/kdebase/apps/; revision=1071287
2010-01-06When changing the selection, the currently shown file item should be reset. ↵Peter Penz
This fixes the issue that changing the selection with the keyboard might not have an effect if an item is hovered with the mouse. BUG: 210177 svn path=/trunk/KDE/kdebase/apps/; revision=1070745
2010-01-06Fixed issue that Ctrl+A sometimes did not result in an update of the ↵Peter Penz
Information Panel. As a sideeffect some code simplification has been done, which was possible because of the column view refactorization some time ago. svn path=/trunk/KDE/kdebase/apps/; revision=1070740
2009-11-19Provide clickable resources for the Information Panel. Thanks to Sebastian ↵Peter Penz
Trüg für the patch! CCMAIL: [email protected] svn path=/trunk/KDE/kdebase/apps/; revision=1051553
2009-07-05The complexity of the class InformationPanel has grown a lot from KDE 4.0 to ↵Peter Penz
KDE 4.3. One main reason is that a lot of things are done now asynchronously with timers to prevent a blocking UI and unnecessary expensive operations. To keep the Information Panel maintainable and prepared for future features a cleanup has been done. The whole user interface handling has been moved into the class InformationPanelContent that offers a straight forward interface: showItem(const KFileItem& item) and showItems(const KFileItemList& items). The class InformationPanel is responsible for calling those methods in a way that hovering items, changing directories, doing selections, rename and delete operations, ... don't result in calling showItem() 10 times per second. This cleanup won't be backported to KDE 4.3.x svn path=/trunk/KDE/kdebase/apps/; revision=991902
2009-07-05Improve performance of Dolphin:Peter Penz
- When changing a directory the receiving of the meta data is done now with a short delay. This gives the directory lister the chance to show the directory as fast as possible. - Prevent that DolphinInformationPanel::reset() is invoked when changing a directory. The method only needs to get invoked if an item has been deleted or renamed. - Cache an unknown file item. This improves the startup time of Dolphin (-> KFileItem constructor is invoked only once instead of up to 6 times). svn path=/trunk/KDE/kdebase/apps/; revision=991840
2009-06-21Use the name of the property instead of the label, otherwise the stored keys ↵Peter Penz
would get invalid as soon as we get translated labels. svn path=/trunk/KDE/kdebase/apps/; revision=984677
2009-06-21disable Nepomuk legacy code to eliminate deprecated-warningsPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=984621
2009-06-21Simplify how Nepomuk comments can be edited by the user:Peter Penz
- don't provide any mode for editing, just let the user directly manipulate the comment inside the text widget - automatically save changes, no explicit confirmation required svn path=/trunk/KDE/kdebase/apps/; revision=984592
2009-06-20Disable additional properties per default as discussed with Sebastian Trüg.Peter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=984493
2009-06-20We won't get translated labels for Nepomuk literals in KDE 4.3.0... At least ↵Peter Penz
assure that camelcase labels like "fileLocation:" are replaced by "File location:" (thanks to Sebastian Trüg for the code) svn path=/trunk/KDE/kdebase/apps/; revision=984190
2009-06-19Fix bottleneck when renaming several hundrets of items (the expensive update ↵Peter Penz
of m_selection is not required). svn path=/trunk/KDE/kdebase/apps/; revision=984020
2009-06-10fixed resizing issues when having long comments:Peter Penz
* embed the comment label inside a scrollarea * assure that the "add comment..."/"change comment..." link is always visible * assure that the maximum width of the meta data widget is set to the panel width (otherwise the panel would be increased in an unlimited way when having a text without spaces) CCMAIL: [email protected] svn path=/trunk/KDE/kdebase/apps/; revision=979621
2009-05-26fixed krazy string warningPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=973291
2009-05-06Don't crash if the the metadata widget is 0 (this can happen if Nepomuk has ↵Peter Penz
not been started). svn path=/trunk/KDE/kdebase/apps/; revision=964469
2009-04-24fixed issue that the video preview size was wrong during resizing the ↵Peter Penz
information panel svn path=/trunk/KDE/kdebase/apps/; revision=958762
2009-04-23- Postpone the video player initialization until the play button has been ↵Peter Penz
pressed. - Assure that the video player has the same size as the preview widget. Convincing the embedded video player to dynamically resize during playing a video seems to be impossible - I need to check the Phonon::VideoPlayer source code to get the root cause for the currently strange behavior :-( svn path=/trunk/KDE/kdebase/apps/; revision=958332
generated by cgit v1.3 (git 2.53.0) at 2026-04-18 18:14:42 +0000