| Age | Commit message (Collapse) | Author |
|
Better for screen readers etc.
|
|
BUG: 364956
BUG: 453211
|
|
|
|
|
|
Refactor and simplify things along the way.
BUG: 457813
|
|
|
|
BUG: 430095
BUG: 412902
FIXED-IN: 21.08
|
|
With this patch dolphin now supports the following touch gestures:
* Tap gesture to interact/open with directories, files and so on
* TapAndHold and release gesture for access to the context menu (main window, panel folder, places and information)
* TapAndHold and moving gesture for drag and drop action (main windows, panel folder and places)
* pinch gesture for zoom in main window
* kinetic scrolling (QScroller) for main window, panel folder, panel places, panel information, setting preview and service
* two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up
* two finger tap gesture to toggle item selection, similar to Ctrl and left mouse click
FEATURE: 385066
FIXED-IN: 20.11.80
You are currently rebasing branch 'touch' on '85241a924'.
|
|
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
|
|
Summary: Needed after D28901 to ensure we get the UDS_RECURSIVE_SIZE out of the stat calls.
Test Plan: Trash size is visible in status bar and information panel again.
Reviewers: ngraham, dfaure, #dolphin
Reviewed By: dfaure
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D28950
|
|
Summary: CCBUG: 392882
Test Plan:
1. Create a file
2. Remove it, so that it goes to the trash
3. Open trash
4. Empty trash
Before:
Information panel icon is still user-trash-full
After:
Information panel icon is changed to user-trash
Reviewers: ngraham, #dolphin, elvisangelaccio
Reviewed By: ngraham, #dolphin, elvisangelaccio
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D23668
|
|
play/pause videos or audio
Summary:
It is based on D19844.
I did my best to avoid glitches hence the amount of code touched.
Retry after @pekkah D7539
Moved the setting to the information panel context menu, no more timer
Settings screenshot :
{F6700220}
This would mach the same feature in the open/save dialog (although not equivalent)
{F6696456}
FEATURE: 378613
FIXED-IN: 19.08.0
GUI: New information panel context menu option
Test Plan:
Without auto play
- in dolphin with the information panel opened, and the auto media play feature is disabled (right on the information panel)
- hover over media files
- the behavior is the same as before the patch
With auto play
- in dolphin with the information panel opened, and the auto media play feature is enabled
- hover over media files
- media is played automatically
- hover over another media file, the new media is previewed
Use audio or video file as media.
Reviewers: #dolphin, elvisangelaccio, ngraham
Reviewed By: #dolphin, elvisangelaccio, ngraham
Subscribers: ngraham, broulik, kfm-devel, pekkah
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D19782
|
|
Summary:
The current external configuration dialog has some issues:
- its layout is suboptimal, as its initial size is typically to small
- it is quite disassociated with the actual widget it configures, properties
have a different order, and the property names can be quite abstract
without the corresponding value.
Doing the visibility selection inline typically avoids the sizing problem,
as the containing application (dolphin) is often vertically maximized.
The selection becomes more obvious, as the item order is kept,
and the values are shown.
Depends on D20524
CCBUG: 389571
Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: elvisangelaccio, meven, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D20525
|
|
GIT_SILENT
|
|
computing the preview when it is disabled
Summary:
Bug symptom : {F6698879}
Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled.
Test Plan:
# In dolphin with an information panel with preview on
# launch the video preview
# Disable the preview
->bug 1: the video player control is still visible (this bug fix this)
# re-enable preview
-> bug 2: the video stays visible and the preview is displayed above (this bug fix this)
Reviewers: #dolphin, elvisangelaccio, ngraham
Reviewed By: #dolphin, elvisangelaccio, ngraham
Subscribers: ngraham, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D19844
|
|
Test Plan: Compile
Reviewers: #dolphin, elvisangelaccio, ngraham
Reviewed By: #dolphin, elvisangelaccio, ngraham
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D19911
|
|
InformationPanel::contextMenuEvent
Summary:
Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent
Adding necessary accessors and changing visibility of one slot.
Test Plan:
1 compile
2 in dolphin right on the information panel
3 toggle preview
4 from the same context menu, click configure, metadadata settings appears
5 toggle "condensed date" if available
Reviewers: elvisangelaccio, #dolphin
Reviewed By: elvisangelaccio, #dolphin
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D19832
|
|
a secondary screen
Summary:
According to my testing this bug occurs because Qcursor::pos() does not work as expected under wayland on a secondary screen, then it returns inaccurate data.
This could hide bugs elsewhere.
BUG: 404799
FIXED-IN: 19.04.0
Test Plan:
Under Wayland test the context menu on both screens.
Do the same under Xorg.
Reviewers: #dolphin, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: elvisangelaccio, ngraham, nicolasfella, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D19535
|
|
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
|
|
Test Plan: compile
Reviewers: #dolphin, broulik
Reviewed By: broulik
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D8637
|
|
It's equivalent to KJob::uiDelegate() from kcoreaddons.
|
|
QUrl &url, bool delayedMimeTypes = false);
|
|
REVIEW: 120688
|
|
|
|
TerminalPanel connections to konsole part were not converted since there
is no header available that defines these function, we have to keep the
old syntax here.
Additionally the new syntax no longer accepts QPointer arguments, we have
to explicitly call .data() there.
|
|
This does not work properly yet, there are probably quite a few bad signal/
slot connections due to KUrl -> QUrl. However dolphin starts without
crashing.
Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
and I have no idea how it is supposed to be used.
This is the first commit for review 117395
|
|
The attached patch sets the main window on the main directory
lister in DolphinView and KIO jobs in DolphinMainWindow to ensure
that login data for remote protocols such as sftp, ftp are cached
properly for the duration of the application. Otherwise, the end
user is going to end up being unnecessarily re-prompted to enter
password login information.
Thanks to Dawit Alemayehu for the patch!
REVIEW: 104614
FIXED-IN: 4.9.0
|
|
When the selection changes during the Information Panel is
invisible, it still should get applied so that when making the
Information Panel visible again a valid selection is shown.
Thanks to A. Janardhan Reddy for the patch!
(Additionally the obsolete check for an empty selection has
been removed, as this cannot happen anymore with the new view
engine)
BUG: 281452
FIXED-IN: 4.8.0
|
|
|
|
|
|
Most developers seem to prefer
if (ptr) ...
if (!ptr) ...
in comparison to
if (ptr != 0) ...
if (ptr == 0) ...
Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
|
|
|
|
|
|
|
|
This fixes the issue that the initial size of the Filter Panel is too small.
|
|
BUG: 229811
FIXED-IN: 4.7.0
svn path=/trunk/KDE/kdebase/apps/; revision=1210424
|
|
meta-information of an only shortly hovered file.
svn path=/trunk/KDE/kdebase/apps/; revision=1193131
|
|
Otherwise the information of the file-item will be shown instead of the selection.
svn path=/trunk/KDE/kdebase/apps/; revision=1183544
|
|
folder-information works reliable when switching between directories.
svn path=/trunk/KDE/kdebase/apps/; revision=1183537
|
|
they accept an URL or not.
svn path=/trunk/KDE/kdebase/apps/; revision=1183480
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1180723
|
|
showing metadata for the currently selected folder. This way we can even get rid of the
special handling of nepomuksearch:/ URLs since the KIO slave provides a nice name and
all you need to show to the user.
Even nicer: When clicking an entry in the metadata view the resulting query will be related
to the one clicked resource. This resource will then be represented by the query folder.
So all in all this patch makes Dolphin more generic while additionally activating a new feature.
svn path=/trunk/KDE/kdebase/apps/; revision=1152959
|
|
a layout. Thanks to Sebastian Trüg for the hint!
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=1132028
|
|
renaming an item.
Added implementation note, as a working code had been removed some time ago because of a performance bottleneck.
BUG: 198375
svn path=/trunk/KDE/kdebase/apps/; revision=1071287
|
|
This fixes the issue that changing the selection with the keyboard might not have an effect if an item is hovered with the mouse.
BUG: 210177
svn path=/trunk/KDE/kdebase/apps/; revision=1070745
|
|
Information Panel. As a sideeffect some code simplification has been done, which was possible because of the column view refactorization some time ago.
svn path=/trunk/KDE/kdebase/apps/; revision=1070740
|
|
Trüg für the patch!
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=1051553
|
|
KDE 4.3. One main reason is that a lot of things are done now asynchronously with timers to prevent a blocking UI and unnecessary expensive operations.
To keep the Information Panel maintainable and prepared for future features a cleanup has been done. The whole user interface handling has been moved into the class InformationPanelContent that offers a straight forward interface: showItem(const KFileItem& item) and showItems(const KFileItemList& items).
The class InformationPanel is responsible for calling those methods in a way that hovering items, changing directories, doing selections, rename and delete operations, ... don't result in calling showItem() 10 times per second.
This cleanup won't be backported to KDE 4.3.x
svn path=/trunk/KDE/kdebase/apps/; revision=991902
|