┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/information/informationpanelcontent.cpp
AgeCommit message (Collapse)Author
2019-04-23[InformationPanel] Use the new inline configuration modeStefan Brüns
Summary: The current external configuration dialog has some issues: - its layout is suboptimal, as its initial size is typically to small - it is quite disassociated with the actual widget it configures, properties have a different order, and the property names can be quite abstract without the corresponding value. Doing the visibility selection inline typically avoids the sizing problem, as the containing application (dolphin) is often vertically maximized. The selection becomes more obvious, as the item order is kept, and the values are shown. Depends on D20524 CCBUG: 389571 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20525
2019-04-22[InformationPanel] Remove obsolete intermediate wrapper widget/layoutStefan Brüns
The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper. Summary: Depends on D20667 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, elvisangelaccio Reviewed By: #dolphin, #baloo, ngraham, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20668
2019-04-20More coding style fixesElvis Angelaccio
GIT_SILENT
2019-04-20[InformationPanelContent] Fix coding styleElvis Angelaccio
GIT_SILENT
2019-04-18Fix missing update of file name label in information panel without previewStefan Brüns
Summary: The file name label was only updated when the preview was shown, after the function was moved into a conditional section. This is a regression caused by commit 405aa4878f75 ("[InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled"). Test Plan: Hide the preview in dolphin's information panel Hover different files, the name label reflects the hovered file again Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: meven Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20660
2019-04-14[Information Panel] Remove nullptr checks for MetaDataWidget memberStefan Brüns
Summary: The widget has the same livetime as the containing widget, no need to do any extra checks. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20514
2019-03-24[InformationPanel] Hide the video when the preview is disabled, avoid ↵Méven Car
computing the preview when it is disabled Summary: Bug symptom : {F6698879} Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled. Test Plan: # In dolphin with an information panel with preview on # launch the video preview # Disable the preview ->bug 1: the video player control is still visible (this bug fix this) # re-enable preview -> bug 2: the video stays visible and the preview is displayed above (this bug fix this) Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19844
2019-03-17When the previewed video stops playing (because of the user or because the ↵Méven Car
media playback has ended), show the regular preview only if the preview setting is on. Summary: Bug result after test plan : {F6698812} Test Plan: In dolphin with the information panel Select a video Play the video Disable the preview through the context menu (the video stays playing and visible and this will get fixed in a subsequent review) Stop the video -> the video preview reappears when it should not Reviewers: elvisangelaccio Reviewed By: elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19843
2019-03-17Fix a todo: InformationPanelContent::configureSettings code is moved to ↵Méven Car
InformationPanel::contextMenuEvent Summary: Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent Adding necessary accessors and changing visibility of one slot. Test Plan: 1 compile 2 in dolphin right on the information panel 3 toggle preview 4 from the same context menu, click configure, metadadata settings appears 5 toggle "condensed date" if available Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19832
2019-03-12Correctly position context menu of the information panel under wayland with ↵Méven Car
a secondary screen Summary: According to my testing this bug occurs because Qcursor::pos() does not work as expected under wayland on a secondary screen, then it returns inaccurate data. This could hide bugs elsewhere. BUG: 404799 FIXED-IN: 19.04.0 Test Plan: Under Wayland test the context menu on both screens. Do the same under Xorg. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, ngraham, nicolasfella, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19535
2018-08-29Consider all thumbnailers for the information panel and tooltipsFabian Vogt
Summary: The text thumbnail is really useful in tooltips, but disabled by default in KIO. Having just a larger version of the placeholder icon from the theme doesn't make a lot of sense, so try the best to get a proper preview. Same applies to the information panel, which would otherwise just show the same icon. Test Plan: Got textfile previews in tooltips and in the information panel even if disabled. Reviewers: #dolphin, elvisangelaccio, broulik, markg, ngraham Reviewed By: #dolphin, broulik, ngraham Subscribers: abetts, markg, kfm-devel, ngraham Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15138
2018-08-21Port away from kdelibs4supportElvis Angelaccio
Summary: It was only used as fallback when baloo was not found, but `KFileMetaDataWidget` is useless without nepomuk. The result of this patch is that the information panel and the tooltips won't be available from platforms without baloo (instead of being available but broken). The baloo dependency remains optional. Closes T8720 Test Plan: Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and make sure it doesn't show tooltips or the information panel. Reviewers: #dolphin, broulik, ngraham Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T8720 Differential Revision: https://phabricator.kde.org/D14814
2018-05-12Fix broken build without baloo-widgets masterElvis Angelaccio
D11245 introduced a dependency on baloo-widgets master, but baloo-widgets is only an optional dependency.
2018-04-11infopanel: Add choice of date display formatsMichael Heidelbach
Summary: Let user choose date display format via checkbox in context menu [[ https://phabricator.kde.org/file/info/PHID-FILE-5xjr7tvypj3jaczjtzrz | Example ]] Depends on D11242 FEATURE: 392352 Test Plan: visual inspection Reviewers: #dolphin, markg, ngraham Reviewed By: markg, ngraham Subscribers: broulik, markg, ngraham Tags: #dolphin, #kde_applications Differential Revision: https://phabricator.kde.org/D11245
2018-04-03Show folder previews for items that have a Places Panel entryNathaniel Graham
Summary: informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug. BUG: 392621 FIXED-IN: 18.08.0 Test Plan: Before: {F5782793} After: {F5782794} Detailed test procedure: - Open the Information Panel - Turn on previews - Put some pictures in ~/Pictures - Hover over it and see that the Information Panel shows a preview of its contents - Add ~/Pictures to the Places panel - Hover over it again and see that previews are no longer displayed - Apply the patch and restart Dolphin - Hover over it once more and see that there are now previews, yay! Reviewers: #dolphin, markg, elvisangelaccio Reviewed By: markg, elvisangelaccio Subscribers: markg, broulik Differential Revision: https://phabricator.kde.org/D11894
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-02-15[Information Panel] Adjust painting icons for high dpi scalingKai Uwe Broulik
Instead of creating our own KIconLoader (which takes ~5ms here) just use QIcon::fromTheme which already does everything right. BUG: 390488 Differential Revision: https://phabricator.kde.org/D10532
2018-01-18Merge remote-tracking branch 'origin/Applications/17.12'Luca Beltrame
Conflicts: CMakeLists.txt [versions] src/panels/places/placesitemmodel.cpp
2018-01-06infopanel fully resizableMichael Heidelbach
Summary: Currently Infopanel does wrap its title when trying to narrow it. Initially: {F5619283} Expanded: {F5619284} Resizing fails, watch cursor: {F5619286} Patch applied: {F5619287} Maybe this behaviour it intentional. Personally, I prefer the patch. Test Plan: compile & run Resize infopanel with long title Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: renatoo, vhanda, nicolasfella, elvisangelaccio, ngraham Tags: #dolphin, #kde_applications Differential Revision: https://phabricator.kde.org/D9664
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-01-21Merge branch 'Applications/16.12'Elvis Angelaccio
2017-01-21informationpanel: don't change color of scrollarea's viewportElvis Angelaccio
This code was added a long time ago in b1c9b5126d, but the commit message doesn't explain why. If we remove it nothing seems to change and we fix the ugly background on the scrollbar when Breeze draws a frame around dockable panels. BUG: 366203 FIXED-IN: 16.12.2 REVIEW: 129861
2017-01-18Port away from deprecated KIO::Job::ui()Elvis Angelaccio
It's equivalent to KJob::uiDelegate() from kcoreaddons.
2016-07-14Give FileMetaDataConfigurationDialog a parentChristoph Feck
REVIEW: 128439
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-02-24Removed unused KGlobal includes and use KIO/Job instead of KIO/JobClassesEmmanuel Pescosta
2015-02-03Ported Dolphin from KDialog to QDialog and save/restoreDialogSize to ↵Emmanuel Pescosta
KWindowConfig::save/restoreWindowSize with the help of the porting scripts. REVIEW: 122305
2015-01-30Port KGlobalSettings::smallestReadableFont() to ↵Emmanuel Pescosta
QFontDatabase::systemFont(QFontDatabase::SmallestReadableFont) REVIEW: 122308
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-10Clean includes + port to QMenuMontel Laurent
2014-10-07kdelibs4support--Montel Laurent
2014-09-12Ported KIcon to QIconEmmanuel Pescosta
REVIEW: 120159
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-06-27Revert "Fix build"Christophe Giboudeaux
This reverts commit 780e76f35bca0ced37a691a50367cf705388cc38. Update your kfilemetadata/baloo/baloo-widgets builds instead.
2014-06-27Fix buildRohan Garg
2014-06-27Fix build.Christophe Giboudeaux
2014-05-13Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Since the master branch had never been merged into frameworks since the creation of the frameworks branch, I had to fix a couple of merge conflicts and make another change in order to make it build - I hope I did not get anything wrong. We should probably merge master into frameworks on a regular basis from now on. CCMAIL:[email protected] Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/search/dolphinfacetswidget.cpp dolphin/src/statusbar/dolphinstatusbar.cpp dolphin/src/views/dolphinview.cpp
2014-05-05Allow compiling with the frameworks branches of BalooAlex Richardson
2014-05-05dolphin: convert panels/ and filterbar to qt signal/slot syntaxAlex Richardson
TerminalPanel connections to konsole part were not converted since there is no header available that defines these function, we have to keep the old syntax here. Additionally the new syntax no longer accepts QPointer arguments, we have to explicitly call .data() there.
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2014-02-24Handle font and palette changes in Dolphin list views.Emmanuel Pescosta
Also update the font of the meta data widget in InformationPanelContent (smallest readable font). BUG: 329186 BUG: 315061 FIXED-IN: 4.13 REVIEW: 115958
2014-02-06Port Dolphin to BalooVishesh Handa
Nepomuk is being replaced with Baloo
2014-01-06Kill any running preview jobs before starting a new oneFrank Reininghaus
If loading a preview takes long, it was possible before this commit that a preview for a new item was requested before the first preview was shown. In that case, there was a race condition, and the first preview to arrive stayed in the Information Panel. This commit fixes this by keeping a pointer to the preview job and killing it before starting a new one. BUG: 250787 FIXED-IN: 4.12.1 REVIEW: 114561
2013-03-16use plain text for information panelWeng Xuetian
REVIEW: 109129 BUG: 315693 CCBUG: 262464
2013-01-27escape the existing text instead of set to plain textWeng Xuetian
@info indicates it's rich text and will be added <html> tag by kdelibs, so just escape the text that will be set to label for KDE/4.10 REVIEW: 108584 BUG: 313992
2013-01-09Fix information panel interpreting html tagsKai Uwe Broulik
Only fixes the most obvious file name, the other entries in the table probably have to be fixed in the FileMetaDataWidget. REVIEW: 108307 BUG: 262464 (cherry picked from commit 3d7d900d2830c71255ff8c02f5f7439224cd4122)
2013-01-07Dolphin: Make Nepomuk Support OptionalVishesh Handa
Use the KFileMetadataWidget if Nepomuk is not present. REVIEW: 108236
generated by cgit v1.3 (git 2.53.0) at 2026-04-19 05:25:37 +0000