| Age | Commit message (Collapse) | Author |
|
m_autoPlay is read in setUrl() before setAutoPlay() is called; m_contents is
compared before resetContents() sets it. Both are undefined behavior.
Add initializers to the member-initialization lists.
Found with cppcheck
|
|
Parent the QMediaPlayer and QAudioOutput so they can get deleted with
their parent.
|
|
Explicitly grabGesture TapAndHoldGesture to be able to ignore them and
thus prevent bubbling the event to the parent widget.
BUG: 431307
|
|
media file is selected
To reproduce the crash:
- Open Dolphin, disable information panel and close Dolphin
- Re-open Dolphin
- Select a video file
- Enable information panel
- Crash
Problem is that some elements of the MediaWidget panel are created when the widget is shown, in `showEvent` (`m_seekSlider` and `m_topLayout`), and these elements are called before being created.
This MR fixes 2 different crashes:
- Crash creating panel when a video file is selected (call to `m_seekSlider` before its creation)
- Crash creating panel when a video file is selected and autoplay enabled (call to `m_topLayout` before its creation)
|
|
|
|
|
|
|
|
|